Regression: Hide price and category filters when inside of private apps page #28188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pps page The price and category filters dont make sense for private apps so when inside of the page the filters will now be hidden.
Codecov Report
@@ Coverage Diff @@
## develop #28188 +/- ##
===========================================
- Coverage 44.87% 44.84% -0.03%
===========================================
Files 767 764 -3
Lines 14954 14897 -57
Branches 2088 2069 -19
===========================================
- Hits 6710 6681 -29
+ Misses 7947 7923 -24
+ Partials 297 293 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
rique223
changed the title
dionisio-bot
bot
added
stat: ready to merge
PedroRorato
previously approved these changes
Feb 28, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
ggazzo
requested changes
Feb 28, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
PedroRorato
approved these changes
Mar 1, 2023
ggazzo
approved these changes
Mar 2, 2023
|
avoid big changes in regressions, it takes the focus away from what was really happening |
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2023
…search-nonlatin-rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Apps provider not handling apps lists correctly (#28264) Regression: Fix intermitent apps engine startup (#28254) Regression: Client is not loading new settings from server (#28248) Regression: Adjusted departments upsell modal to check for licence and modules (#28246) Regression: message-parse version update (#28245) [FIX] Notify apps engine event through ms api (#28169) Chore: Add extra stats for omnichannel video calling (#28211) Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233) Regression: Change text of buttons tooltips on custom content homepage block (#28094) Regression: run clientMessageRecieved hooks on thread main message (#27962) Regression: Jump to message not working (#28163) Regression: Hide price and category filters when inside of private apps page (#28188) [BREAK] Remove support to deprecated typing event (#28234) Regression: Fix app status filter not working in private apps page (#28198) Regression: UiKit message surface styles (#28213) [FIX] Search list missing key parameter (#28230) Regression: broken message exhibition when edited (#28180) Regression: EnableUnlimitedApps button action (#28221) Regression: Update Composer Formatters Translation Keys (#28228) Regression: EmojiPicker missing shadow on dark mode (#28236) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: MKP-265
The price and category filters dont make sense for private apps so when inside of the private apps page these filters will now be hidden.
Demo image:
Issue(s)
Steps to test or reproduce
Further comments
MKP-265