Regression: Adjusted departments upsell modal to check for licence and modules #28246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28246 +/- ##
===========================================
- Coverage 44.87% 44.82% -0.05%
===========================================
Files 771 771
Lines 14984 14984
Branches 2091 2090 -1
===========================================
- Hits 6724 6717 -7
- Misses 7963 7967 +4
- Partials 297 300 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
approved these changes
Mar 2, 2023
KevLehman
approved these changes
Mar 2, 2023
aleksandernsilva
changed the title
dionisio-bot
bot
added
the
stat: ready to merge
aleksandernsilva
changed the title
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2023
…search-nonlatin-rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Apps provider not handling apps lists correctly (#28264) Regression: Fix intermitent apps engine startup (#28254) Regression: Client is not loading new settings from server (#28248) Regression: Adjusted departments upsell modal to check for licence and modules (#28246) Regression: message-parse version update (#28245) [FIX] Notify apps engine event through ms api (#28169) Chore: Add extra stats for omnichannel video calling (#28211) Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233) Regression: Change text of buttons tooltips on custom content homepage block (#28094) Regression: run clientMessageRecieved hooks on thread main message (#27962) Regression: Jump to message not working (#28163) Regression: Hide price and category filters when inside of private apps page (#28188) [BREAK] Remove support to deprecated typing event (#28234) Regression: Fix app status filter not working in private apps page (#28198) Regression: UiKit message surface styles (#28213) [FIX] Search list missing key parameter (#28230) Regression: broken message exhibition when edited (#28180) Regression: EnableUnlimitedApps button action (#28221) Regression: Update Composer Formatters Translation Keys (#28228) Regression: EmojiPicker missing shadow on dark mode (#28236) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a regression on the departments upsell modal, for the rare cases where the workspace has an enterprise licence but has no active modules. This changes improves the check to also consider modules.
Issue(s)
Steps to test or reproduce
Further comments
OC-712