-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Jump to message not working #28163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jumpToMessage * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix RegisterForm Translations (#28156) Chore: e2e omnichannel tests - Close every opened page after the test (#28152) Chore: Remove fail-fast from matrix strategy (#28153) Chore: Fix houston metadata Regression: Fix improper usage of useEndpointData (#28050) Regression: View mode preferences without the selected option by default (#28120) Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129) Regression: Slash commands detected at any line (#28142) Regression: App requests notify admin function generating wrong link (#28111) Chore: Improve time of meteor build (#28128) Chore: Update tokens (#28079) Regression: Fix sidebar horizontal scrolling (#28125) Chore: Presence cap tweaks (#28058) Chore: Fix Services Docker Build Chore: Custom CSS (#27993) Chore: Fix CI Docker Alpine build missing (#28138) Chore: Fix CI docker publish (#28134) Chore: Refactor CI to improve code reusability and organization (#28108)
gabriellsh
changed the title
[Regression] Jump to message not working
Regression: Jump to message not working
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28163 +/- ##
===========================================
+ Coverage 44.87% 44.96% +0.09%
===========================================
Files 767 771 +4
Lines 14954 14977 +23
Branches 2088 2090 +2
===========================================
+ Hits 6710 6734 +24
Misses 7947 7947
+ Partials 297 296 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
previously requested changes
Feb 27, 2023
tassoevan
previously approved these changes
Mar 2, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2023
…search-nonlatin-rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Apps provider not handling apps lists correctly (#28264) Regression: Fix intermitent apps engine startup (#28254) Regression: Client is not loading new settings from server (#28248) Regression: Adjusted departments upsell modal to check for licence and modules (#28246) Regression: message-parse version update (#28245) [FIX] Notify apps engine event through ms api (#28169) Chore: Add extra stats for omnichannel video calling (#28211) Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233) Regression: Change text of buttons tooltips on custom content homepage block (#28094) Regression: run clientMessageRecieved hooks on thread main message (#27962) Regression: Jump to message not working (#28163) Regression: Hide price and category filters when inside of private apps page (#28188) [BREAK] Remove support to deprecated typing event (#28234) Regression: Fix app status filter not working in private apps page (#28198) Regression: UiKit message surface styles (#28213) [FIX] Search list missing key parameter (#28230) Regression: broken message exhibition when edited (#28180) Regression: EnableUnlimitedApps button action (#28221) Regression: Update Composer Formatters Translation Keys (#28228) Regression: EmojiPicker missing shadow on dark mode (#28236) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Sometimes there is a race condition and the room is opened but you don't go to the desired message. When scrolling manually to a point where the message is loaded, it then scrolls and highlights the message as it should.
Further comments
TC-486