Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Jump to message not working #28163

Merged
merged 15 commits into from
Mar 2, 2023
Merged

Regression: Jump to message not working #28163

merged 15 commits into from
Mar 2, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 24, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • Scroll up and get a message link (kebab menu) from a message that is hidden before loading more messages.
  • Paste it in the url bar

Sometimes there is a race condition and the room is opened but you don't go to the desired message. When scrolling manually to a point where the message is loaded, it then scrolls and highlights the message as it should.

Further comments

TC-486

…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix RegisterForm Translations (#28156)
  Chore: e2e omnichannel tests - Close every opened page after the test (#28152)
  Chore: Remove fail-fast from matrix strategy (#28153)
  Chore: Fix houston metadata
  Regression: Fix improper usage of useEndpointData (#28050)
  Regression: View mode preferences without the selected option by default (#28120)
  Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129)
  Regression: Slash commands detected at any line (#28142)
  Regression: App requests notify admin function generating wrong link (#28111)
  Chore: Improve time of meteor build (#28128)
  Chore: Update tokens (#28079)
  Regression: Fix sidebar horizontal scrolling (#28125)
  Chore: Presence cap tweaks (#28058)
  Chore: Fix Services Docker Build
  Chore: Custom CSS  (#27993)
  Chore: Fix CI Docker Alpine build missing (#28138)
  Chore: Fix CI docker publish (#28134)
  Chore: Refactor CI to improve code reusability and organization (#28108)
@gabriellsh gabriellsh changed the title [Regression] Jump to message not working Regression: Jump to message not working Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #28163 (c93c267) into develop (47e3c6e) will increase coverage by 0.09%.
The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28163      +/-   ##
===========================================
+ Coverage    44.87%   44.96%   +0.09%     
===========================================
  Files          767      771       +4     
  Lines        14954    14977      +23     
  Branches      2088     2090       +2     
===========================================
+ Hits          6710     6734      +24     
  Misses        7947     7947              
+ Partials       297      296       -1     
Flag Coverage Δ
e2e 44.92% <38.88%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
@gabriellsh gabriellsh added this to the 6.0.0 milestone Mar 1, 2023
@tassoevan tassoevan requested a review from a team as a code owner March 2, 2023 00:38
tassoevan
tassoevan previously approved these changes Mar 2, 2023
@ggazzo ggazzo merged commit ea86d2e into develop Mar 2, 2023
@ggazzo ggazzo deleted the fix/jumpToMessage branch March 2, 2023 04:15
gabriellsh added a commit that referenced this pull request Mar 6, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Apps provider not handling apps lists correctly (#28264)
  Regression: Fix intermitent apps engine startup (#28254)
  Regression: Client is not loading new settings from server (#28248)
  Regression: Adjusted departments upsell modal to check for licence and modules (#28246)
  Regression: message-parse version update (#28245)
  [FIX] Notify apps engine event through ms api (#28169)
  Chore: Add extra stats for omnichannel video calling (#28211)
  Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233)
  Regression: Change text of buttons tooltips on custom content homepage block (#28094)
  Regression: run clientMessageRecieved hooks on thread main message (#27962)
  Regression: Jump to message not working (#28163)
  Regression: Hide price and category filters when inside of private apps page (#28188)
  [BREAK] Remove support to deprecated typing event (#28234)
  Regression: Fix app status filter not working in private apps page (#28198)
  Regression: UiKit message surface styles (#28213)
  [FIX] Search list missing key parameter (#28230)
  Regression: broken message exhibition when edited (#28180)
  Regression: EnableUnlimitedApps button action (#28221)
  Regression: Update Composer Formatters Translation Keys (#28228)
  Regression: EmojiPicker missing shadow on dark mode (#28236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants