fix: Room members list out of order #29228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29228 +/- ##
===========================================
- Coverage 46.15% 40.39% -5.77%
===========================================
Files 678 680 +2
Lines 12713 12828 +115
Branches 2224 2193 -31
===========================================
- Hits 5868 5182 -686
- Misses 6522 7350 +828
+ Partials 323 296 -27
Flags with carried forward coverage won't be shown. Click here to find out more. |
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits) fix: respect useEmoji pref on messages (#28975) chore: Move 2fa challenge handler to rest api package (#29263) refactor(integrations): Replace Fibers dependency by Deasync (#29081) chore: improve server stream typings (#29128) fix: Livechat `CSP` whitelist validation (#29278) chore: `ListItem` stories (#29251) regression(push): fix error when adding headers to send push notification (#29287) fix: Handle login services errors (#28795) chore: skip hook if HUSKY env var is set to 0 (#29283) ci: skip husky hooks on ci (#29279) chore: Add `roomName` on Composer placeholder (#29255) regression: fix console warnings (#29277) ci: fix Release Task chore: Add Changesets (#29275) feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095) fix: Members/Channels list infinite scroll (#28636) test: use local httpbin container on github CI's (#29067) Bump vm2 version 3.9.19 (#29258) i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252) chore: Composer missing scrollbar color (#29256) ...
🦋 Changeset detectedLatest commit: 8a37ebb The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) fix: Changed contact form async validations to onSubmit (#29250) refactor: Omnichannel Department re-write (#28948) feat: Added attachments to contact history message list (#29336) fix: Clicking uploaded file title replaces current tab (#29174) fix: broken error messages on room.saveInfo & missing CF validations on omni/contact api (#28367) regression: Missing loading indicator (#29374) fix: Added check if count is truthy on `cleanRoomHistory` (#28081) chore: small tricks with keys and invalidations with marketplace page (#29369) fix: Missing await on agent leave action (#29358) refactor: useQuery for Marketplace Lists (#29348) test: add missing omnichannel contact-center tests (#28989) ci: omit vite log (#29360) chore: update `status-warning-2` color (#29321) fix: File upload in Safari, IOS devices (#27121) chore: update status-bullet colors (#29316) chore: `Contextualbar` empty state consistency (#29341) chore(deps-dev): Bump @storybook/source-loader from 6.5.15 to 6.5.16 (#27866) feat(apps): Disabling apps on trial license expiration (#29037) chore(deps-dev): Bump @storybook/manager-webpack4 from 6.5.15 to 6.5.16 (#27865) chore(deps-dev): Bump @storybook/addon-actions from 6.5.15 to 6.5.16 (#27917) ...
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: fix: marketplace filters are changing size (#28738) chore: Update highlighted word color (#29407) i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317) chore(ddp-sdk): ts-jest -> swc/jest (#29380) chore: `ToolboxAction` pressed state (#29397) chore: add logs to recurring omnichannel cron jobs (#29392) regression: `t` using always sprintf (#29396) fix: fix wrong %s translations (#29395) regression(push): fix error when selecting what to import (#29289) chore: Change ddpsdk.stream to return subscription (#29375) feat: Implement new Administration kebab reroute algorithm (#29142) chore: New mention styles (#29162)
guijun13
previously approved these changes
May 31, 2023
heitortanoue
previously approved these changes
Jun 1, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits) chore: Pages empty state consistency (#29439) refactor: Convert Omnichannel helper ee to ts (#29274) regression(i18n): Broken translations on client-side startup (#29442) chore: break down helpers.ts and create new files (#28611) test: runInBand unit test (#29484) i18n: system message copy updates (#29372) chore: emoji popup trigger length (#29282) fix: Seat counter including apps (#29489) fix: Invalid message draft (#29474) fix: message deletion fails if has files attached on filesystem storage (#29313) chore: replace meteor.call -> sdk.call (#29318) chore: deprecation api (#29347) fix: Imported messages are not displayed (#29416) chore: convert metrics to ts (#29475) chore: use new Livechat SDK Implementation (#29098) fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) ...
guijun13
approved these changes
Jun 12, 2023
dionisio-bot
bot
added
the
stat: ready to merge
matheusbsilva137
approved these changes
Jun 12, 2023
This was referenced Jun 12, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
TC-637
Steps to test or reproduce
Further comments
The sort remains being case sensitive. We decided to merge the improvements we have so far and figure a way to solve this for other queries as well, instead of doing it case by case.