This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Release/1.19.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integration testing concurrency fix * Integration testing concurrency fix * selenium does not work in iPhone browserstack * removing iPhone from test report page * corrected env name * Remove IE9Win7 test from nightwatch tests
* Smart AdServer adapter Add Smart AdServer adapter with tests * fix not supported method Replace startsWith which is not supported in all browser version by lastIndexOf. * Issue with optional parameter Fix issue when no targeting is specified and remove "undefined" value passed in url * Add dealId support for SmartAdServer adapter Set dealId received from Smart AdServer adapter response
* Smart AdServer adapter Add Smart AdServer adapter with tests * fix not supported method Replace startsWith which is not supported in all browser version by lastIndexOf. * Issue with optional parameter Fix issue when no targeting is specified and remove "undefined" value passed in url * Add currency support for SmartAdServer adapter Add currency support for SmartAdServer adapter
* Update getintent.js * Update getintent_spec.js * Update getintent.js * Update getintent.js * Update getintent_spec.js * fix test * added to list of video adapters * fixy with closures. * jshint fixes * Update getintent.js fixy * Update getintent.js bid.descriptionUrl = bidResponse.vast_url;
* Added WideOrbit adapter * Fix User Matching code * Renamed adapter + some minor JS issues * Added flag for notifying front action is header bidding. Use returned bid. * Duplicated properties fixed. * Correcting adaptermanager after wrong merge. Now all tests passes correctly. * Seting fl and jscb directly in the pageImpression-part of the url, since they are hardcoded. * Fixed above the fold parameter * No need to modify original value. * Normalizing file regarding single or double quotes. Also, properly indenting. * Removed uneeded properties: referrer (twice) and tagId. * Slightly better readiblity for variable declarations (and definition in some cases). * Refactoring regarding function naming and the way we set rank parameter. Also making sure we encode/decode site and page parameters. * Ignoring TypeScript's typing definitions. * Added initial WideOrbit Adapter tests covering url-creation part. * Completed wide orbit adapter tests with the one regarding callback response. * Slightly better test names. * Fix support for already prepared tracking pixels * Modified indenting according to coding standard * Code review fixes * Marked required parameters * Remove unused library from package.json Fix unit tests after refactoring * Added support for referrer * Added support for referrer * Updated line endings to UNIX style * Fixed formatting issue
* Fix bug with supporting non-cpm dealId bids. * Add missing adId key * Prefer const
* add adBund Adaptor * 更改正式接口地址 * change code style;add param(referrer,domain,ua) * add test in pbjs_example_gpt.html * change code style * Convert this comment to english; Remove this comment; Use adloader.loadScript function; use CONSTANTS * add unit tests * 移除gpt示例中的sizes可选参数 * tabs to spaces * change unit tests * change unit tests * change unit tests * change unit tests * change unit tests * change unit tests * change unit tests
* Add centro adapter and tests for it. * fix bug with different types of bid.sectionID and bid.unit from config * add query parameter adapter=prebid * update tests for centro adapter
* Added WideOrbit adapter * Fix User Matching code * Renamed adapter + some minor JS issues * Added flag for notifying front action is header bidding. Use returned bid. * Duplicated properties fixed. * Correcting adaptermanager after wrong merge. Now all tests passes correctly. * Seting fl and jscb directly in the pageImpression-part of the url, since they are hardcoded. * Fixed above the fold parameter * No need to modify original value. * Normalizing file regarding single or double quotes. Also, properly indenting. * Removed uneeded properties: referrer (twice) and tagId. * Slightly better readiblity for variable declarations (and definition in some cases). * Refactoring regarding function naming and the way we set rank parameter. Also making sure we encode/decode site and page parameters. * Ignoring TypeScript's typing definitions. * Added initial WideOrbit Adapter tests covering url-creation part. * Completed wide orbit adapter tests with the one regarding callback response. * Slightly better test names. * Fix support for already prepared tracking pixels * Modified indenting according to coding standard * Code review fixes * Marked required parameters * Remove unused library from package.json Fix unit tests after refactoring * Added support for referrer * Added support for referrer * Updated line endings to UNIX style * Fixed formatting issue * Fix user matching identification for JavaScript type * Duplicated WideOrbit spec after merge
* fixed leading / omission on ie11 * srcdoc rendering approach to avoid http-referrer omission prebid#977 * missing unit test for url.parse (leading slash in pathname) * move isSrcdocSupported to utils
* Add TapSense Header Bidding Adapter and tests * Update for Tapsense Prebid Header * changed var to es6 let/const * when checking for bid sizes, use utils.parseSizesInput to handle single/nested arrays * use template strings where applicable * use $$PREBID_GLOBAL$$ instead of window * scriptUrl is now static * named anonymous function in generateCallBack * add more tests in tapsense_spec.js * Url Callback parameter needed prebid global object
* hb_adid should be uppercase in all cases * Added unit tests and changed var to let
* Bidfluence Adapter * Bidfluence adapter * Fixed callback name * Final review * First commit, Test passed * Addressed change request (all but the loader one) -Changed window with $$PREBID_GLOBAL$$ -Added bid request as second param to match request response pair -Didn't change the loader since does not support custom Id to script element, necessary for our code to work. * Update reflecting the adapter changes. * Final review, completed update requests. * Fixed Indentation * Fixed global variable causing validation error.
…prebid#1030) * sanitize bidderRequest to rubicon adapter to ensure accountId is sent * use all single-quotes in rubicon stuff
* Wrote initial call logic to make request to serverbid. * Add initial bid response handling logic. * Handle requests and responses, successfully pass to add server, write initial tests. * Clean up pricing and fix tests. * Enable request credentials. * JSHint and JSCS * Incorporate code review comments. * Add function invocation to getTopWindowUrl
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * ET-1850: Adding a "lite" adapter. * Minor fix * Fix for response parsing * Minor changes * Minor changes * Updating JS lib endpoint * Updating JS lib endpoint * addressing review comments * fixing jshint error
* Update readme * Update README.md * Update README.md
…nc-with-aol-github to aolgithub-master * commit '0c6c83cc2bfaeeafa9da967c90d83da4af58e7b3': Add change log entry. Renaming and fix missing semicolon. Update parsing script tag regexp. Refactoring. Replace stub bids objects, add additional case for rendering pixels. Refactoring. Replace test consts by methods. Create separate namespace for aol globals, add unit tests. Fix unit tests, remove unnecessary spaces. Implement render pixels only once feature. Add change log entry. Add reporting ID for analytics. Add Facebook Audience Network adapter fix specs update version fix jslint errors Change to using a closure for the callback from ajax to preserve bidObj Ensure cookies get sent in request headers (prebid#1069) Rz/ajax (#5) (prebid#1042)
…e/Prebid-official-0.20.0 # Conflicts: # gulpfile.js
…18.0 to aolgithub-master * commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d': Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.20.0 Release Remove test that intermittently fails unit tests (prebid#1020) Create bids for requests without mutating ad units (prebid#1019) Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018) Fixes for Centro adapter (prebid#992) adbund adapter (prebid#932) Fix bug with supporting non-cpm dealId bids. (prebid#1006) Added referrer parameter (prebid#966) Support Video for GetIntent adapter (prebid#987) Currency support for SmartAdServer adapter (prebid#979) Deal support for SmartAdServer adapter (prebid#978) Skip test causing build failures (prebid#997) E2etest concurrency (prebid#982) Add ThoughtLeadr adapter (prebid#894) Increment Pre Version
…e/Prebid-official-0.21.0 # Conflicts: # package.json # src/adapters/sharethrough.js # test/spec/adapters/aol_spec.js # test/spec/adapters/sharethrough_spec.js
…19.0 to aolgithub-master * commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits) Disable unit tests that fails on PhantomJs. Fixed unit tests for adapter loader. Changed way of including analytic adapters. Added adapters in aolPartnersIds.json. Added changelog entry. Replace removed utils.extend functionality by object.assign. Add Inneractive adapter (prebid#1048) Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043) Add Facebook Audience Network adapter (prebid#1068) Add Atomx support (prebid#1056) Updated rubicon video bid endpoint in source and test files (prebid#1097) Pass through params to server (prebid#1084) Reset the list of slots to be requested between each action for pubmatic (prebid#1079) Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021) update PR template to include link to dev docs page (prebid#1075) Prebid 0.21.0 Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054) Video header bidding support to RhythmOne bidder adapter (prebid#1052) Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045) Fix adapter getSize (prebid#1064) ...
vzhukovsky
pushed a commit
that referenced
this pull request
Aug 1, 2018
* PET-239 IAS bid adapter multiple slot fix (#1) * PET-239 Fix. Performs the request for multiple slots on 1 call. * PET-239 Fixed Prebid tests * PET-239 Additional unit tests * Fixed errors for PR 2653 (#2) * Pet 239 ias bid adapter bug fix for multiple slots (#3) * Fixed errors for PR 2653 * Removed unnecessary block from iasBidAdapter from the comments in pull 2653
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information