Merge master into 7.x 2019-04-03 #11633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial PR for adding SQS metricset * Address comments in sqs metricset * Remove regionName as input param * Update docs * Remove count from metric names * Remove duplicate functions from rebase
…r default.disable (elastic#10911) * Add configuration knob `default.disable` for auto-discover hints to control whether log harvesting is enabled for the pod/container. {issue}10811[10811] {pull}10911[10911]
…stic#10861) This replaces the usage of a `rename` processor with an `append` + `remove` processor. Then a script processor is used to deduplicate the domains. Fixes elastic#10510
A bad processor definition in the ingest pipeline was causing the tests to stall.
…descriptions. Add notice.log support. (elastic#10916) * Update Zeek dashboard and README.md * Add support for notice.log * Update field descriptions
…ic#10936) * When using the --password env:FOO will now return an errors if FOO does not exist in the environment.
…0682) * Expose the Metadata Refresh stragegy for the Kafka output. By default the Kafka output will periodically refresh the metadata information for all the available topics. This is the default strategy that beat uses. But if you have strict permissions in place for your Kafka cluster this could lead to errors in your log while trying to get information for a topic that you don't have permissions. This commit keep the default behavior but allow to change the strategy from the config file.
With the creation of aliases for ECS we have found that some features weren't being migrated and were writing to aliases (like in elastic#10757). Consider writing to an alias field an error.
* Add s3_request metricset for AWS module * Add changelog * Change metric names and add a check for timestamp * Add ms unit to latency metrics
elastic#8688) This flag will send all perfmon measurements with a matching instance label as part of the same event (i.e. all metrics for C:, Processor X, etc.). This addresses some of the issues raised in elastic#6584. In most cases enabling this flag considerably reduces the number of events sent by metricbeat.
cleanup_timeout is used in kubernetes autodiscover to wait some time before the configurations associated to stopped containers are removed. Add an equivalent option to docker autodiscover. Fix elastic#10374
Sometimes the httptest package when using fancy TLS options doesn't put the server up as fast as it should (at least that's the theory), and we hit before it's ready, causing a false test failure. This patch makes those tests more resilient. It's possible there's something else at work here, but this bug is only seen on CI, and impossible to repro on my laptop. Fixes elastic#10722
…iguration (elastic#8688)" (elastic#11001) This reverts commit fbee6a2.
This removes the project info from the cloud.machine.type and cloud.availability_zone fields that are added to the add_cloud_metadata processor for Google Compute Engine (GCE). Fixes elastic#10968, elastic#10775 (docs)
elastic#11002) This flag will send all perfmon measurements with a matching instance label as part of the same event (i.e. all metrics for C:, Processor X, etc.). This addresses some of the issues raised in elastic#6584. In most cases enabling this flag considerably reduces the number of events sent by metricbeat. Co-Authored-By: Josh Smith <j_smith95@live.com>
…#10950) Original field name conversion was buggy.
* Add _bucket to histogram metrics
The changelog entry got merged into the wrong spot during the cherry-pick. This was originally fixed in v6.2.4. Relates elastic#6579
This PR introduces a new processor `truncate_fields`. To keep raw messages use this processor with `copy_fields`.
### `truncate_fields`
This processor truncates configured fields. Example configuration is below:
```yaml
processors:
- truncate_fields:
fields:
- message
max_bytes: 1024
fail_on_error: false
ignore_missing: true
```
### Keep raw events
This preserves the orignal field and truncates it, if it's too long.
```yaml
processors:
- copy_fields:
fields:
- from: message
to: event.original
fail_on_error: false
ignore_missing: true
- truncate_fields:
fields:
- event.original
max_bytes: 1024
fail_on_error: false
ignore_missing: true
```
* Add upgrade docs * Apply suggestions from code review * Add more detail based on review feedback * A few clarifications * Remove old file * Rename file to original name * More changes from review * Add changes from review before moving stuff around * Move some content and clean it up * Add more fixes from the review * Add more changes based on review comments
…d fix a documentation error - issue elastic#11590. (elastic#11591) * Add missing Kubernetes metadata fields to Filebeat CoreDNS module, and fix a documentation error.
…orterV2 interface (elastic#10961)
* Add get creds script and sqs script into aws module test folder * Add readme
houndci-bot
reviewed
Apr 3, 2019
| return aclIDLength | ||
| } | ||
|
|
||
| func (u ACLIDDecoder) Decode(data []byte) (interface{}, error) { |
There was a problem hiding this comment.
exported method ACLIDDecoder.Decode should have comment or be unexported
| return aclIDLength | ||
| } | ||
|
|
||
| func (u ACLIDDecoder) MaxLength() uint16 { |
There was a problem hiding this comment.
exported method ACLIDDecoder.MaxLength should have comment or be unexported
|
|
||
| const aclIDLength = 12 | ||
|
|
||
| func (u ACLIDDecoder) MinLength() uint16 { |
There was a problem hiding this comment.
exported method ACLIDDecoder.MinLength should have comment or be unexported
| @@ -322,6 +323,34 @@ func (u UnsupportedDecoder) Decode(data []byte) (interface{}, error) { | |||
|
|
|||
| var _ Decoder = (*UnsupportedDecoder)(nil) | |||
|
|
|||
| type ACLIDDecoder struct{} | |||
There was a problem hiding this comment.
exported type ACLIDDecoder should have comment or be unexported
houndci-bot
reviewed
Apr 3, 2019
| return aclIDLength | ||
| } | ||
|
|
||
| func (u ACLIDDecoder) Decode(data []byte) (interface{}, error) { |
There was a problem hiding this comment.
exported method ACLIDDecoder.Decode should have comment or be unexported
| return aclIDLength | ||
| } | ||
|
|
||
| func (u ACLIDDecoder) MaxLength() uint16 { |
There was a problem hiding this comment.
exported method ACLIDDecoder.MaxLength should have comment or be unexported
|
|
||
| const aclIDLength = 12 | ||
|
|
||
| func (u ACLIDDecoder) MinLength() uint16 { |
There was a problem hiding this comment.
exported method ACLIDDecoder.MinLength should have comment or be unexported
There was a problem hiding this comment.
@adriansr @andrewkroh I would suggest we make in most cases hound happy: #11201
| @@ -322,6 +323,34 @@ func (u UnsupportedDecoder) Decode(data []byte) (interface{}, error) { | |||
|
|
|||
| var _ Decoder = (*UnsupportedDecoder)(nil) | |||
|
|
|||
| type ACLIDDecoder struct{} | |||
There was a problem hiding this comment.
exported type ACLIDDecoder should have comment or be unexported
|
Looks pretty good from an @elastic/stack-monitoring perspective. Two more Stack Monitoring PRs were merged into |
ruflin
approved these changes
Apr 4, 2019
|
I will do another backport tomorrow. This one only took a little longer due to changelog conflicts and me needing to cleanup changelog in different branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Didn't merge master last friday, due to conflicts on changelog and outstanding changelog updates in master.
No major issues. Just had to run
make updatefor version+Notice file updates.PR MUST BE MERGED, DO USE "Create a merge commit" OPTION!