Merge gz-sim7 ➡️ main #2011
Closed
Merge gz-sim7 ➡️ main #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org>
# 🦟 Bug fix Supercedes gazebosim#1697. Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created. Fixes #<NUMBER> ## Summary Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils. ## Before  ## After  ## Notes: Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes? Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
…tics-gazebosim Update examples to use gazebosim.org
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…sim#1758) Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
…1760) Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com> Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
In aboutDialog (line 178), the binding loop was created because the height of aboutDialog wasn't set. It was dependent on the height of its child (aboutMessage). But aboutMessage had anchor.fill : parent set which binds its height to the height of its parent. Similar reasoning applies to fileSaveFailure. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Since the ign->gz rename, two canonical Fuel servers ( fuel.ignitionrobotics.org and fuel.gazebosim.org) were being queries by ResourceSpawner. This PR removes the duplication. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…ivity (gazebosim#1799) Closes gazebosim#1027 Adds spin box that lets users sets the view controller sensitivity. The limits of the spin box are: [0.01, 10.0] with a step size of 0.1. Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Added PI based example controller for speed, pitch and yaw for LRAUVs. Signed-off-by: Aditya <aditya050995@gmail.com>
Often when sensing we may be interested in vector quantities. This PR extends the environmental_sensor to support vector quantities. Some additional work was required handle transformations. In particular if the data is something like Ocean Currents or Wind then the data has to be transformed to the robot's local coordinate frame and the robot's velocity also has to be accounted for. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
The dartsim component of gz-physics is currently not built on CI, so these tests should be disabled. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…zebosim#1839) * Adds support for Hydrodynamic Current This PR adds support for looking up hydrodynamic currents from a data file via the new Environment component. This allows users to vary currents throughout the water column. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Codecheck Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * more style Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Address PR Feedback Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Fix a few more outstanding issues. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Address second pass Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Final touches. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * Retrigger CI Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> * style Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org> Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
This adds the ISystemConfigureParameters interface, which allows systems to declare parameters. This uses a transport::parameters::ParametersRegistry and creates services for listing, getting, and setting parameters. Based on gazebosim/gz-transport#305. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org> Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Fix for handling Ackermann wheel steering angle bug where wheel always points same direction when linVel is zero and abs(angVel) > 0.001. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
…azebosim#1938) This PR optimizes the threading and render updates in the sensors system by: * reducing the scope of the renderMutex lock in Sensors::Update function * changing a few bool variables to atomic, also to reduce the need to lock mutexes * performing scene tree updates only when necessary Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
…sim#1929) --------- Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
Not all of the needed include paths are exported with the gz-sim target, so including the gz/sim.hh header doesn't work easily. This test fails to build and illustrates the problem. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Matthew LeMay <mplemay@users.noreply.github.com>
Forward port 6 to 7
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Updated SdfEntityCreator to create projector entities Updated rendering component to load and create projector objects in the scene Updated scene broadcaster to publish scene info projectors Added conversion function for serializing / deserializing sdf::Projector to / from msgs::Projector Signed-off-by: Ian Chen <ichen@openrobotics.org>
…1996) Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
This was referenced Jun 16, 2023
Merged
Merged
nkoenig
reviewed
Jun 21, 2023
| @@ -599,10 +609,6 @@ See https://github.com/gazebosim/gz-sim/issues/168 for more info." | |||
| options['wait_gui'], options['render_engine_gui'], | |||
| options['render_engine_gui_api_backend']) | |||
| end | |||
| rescue | |||
There was a problem hiding this comment.
Should this rescue be removed?
nkoenig
reviewed
Jun 21, 2023
There was a problem hiding this comment.
I'm not sure of the changes to this file.
Harmonic reference: #1933
|
FYI: I have an alternate in #2023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
gz-sim7➡️mainBranch comparison: main...gz-sim7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)