Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge apache 51bd34 #56

Merged
merged 41 commits into from
Aug 16, 2019
Merged

Merge apache 51bd34 #56

merged 41 commits into from
Aug 16, 2019

Conversation

DiggidyDave
Copy link

bring to latest from apache master

villebro and others added 30 commits August 5, 2019 17:08
* Black

* Bump sqlparse to 0.3.0

* Convert str.format() to f-string
Old FAB API had no limits by default, this will keep this behaviour
but only for this endpoint
* starting

* fix: upgrade chart error

* fix: address comments

* fix: package lock

* fix: bump typescript version
* [init] Setting up cache before registering blueprints

* Update __init__.py
* Fix pandas 0.24 DateOffset bug

* Add try-catch for DateOffsets that don't support normalize
* Updated to fix the broken blueprints link

The current link is http://flask.pocoo.org/docs/0.12/blueprints/ which redirects to a non-existent page. The new link is https://flask.palletsprojects.com/en/1.1.x/tutorial/views/.

* Link to the current Flask version(1.0.x)
* Setup FOSSA as part of CI

* Add comments and links to FOSSA docs on script
* [database] Fix, Removes the limit for the page size, Bump FAB to 2.1.8

Old FAB API had no limits by default, this will keep this behaviour
but only for this endpoint

* [sqllab] Add test for database API

* [sqllab] Add test for database API

* [sqllab] Include page zero on request

* [sqllab] Fix, Black and requirements

* [sqllab] Make database API return unlimited results

* [sqllab] just a test

* [sqllab] Bump FAB to 2.1.9

* [sqllab] Remove unused import
* Local config no longer fails to import silently

* fix types, use f-strings

* fix unhelpful pylint import error

* tweaked comment
* allow preconfigured event logger instance; deprecate specifying class

* add func docs and simplify conditions

* modify docs to reflect EVENT_LOGGER cfg change

* commit black formatting fixes and license header

* add type checking, fix other pre-commit failues

* remove superfluous/wordy condition

* fix flake8 failure

* fix new black failure

* dedent warning msg; use f-strings
… Results) (apache#8003)

* Added better display of NULL values in FilterableTable (Reults table as in SQL Lab results) and changed sorting order so that NULL values always come last

* fixed syntax according to elint recommendations

* changed code style and logic in getContentCell according to @etr2460 code review

* remvoved 'null-cell' class and replaced it with 'text-muted' as per @mistercrunch review
…ache#7929)

This bug was introduced by apache#7102

Using `position:absolute` on body gives `document.documentElement` a height of 0 which propagates to `clientHeight` on Firefox. This leads to a wrong calculation of the tooltip position in NVD3.

The solution proposed here is to use `min-height: 100vh` instead of the current technique for stretching the body element to the full window height, thus keeping body and html together.
…apache#6824 (apache#8013)

Issue: When Superset is running behind a reverse proxy and the dashboard page is requested with HTTPS protocol, the frontend can't retrieve the favorite status of the dashboard and, instead, displays the following toast message: 'There was an issue fetching the favorite status of this dashboard.'

Cause: While the API exposes the /favestar/Dashboard/{id}/count/ endpoint, the frontend executes an API call to /favestar/Dashboard/{id}/count, which leads to a redirect to an endpoint with HTTP protocol

Fix: Call the correct endpoint
…maps (apache#7951)

* Legend formatting for Arc, Polygon and Scatter

* fix typo

* refactor from d3-format to superset-ui
…8032)

* use set instead of sorted to check equality of lists

* run black
Grace Guo and others added 11 commits August 13, 2019 13:49
ref: https://travis-ci.org/mistercrunch/superset/jobs/571524160
```
  1) Dashboard top-level controls should allow dashboard level force refresh:
     CypressError: Timed out retrying: expected '<li>' to have class 'disabled'
      at Object.cypressErr (http://localhost:8081/__cypress/runner/cypress_runner.js:65283:11)
      at Object.throwErr (http://localhost:8081/__cypress/runner/cypress_runner.js:65248:18)
      at Object.throwErrByPath (http://localhost:8081/__cypress/runner/cypress_runner.js:65275:17)
      at retry (http://localhost:8081/__cypress/runner/cypress_runner.js:58816:16)
      at http://localhost:8081/__cypress/runner/cypress_runner.js:50924:18
      at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:127195:23)
      at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:125213:31)
      at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:125270:18)
      at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:125315:10)
      at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:125390:18)
      at Async._drainQueue (http://localhost:8081/__cypress/runner/cypress_runner.js:122119:16)
      at Async._drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:122129:10)
      at Async.drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:122003:14)
      at <anonymous>
```
…e#8025)

* Fix deck_polygon bug and update examples chart

* Change js elevation to native ad-hoc metric

* Move scale from metric to native multiplier

* Remove redundant js_columns and change color scheme
* fix: datasource save raises React error

* add test
* Add feature flag for Presto expand data

* Fix unit tests

* Fix black

* Revert temporary file change
* [sql lab] persist tables list in localStorage

* persist ediotor panel size setting
@DiggidyDave
Copy link
Author

@betodealmeida

@betodealmeida
Copy link

+1, will merge as soon as tests pass.

@DiggidyDave DiggidyDave merged commit 2a187b8 into lyft-master Aug 16, 2019
@DiggidyDave DiggidyDave deleted the merge_apache_51bd34 branch August 19, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.