Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for IntersectionObserver.observe() #6898

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Add an example for IntersectionObserver.observe() #6898

merged 2 commits into from
Jul 16, 2021

Conversation

takeaways
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)
I wanted to find some example here but i couldn't,
so I tried to add some example code

Issue number (if there is an associated issue)

Anything else that could help us review it

@takeaways takeaways requested a review from a team as a code owner July 14, 2021 15:40
@takeaways takeaways requested review from jpmedley and removed request for a team July 14, 2021 15:40
@wbamberg wbamberg changed the title Update index.html Add an example for IntersectionObserver.observe() Jul 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2021 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/IntersectionObserver/observe
Title: IntersectionObserver.observe()
on GitHub

No new external URLs

(this comment was updated 2021-07-16 14:07:43.223383)

@wbamberg
Copy link
Collaborator

Thanks for this PR! It looks like your editor is reformatting the content, could you please not do this? It makes it much harder to review the change you've made.

wbamberg
wbamberg requested changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example looks great to me. If you would revert the other formatting changes in this file I'll merge it.

@takeaways
Copy link
Contributor Author

This example looks great to me. If you would revert the other formatting changes in this file I'll merge it.

@wbamberg I followed your guide, Thank You.

wbamberg
wbamberg approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @takeaways !

@wbamberg wbamberg merged commit 0e14524 into mdn:main Jul 16, 2021
@takeaways takeaways mentioned this pull request Jul 16, 2021
Merged
wbamberg added a commit to jadjoubran/content that referenced this pull request Jul 16, 2021
@wbamberg
Merge remote-tracking branch 'upstream/main' into patch-7
81dc3c5 
* upstream/main: (36 commits)
  unbreak redirects from archived content (mdn#6979)
  Add an example for IntersectionObserver.observe() (mdn#6898)
  chore(deps): bump @mdn/yari from 0.4.602 to 0.4.605 (mdn#6975)
  Document that FinalizationRegistry's callback is not optional (mdn#6963)
  Removes see compat table and fix heading flaw (mdn#6964)
  Update BCD paths for console (api.Console.* -> api.console.*) (mdn#6969)
  Fold XREnvironmentBlendMode into XRSession.environmentBlendMode (mdn#6967)
  Document XRSession.interactionMode (mdn#6961)
  Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard (mdn#6960)
  added clarity (mdn#6942)
  FF91: DateTimeFormat timeZoneName options (mdn#6853)
  Fix typo: frequenies -> frequencies (mdn#6958)
  Fix code formatting in JS “new operator” doc (mdn#6954)
  improved mechanics (mdn#6940)
  fixed mechanics (mdn#6947)
  fixed punctuation, added clarity (mdn#6949)
  Fix taller interactive examples (mdn#6950)
  HTMLDialogElement: Add the 'cancel` event to the event list (mdn#6939)
  Remove window. and similar from WindowOrWorkerGlobalScope docs (mdn#6938)
  Remove notes about deep parameters (mdn#6934)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takeaways @wbamberg