Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix taller interactive examples #6950

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Fix taller interactive examples #6950

merged 1 commit into from
Jul 15, 2021

Conversation

wbamberg
Copy link
Collaborator

I noticed that a couple of pages include interactive examples that are longer, but don't give the "taller" argument in the EmbedInteractiveExample macro, which means the iframe they get isn't big enough.

https://developer.mozilla.org/en-us/docs/web/javascript/reference/global_objects/intl/listformat/listformat
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice

This PR fixes that for those two pages.

@wbamberg wbamberg requested a review from a team as a code owner July 15, 2021 22:48
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team July 15, 2021 22:48
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice
Title: Array.prototype.slice()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/ListFormat/ListFormat
Title: Intl.ListFormat() constructor
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 5c3e430 into mdn:main Jul 15, 2021
wbamberg added a commit to jadjoubran/content that referenced this pull request Jul 16, 2021
@wbamberg
Merge remote-tracking branch 'upstream/main' into patch-7
81dc3c5 
* upstream/main: (36 commits)
  unbreak redirects from archived content (mdn#6979)
  Add an example for IntersectionObserver.observe() (mdn#6898)
  chore(deps): bump @mdn/yari from 0.4.602 to 0.4.605 (mdn#6975)
  Document that FinalizationRegistry's callback is not optional (mdn#6963)
  Removes see compat table and fix heading flaw (mdn#6964)
  Update BCD paths for console (api.Console.* -> api.console.*) (mdn#6969)
  Fold XREnvironmentBlendMode into XRSession.environmentBlendMode (mdn#6967)
  Document XRSession.interactionMode (mdn#6961)
  Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard (mdn#6960)
  added clarity (mdn#6942)
  FF91: DateTimeFormat timeZoneName options (mdn#6853)
  Fix typo: frequenies -> frequencies (mdn#6958)
  Fix code formatting in JS “new operator” doc (mdn#6954)
  improved mechanics (mdn#6940)
  fixed mechanics (mdn#6947)
  fixed punctuation, added clarity (mdn#6949)
  Fix taller interactive examples (mdn#6950)
  HTMLDialogElement: Add the 'cancel` event to the event list (mdn#6939)
  Remove window. and similar from WindowOrWorkerGlobalScope docs (mdn#6938)
  Remove notes about deep parameters (mdn#6934)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
@wbamberg wbamberg deleted the fix-js-tall-examples branch April 5, 2023 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @sideshowbarker