Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard #6960

Merged

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented Jul 16, 2021

w3c/payment-handler@20a0ca9 (w3c/payment-handler#393) dropped PaymentRequestEvent.prototype.instrumentKey from the Payment Handler spec. Related BCD change: mdn/browser-compat-data#11549.

w3c/payment-handler@20a0ca9
(w3c/payment-handler#393) dropped
PaymentRequestEvent.prototype.instrumentKey from the
Payment Handler spec.
@sideshowbarker sideshowbarker requested a review from a team as a code owner July 16, 2021 07:19
@sideshowbarker sideshowbarker requested a review from teoli2003 July 16, 2021 07:19
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/PaymentRequestEvent/instrumentKey
Title: PaymentRequestEvent.instrumentKey
on GitHub

No new external URLs

sideshowbarker added a commit to sideshowbarker/browser-compat-data that referenced this pull request Jul 16, 2021
w3c/payment-handler@20a0ca9 (w3c/payment-handler#393) dropped PaymentRequestEvent.prototype.instrumentKey from the Payment Handler spec.

So, this change marks it deprecated and non-standard, and drops its spec_url.

Related MDN change: mdn/content#6960
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is fine and I agree to remove the link to undocumented deprecated feature here. (It can be reverted if needed but we don't want to encourage to get it written)

@teoli2003 teoli2003 merged commit 0143e89 into main Jul 16, 2021
@teoli2003 teoli2003 deleted the sideshowbarker/PaymentRequestEvent/instrumentKey-gone branch July 16, 2021 08:25
foolip pushed a commit to mdn/browser-compat-data that referenced this pull request Jul 16, 2021
…11549)

w3c/payment-handler@20a0ca9 (w3c/payment-handler#393) dropped PaymentRequestEvent.prototype.instrumentKey from the Payment Handler spec.

So, this change marks it deprecated and non-standard, and drops its spec_url.

Related MDN change: mdn/content#6960
wbamberg added a commit to jadjoubran/content that referenced this pull request Jul 16, 2021
* upstream/main: (36 commits)
  unbreak redirects from archived content (mdn#6979)
  Add an example for IntersectionObserver.observe() (mdn#6898)
  chore(deps): bump @mdn/yari from 0.4.602 to 0.4.605 (mdn#6975)
  Document that FinalizationRegistry's callback is not optional (mdn#6963)
  Removes see compat table and fix heading flaw (mdn#6964)
  Update BCD paths for console (api.Console.* -> api.console.*) (mdn#6969)
  Fold XREnvironmentBlendMode into XRSession.environmentBlendMode (mdn#6967)
  Document XRSession.interactionMode (mdn#6961)
  Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard (mdn#6960)
  added clarity (mdn#6942)
  FF91: DateTimeFormat timeZoneName options (mdn#6853)
  Fix typo: frequenies -> frequencies (mdn#6958)
  Fix code formatting in JS “new operator” doc (mdn#6954)
  improved mechanics (mdn#6940)
  fixed mechanics (mdn#6947)
  fixed punctuation, added clarity (mdn#6949)
  Fix taller interactive examples (mdn#6950)
  HTMLDialogElement: Add the 'cancel` event to the event list (mdn#6939)
  Remove window. and similar from WindowOrWorkerGlobalScope docs (mdn#6938)
  Remove notes about deep parameters (mdn#6934)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants