Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbreak redirects from archived content #6979

Merged
merged 1 commit into from
Jul 16, 2021
Merged

unbreak redirects from archived content #6979

merged 1 commit into from
Jul 16, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jul 16, 2021

@peterbe peterbe requested a review from a team as a code owner July 16, 2021 17:59
@peterbe peterbe requested review from Rumyra and removed request for a team July 16, 2021 17:59
@peterbe peterbe merged commit 898b9a7 into mdn:main Jul 16, 2021
@peterbe peterbe mentioned this pull request Jul 16, 2021
Merged
@SphinxKnight
Copy link
Member

@peterbe what is the rationale/underlying explanation for this change? I concur it's OK for en-US (yarn tool validate-redirects en-us --strict) but I still get a local failure for all locales (yarn tool validate-redirects --strict)
I'll submit a PR on translated-content.

@peterbe peterbe mentioned this pull request Jul 16, 2021
Merged
@peterbe peterbe deleted the unbreak-redirects-from-archived-content branch July 16, 2021 19:03
@peterbe
Copy link
Contributor Author

peterbe commented Jul 16, 2021

@peterbe what is the rationale/underlying explanation for this change? I concur it's OK for en-US (yarn tool validate-redirects en-us --strict) but I still get a local failure for all locales (yarn tool validate-redirects --strict)
I'll submit a PR on translated-content.

In short; see mdn/translated-content#1573

Basically, we used to host and "care for" archived content. As of yesterday we stopped hosting it and we wiped the file content/archived.txt empty. Turns out, lots and lots of translated content redirects relied on these. Still :(
What happened was for example:

/fr/docs/API_d'accès_au_contenu_de_flux /fr/docs/Feed_content_access_API

(note the careful space between URLA and URLB)
The "URLB" is what we call the "final destination" which, used to be part of content/archived.txt but it no longer is. So it broke the strict redirect validation.

wbamberg added a commit to jadjoubran/content that referenced this pull request Jul 16, 2021
@wbamberg
Merge remote-tracking branch 'upstream/main' into patch-7
81dc3c5 
* upstream/main: (36 commits)
  unbreak redirects from archived content (mdn#6979)
  Add an example for IntersectionObserver.observe() (mdn#6898)
  chore(deps): bump @mdn/yari from 0.4.602 to 0.4.605 (mdn#6975)
  Document that FinalizationRegistry's callback is not optional (mdn#6963)
  Removes see compat table and fix heading flaw (mdn#6964)
  Update BCD paths for console (api.Console.* -> api.console.*) (mdn#6969)
  Fold XREnvironmentBlendMode into XRSession.environmentBlendMode (mdn#6967)
  Document XRSession.interactionMode (mdn#6961)
  Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard (mdn#6960)
  added clarity (mdn#6942)
  FF91: DateTimeFormat timeZoneName options (mdn#6853)
  Fix typo: frequenies -> frequencies (mdn#6958)
  Fix code formatting in JS “new operator” doc (mdn#6954)
  improved mechanics (mdn#6940)
  fixed mechanics (mdn#6947)
  fixed punctuation, added clarity (mdn#6949)
  Fix taller interactive examples (mdn#6950)
  HTMLDialogElement: Add the 'cancel` event to the event list (mdn#6939)
  Remove window. and similar from WindowOrWorkerGlobalScope docs (mdn#6938)
  Remove notes about deep parameters (mdn#6934)
  ...
@C-Masuda C-Masuda mentioned this pull request Jul 19, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@peterbe @SphinxKnight