Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved mechanics #6940

Merged
merged 1 commit into from
Jul 15, 2021
Merged

improved mechanics #6940

merged 1 commit into from
Jul 15, 2021

Conversation

bound-variable
Copy link
Contributor

  1. The MDN style guide calls for using the Oxford comma
  2. The original opening consists of two independent clauses joined by a comma. This is a comma splice (or comma fault)
  3. I tried to add some clarity, for example, by emphasizing the idea of SOME

@bound-variable
improved mechanics
5b342e9 
1) The MDN style guide calls for using the Oxford comma
2) The original opening consists of two independent clauses joined by a comma. This is a comma splice (or comma fault)
3) I tried to add some clarity, for example, by emphasizing the idea of SOME
@bound-variable bound-variable requested review from a team and rachelandrew and removed request for a team July 15, 2021 20:02
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Learn/CSS/Building_blocks/The_box_model
Title: The box model
on GitHub

No new external URLs

Ryuno-Ki
Ryuno-Ki reviewed Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like, that this moves in the right direction. Can we try to avoid educational language?

files/en-us/learn/css/building_blocks/the_box_model/index.html
@@ -98,7 +98,7 @@ <h2 id="Examples_of_different_display_types">Examples of different display types

<h2 id="What_is_the_CSS_box_model">What is the CSS box model?</h2>

<p>The full CSS box model applies to block boxes, inline boxes only use some of the behavior defined in the box model. The model defines how the different parts of a box — margin, border, padding, and content — work together to create a box that you can see on the page. To add some additional complexity, there is a standard and an alternate box model.</p>
<p>The CSS box model as a whole applies to block boxes. Inline boxes use just <em>some</em> of the behavior defined in the box model. The model defines how the different parts of a box — margin, border, padding, and content — work together to create a box that you can see on a page. To add some additional complexity, there is a standard and an alternate box model.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good advice, to find an alternative to „just”:
https://css-tricks.com/words-avoid-educational-writing/#6-just

Copy link
Contributor Author

@bound-variable bound-variable Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference you gave isn't using the same word with the same meaning.

I used it to mean, "No more than; only, merely; barely."

Here are the example sentences from the OED:

image

None of these cited sentences are educational. In fact, I've been working in academia for over a decade and I have never heard of an educational "just". I will have to look that up. As far as I know, it's just an ordinary word.

hamishwillee
hamishwillee approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging as it is both a slight improvement and technically correct.

@hamishwillee hamishwillee merged commit 1f4efe1 into mdn:main Jul 15, 2021
wbamberg added a commit to jadjoubran/content that referenced this pull request Jul 16, 2021
@wbamberg
Merge remote-tracking branch 'upstream/main' into patch-7
81dc3c5 
* upstream/main: (36 commits)
  unbreak redirects from archived content (mdn#6979)
  Add an example for IntersectionObserver.observe() (mdn#6898)
  chore(deps): bump @mdn/yari from 0.4.602 to 0.4.605 (mdn#6975)
  Document that FinalizationRegistry's callback is not optional (mdn#6963)
  Removes see compat table and fix heading flaw (mdn#6964)
  Update BCD paths for console (api.Console.* -> api.console.*) (mdn#6969)
  Fold XREnvironmentBlendMode into XRSession.environmentBlendMode (mdn#6967)
  Document XRSession.interactionMode (mdn#6961)
  Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard (mdn#6960)
  added clarity (mdn#6942)
  FF91: DateTimeFormat timeZoneName options (mdn#6853)
  Fix typo: frequenies -> frequencies (mdn#6958)
  Fix code formatting in JS “new operator” doc (mdn#6954)
  improved mechanics (mdn#6940)
  fixed mechanics (mdn#6947)
  fixed punctuation, added clarity (mdn#6949)
  Fix taller interactive examples (mdn#6950)
  HTMLDialogElement: Add the 'cancel` event to the event list (mdn#6939)
  Remove window. and similar from WindowOrWorkerGlobalScope docs (mdn#6938)
  Remove notes about deep parameters (mdn#6934)
  ...
@bound-variable bound-variable deleted the patch-36 branch July 19, 2021 21:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ryuno-Ki Ryuno-Ki Ryuno-Ki left review comments

@hamishwillee hamishwillee hamishwillee approved these changes

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bound-variable @Ryuno-Ki @hamishwillee