Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLDialogElement: Add the 'cancel` event to the event list #6939

Merged
merged 1 commit into from
Jul 15, 2021
Merged

HTMLDialogElement: Add the 'cancel` event to the event list #6939

merged 1 commit into from
Jul 15, 2021

Conversation

mnoorenberghe
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

Missing cancel event to go alongside close

@mnoorenberghe mnoorenberghe requested a review from a team as a code owner July 15, 2021 19:37
@mnoorenberghe mnoorenberghe requested review from jpmedley and removed request for a team July 15, 2021 19:37
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/HTMLDialogElement
Title: HTMLDialogElement
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/HTMLDialogElement
Title: HTMLDialogElement
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 1a69e33 into mdn:main Jul 15, 2021
wbamberg added a commit to jadjoubran/content that referenced this pull request Jul 16, 2021
@wbamberg
Merge remote-tracking branch 'upstream/main' into patch-7
81dc3c5 
* upstream/main: (36 commits)
  unbreak redirects from archived content (mdn#6979)
  Add an example for IntersectionObserver.observe() (mdn#6898)
  chore(deps): bump @mdn/yari from 0.4.602 to 0.4.605 (mdn#6975)
  Document that FinalizationRegistry's callback is not optional (mdn#6963)
  Removes see compat table and fix heading flaw (mdn#6964)
  Update BCD paths for console (api.Console.* -> api.console.*) (mdn#6969)
  Fold XREnvironmentBlendMode into XRSession.environmentBlendMode (mdn#6967)
  Document XRSession.interactionMode (mdn#6961)
  Mark PaymentRequestEvent.p.instrumentKey deprecated and non-standard (mdn#6960)
  added clarity (mdn#6942)
  FF91: DateTimeFormat timeZoneName options (mdn#6853)
  Fix typo: frequenies -> frequencies (mdn#6958)
  Fix code formatting in JS “new operator” doc (mdn#6954)
  improved mechanics (mdn#6940)
  fixed mechanics (mdn#6947)
  fixed punctuation, added clarity (mdn#6949)
  Fix taller interactive examples (mdn#6950)
  HTMLDialogElement: Add the 'cancel` event to the event list (mdn#6939)
  Remove window. and similar from WindowOrWorkerGlobalScope docs (mdn#6938)
  Remove notes about deep parameters (mdn#6934)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnoorenberghe @sideshowbarker