Release: 13.9.2 #10218

syuilo · 2023-03-05T11:32:19Z

No description provided.

…stantというエラーが出る Fix #10187

…in) (#10190) * Revert "Revert "fix(server): DriveFile related N+1 query when call note packMany (#10133)"" This reverts commit a7c82ee. * packManyByIdsMap: 存在チェックをしてなかったものは null を入れるように * Note.packMany で reply とか renote がもうあったらそのファイルも引く * テストを書く * fix test * fix test * fix test * fix test

* enhance(server): downloadUrlでContent-Dispositionからファイル名を取得 Resolve #10036 Resolve #4750 * untitled * オブジェクトストレージのContent-Dispositionのファイル名の拡張子をContent-Typeに添ったものにする * ✌️ * tiff * fix filename * add test * /files/でもContent-Disposition * comment * fix test

…ge indicate this (#10191) Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* enhance(server): downloadUrlでContent-Dispositionからファイル名を取得 Resolve #10036 Resolve #4750 * untitled * オブジェクトストレージのContent-Dispositionのファイル名の拡張子をContent-Typeに添ったものにする * ✌️ * tiff * fix filename * add test * /files/でもContent-Disposition * enhance(server): メディアプロキシでico,bmpを読めるように Fix #10120 * comment * fix test --------- Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* docker: build assets on native arch * 消しすぎた

Related to #10201

Fix #10203

… develop

#10202

Resolve #10200

* New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Lao) * New translations ja-JP.yml (Thai) * New translations ja-JP.yml (Lao) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Thai) * New translations ja-JP.yml (German) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Thai) * New translations ja-JP.yml (Lao) * New translations ja-JP.yml (Lao) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Chinese Traditional)

#10212) see: https://forum.misskey.io/d/112-misskey-forum-to-end-service-at-the-end-of-this-month

* New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Japanese, Kansai)

codecov · 2023-03-05T11:43:05Z

Codecov Report

Merging #10218 (5ccbeda) into master (7e87005) will increase coverage by 0.09%.
The diff coverage is 64.28%.

❗ Current head 5ccbeda differs from pull request most recent head 31f9ea3. Consider uploading reports for the commit 31f9ea3 to get more accurate results

@@            Coverage Diff             @@
##           master   #10218      +/-   ##
==========================================
+ Coverage   69.14%   69.23%   +0.09%     
==========================================
  Files         706      707       +1     
  Lines       65312    65407      +95     
  Branches     5181     5214      +33     
==========================================
+ Hits        45159    45286     +127     
+ Misses      20153    20121      -32

Impacted Files	Coverage Δ
...kend/src/core/entities/GalleryPostEntityService.ts	`51.66% <0.00%> (-0.88%)`	⬇️
packages/backend/src/server/FileServerService.ts	`19.05% <5.71%> (-0.51%)`	⬇️
packages/backend/src/core/DriveService.ts	`57.08% <52.00%> (-0.06%)`	⬇️
...ges/backend/src/core/entities/UserEntityService.ts	`91.60% <57.14%> (ø)`
packages/backend/src/core/DownloadService.ts	`71.62% <73.68%> (+0.08%)`	⬆️
...ackend/src/core/entities/DriveFileEntityService.ts	`71.18% <100.00%> (+2.24%)`	⬆️
...ges/backend/src/core/entities/NoteEntityService.ts	`83.25% <100.00%> (+0.88%)`	⬆️
packages/backend/src/misc/correct-filename.ts	`100.00% <100.00%> (ø)`
packages/backend/src/misc/is-mime-image.ts	`100.00% <100.00%> (ø)`
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rinsuki · 2023-03-05T11:44:19Z

ふと思ったけど identicon のキー変えると生成される画像変わるのでちょっと微妙かも

rinsuki · 2023-03-05T11:44:39Z

(せめて CHANGELOG にはその旨但し書きしておいたほうがよさそう)

Khsmty · 2023-03-05T11:46:22Z

新しく追加されたチャンネルの投稿ボタンから投稿すると、リクエストに channelId が乗らずに普通の投稿になってしまいます

syuilo · 2023-03-05T11:49:43Z

新しく追加されたチャンネルの投稿ボタンから投稿すると、リクエストに channelId が乗らずに普通の投稿になってしまいます

👍🏻👍🏻👍🏻

直しました

tamaina · 2023-03-05T11:55:11Z

しゅいろが寝る直前にリリースを切る習慣をやめて欲しいので個人的には明日の朝Approveしたい所存

* fix(frontend): ユーザーページのバッジ表示を適切に折り返すように * Update CHANGELOG.md

acid-chicken · 2023-03-05T13:02:02Z

packages/frontend/src/components/MkPostForm.vue

+				text.includes('https://youtu.be/Efrlqw8ytg4'.toLowerCase()) ||
+				text.includes('https://www.youtube.com/watch?v=Efrlqw8ytg4'.toLowerCase()) ||
+				text.includes('https://m.youtube.com/watch?v=Efrlqw8ytg4'.toLowerCase()) ||
+				text.includes('https://youtu.be/XVCwzwxdHuA'.toLowerCase()) ||
+				text.includes('https://www.youtube.com/watch?v=XVCwzwxdHuA'.toLowerCase()) ||
+				text.includes('https://m.youtube.com/watch?v=XVCwzwxdHuA'.toLowerCase())


toLowerCase は嘘そう

なくても良さそうではある

acid-chicken · 2023-03-05T13:11:34Z

pnpm-lock.yaml

@@ -6766,14 +6789,16 @@ packages:
      readable-stream: 2.3.7
    dev: false

-  /follow-redirects/1.15.2:
+  /follow-redirects/1.15.2_debug@4.3.4:


なんだろうこれ

私の環境でpnpm addとかすると勝手につく

* New translations ja-JP.yml (Thai) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (Italian)

tamaina · 2023-03-06T02:09:14Z

Approveしたけどビルドが…

ci skipしたほうが良かったかもしれない

… develop

tamaina · 2023-03-06T02:37:57Z

Dockerビルド、激早になってた

syuilo · 2023-03-06T02:54:16Z

🙏🏻

syuilo and others added 30 commits March 4, 2023 10:17

enhance(client): add share button to clip and channel page

aee7ed9

Resolve #10183

enhance(client): improve channel ui

dcd4d80

fix(client): Viteで This assignment will throw because "role" is a con…

b303d65

…stantというエラーが出る Fix #10187

enhance(client): improve channel ui

e4fc9ea

chore(client): tweak default value of numberOfPageCache

3f50724

Update CHANGELOG.md

320c2bf

🎨

1711ae7

chore: Replace tab with space (#10185)

6dd9374

Fix: If mail delivery is disabled on the server, make the settings pa…

72b3154

…ge indicate this (#10191) Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

docker: build assets on native arch (#10080)

ccdac0c

* docker: build assets on native arch * 消しすぎた

Dev Container周り

c547122

Related to #10201

fix: pnpm が command not found になるのを修正

68ab056

fix(client): ロールの権限で「一般ユーザー」のロールがいきなり設定できない問題を修正

5c88c17

Fix #10203

Merge branch 'develop' of https://github.com/misskey-dev/misskey into…

f6c6ffa

… develop

fix(client): PWAでlangがnullになる現象の応急処置

8e5e6f9

#10202

tweak of 8e5e6f9

ba2630c

enhance(server): make identicon same between local and remote

b9a3b2c

Resolve #10200

fix of b9a3b2c

ae7d17d

Update about-misskey.vue

85d9313

fix: macOS上でDevContainerが動作しない問題を修正

d53a177

enhance(client): tweak signup form

7b8e1e6

change: deprecate link to Misskey Forum in favor of GitHub Discussions (

ad43011

#10212) see: https://forum.misskey.io/d/112-misskey-forum-to-end-service-at-the-end-of-this-month

fix: pnpm dev時にファイルが空ならバックエンドの起動を待つように (#10210)

8e8c2b4

fix: Jestの自動実行を無効に

f5b63d8

New Crowdin updates (#10214)

b4835c7

* New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Japanese, Kansai)

enhance(client): tweak brain diver detection

aa01ba7

github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR 🧪Test labels Mar 5, 2023

[ci skip] Update CHANGELOG.md

517a7f9

[ci skip] fix(client): fix post button of channel

9f73c23

[ci skip] 🎨

353b1cc

arrow2nd and others added 3 commits March 5, 2023 21:59

fix(frontend): ユーザーページのバッジ表示を適切に折り返すように (#10222)

8c9c89a

* fix(frontend): ユーザーページのバッジ表示を適切に折り返すように * Update CHANGELOG.md

fix(docker): cannot build docker image on some environments (#10220)

b1c173e

Update CHANGELOG.md

8243985

acid-chicken reviewed Mar 5, 2023

View reviewed changes

tamaina and others added 5 commits March 6, 2023 01:17

fix correctFilename extが.から始まる場合も考慮する

87d0f56

update CHANGELOG.md

6bb1149

New Crowdin updates (#10223)

b719f6c

* New translations ja-JP.yml (Thai) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (Italian)

update CHANGELOG.md

6778111

update CHANGELOG.md

7852815

tamaina approved these changes Mar 6, 2023

View reviewed changes

syuilo added 2 commits March 6, 2023 02:12

fix(client): みつけるのロール一覧でコンディショナルロールが含まれるのを修正

f20abb4

Merge branch 'develop' of https://github.com/misskey-dev/misskey into…

5ccbeda

… develop

tamaina approved these changes Mar 6, 2023

View reviewed changes

[ci skip] chore(client): showNoteActionsOnlyHover変更時にリロードダイアログを出すように

31f9ea3

syuilo merged commit ae517a9 into master Mar 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release: 13.9.2 #10218

Release: 13.9.2 #10218

syuilo commented Mar 5, 2023

codecov bot commented Mar 5, 2023 •

edited

Loading

rinsuki commented Mar 5, 2023

rinsuki commented Mar 5, 2023

Khsmty commented Mar 5, 2023

syuilo commented Mar 5, 2023

tamaina commented Mar 5, 2023

acid-chicken Mar 5, 2023

tamaina Mar 6, 2023

acid-chicken Mar 5, 2023

tamaina Mar 6, 2023

tamaina commented Mar 6, 2023

tamaina commented Mar 6, 2023

syuilo commented Mar 6, 2023

Release: 13.9.2 #10218

Release: 13.9.2 #10218

Conversation

syuilo commented Mar 5, 2023

codecov bot commented Mar 5, 2023 • edited Loading

Codecov Report

rinsuki commented Mar 5, 2023

rinsuki commented Mar 5, 2023

Khsmty commented Mar 5, 2023

syuilo commented Mar 5, 2023

tamaina commented Mar 5, 2023

acid-chicken Mar 5, 2023

Choose a reason for hiding this comment

tamaina Mar 6, 2023

Choose a reason for hiding this comment

acid-chicken Mar 5, 2023

Choose a reason for hiding this comment

tamaina Mar 6, 2023

Choose a reason for hiding this comment

tamaina commented Mar 6, 2023

tamaina commented Mar 6, 2023

syuilo commented Mar 6, 2023

codecov bot commented Mar 5, 2023 •

edited

Loading