Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x backport] http: reduce usage of public util #26650

Closed
wants to merge 91 commits into from
Closed

[v11.x backport] http: reduce usage of public util #26650

wants to merge 91 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 14, 2019

PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

mcollina and others added 30 commits March 12, 2019 21:04
@mcollina @BridgeAR
stream: make sure 'readable' is emitted before ending the stream
4796c7c 
Fixes: nodejs#25810

PR-URL: nodejs#26059
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gengjiawen @BridgeAR
src: remove unused variable in node_http2.cc
0c4e019 
PR-URL: nodejs#26395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mcollina @BridgeAR
http: check for existance in resetHeadersTimeoutOnReqEnd
93ef1e3 
socket.parser can be undefined under unknown circumstances.
This is a fix for a bug I cannot reproduce but it is affecting
people.

Fixes: nodejs#26366

PR-URL: nodejs#26402
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nitsakh @BridgeAR
src: fix build when NODE_USE_V8_PLATFORM is not defined
44ef6b0 
PR-URL: nodejs#26380
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@joyeecheung @BridgeAR
doc: fix the example implementation of MemoryRetainer
f74d5c8 
We need to be careful not to include the size of non-pointer
fields in the parent's self size if we want to track them separately
as a different node.

Refs: https://github.com/nodejs/node/pull/26161/files#r259170771

PR-URL: nodejs#26262
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @BridgeAR
doc: edit deprecation section of Collaborator Guide
fc6023a 
Edit the last few paragraphs of the Collaborator Guide section on
deprecations.

PR-URL: nodejs#26419
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau @BridgeAR
test: relax timer check in test-report-uv-handles.js
3570c77 
The underlying JavaScript runtime may schedule tasks at its discretion
so there may be more timer handles than the one created by the test.

PR-URL: nodejs#26434
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BeniCheni @BridgeAR
lib: migrate process.binding to internalBinding
ff1958d 
Migrate various modules from using process.binding to internalBinding.

PR-URL: nodejs#24952
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@paroga @BridgeAR
crypto: add KeyObject.asymmetricKeySize
09c83d8 
Expose the size of asymetric keys of crypto key object from the
crypto module added in v11.6.0.

PR-URL: nodejs#26387
Refs: nodejs#24234
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung @BridgeAR
src: use the config binding to carry --no-browser-globals
3e6b95e 
Instead of setting it in the process object, since this is
a configure-time option. Also added a shim that can be
deprecated and removed some time later.

PR-URL: nodejs#26228
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen @BridgeAR
src: fix wrong enum reference in node.cc
b435913 
PR-URL: nodejs#26430
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@gengjiawen @BridgeAR
src: remove unused function in cares_wrap.cc
21ca939 
PR-URL: nodejs#26429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gengjiawen @BridgeAR
src: remove redundant cast in string_search.h
4ff5cfa 
PR-URL: nodejs#26426
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
tools: replace var to let/const
b3ecaaa 
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
tools: add no-var lint rule for tools directory
a8331fa 
PR-URL: nodejs#26398
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack @BridgeAR
build,win: simplify new msbuild_arg option
3dd7084 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau @BridgeAR
build: indicate that configure has done something
1351f6e 
If run without `--verbose` configure exits silently with no indication
that it has done anything. Print a message on completion to indicate
that the script has worked.

Refs: nodejs#23111

PR-URL: nodejs#26436
Refs: nodejs#23111
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
buffer: do not affect memory after target for utf16 write
7d8edec 
Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.

Fixes: nodejs#26422

PR-URL: nodejs#26432
Fixes: nodejs#26422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@nicolas-moteau @BridgeAR
doc: add missing https Agent maxCachedSessions
4b1c1dc 
PR-URL: nodejs#26433
Refs: nodejs#2228
Refs: nodejs#4252
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott @BridgeAR
doc: standardize on End-of-Life capitalization
bd7e243 
Use "End-of-Life" everywhere and not "End-of-life" or "End-Of-Life".

PR-URL: nodejs#26442
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@Trott @BridgeAR
tools: update remark-preset-lint-node to 1.5.0
aa80137 
This update includes an additional check for `End-of-life`. For
consistency, we use `End-of-Life` everywhere.

PR-URL: nodejs#26442
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@gengjiawen @BridgeAR
src: remove redundant call in inspector_io.cc
2d7b629 
PR-URL: nodejs#26427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gengjiawen @BridgeAR
src: make parameter name const reference in method TriggerNodeReport
539a9c0 
PR-URL: nodejs#26397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen @BridgeAR
http: remove unused variable in _http_server.js
5d2c522 
PR-URL: nodejs#26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau @BridgeAR
test: fix tests so they work in worker threads
24b9ae1 
Use the `cwd` option for child_process instead of `process.chdir()` to
allow tests to work with worker threads.

PR-URL: nodejs#26453
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@koh110 @BridgeAR
child_process: fire close event from stdio
8e94cb2 
PR-URL: nodejs#22892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR
test: remove usage of process.binding()
8c087d2 
Prefer `internalBinding` or other equivalents over `process.binding()`
(except in tests checking `process.binding()` itself).

PR-URL: nodejs#26304
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@tniessen @BridgeAR
crypto: simplify GetPublicOrPrivateKeyFromJs
ab1327f 
PR-URL: nodejs#26454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@cjihrig @BridgeAR
test: refactor test/report/test-report-signal.js
d1c225f 
PR-URL: nodejs#26446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack @BridgeAR
Revert "build: silence cpp lint by default"
8c90fe1 
This reverts commit 0373836.

PR-URL: nodejs#26358
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax and others added 8 commits March 13, 2019 19:13
@BridgeAR
worker: release native Worker object earlier
8cb7d4b 
Destroy the `Worker` class earlier, because we don’t need access
to it once the thread has stopped and all resources have been
cleaned up.

PR-URL: nodejs#26542
Fixes: nodejs#26535
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ZYSzys @BridgeAR
url: require encodeStr from internal/querystring
f2ebf36 
PR-URL: nodejs#26538
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung @BridgeAR
lib: import TextEncoder and TextDecoder from internal/encoding
c43e5b3 
PR-URL: nodejs#26547
Refs: nodejs#26546
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex @BridgeAR
crypto: fix EdDSA support for KeyObject
71d0a8a 
PR-URL: nodejs#26319
Fixes: nodejs#26316
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@refack @BridgeAR
test: fix syntax error in test-dns-idna2008.js when failing
f03498c 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BridgeAR
process: make Symbol.toStringTag writable
c6536b4 
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.

PR-URL: nodejs#26488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ronag @BridgeAR
http2: Http2ServerResponse.end() should always return self
348d9a6 
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
test: fix test by removing node-inspect/lib/_inspect
b581bb0 
If this file is loaded with Node.js build without ssl, it will load
'node-inspect/lib/internal/inspect_client' as well. Due to that two
deprecation warnings will be emitted instead of one and the test
fails.

It should be safe to just test all other cases and to ignore this
specific file.
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2901/pipeline

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v11.x labels Mar 14, 2019
@refack refack mentioned this pull request Mar 14, 2019
Closed
2 tasks
@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21524/

@ZYSzys @refack
http: reduce usage of public util
cd77811 
PR-URL: nodejs#26548
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

So it seems this is dependent on #24755, but I'm not sure if the specific changes here are exposed in the API, PTAL.

/CC @BridgeAR @mcollina @lpinca @joyeecheung (who reviewed #24755)

@refack
Copy link
Contributor Author

refack commented Mar 14, 2019

New CI: https://ci.nodejs.org/job/node-test-pull-request/21527/

@refack refack mentioned this pull request Mar 14, 2019
Closed
ZYSzys
ZYSzys reviewed Mar 14, 2019
View reviewed changes
lib/_http_agent.js
@@ -106,7 +105,8 @@ function Agent(options) {
});
}

util.inherits(Agent, EventEmitter);
Copy link
Member

@ZYSzys ZYSzys Mar 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #24755 was semver-major, maybe we should keep using util.inherits here and just backport the debuglog part ?

BTW, I think it's also dependent on #26468 if I'm not wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely depends on #26468 and it's also the reason why the CI fails.

I have no strong opinion about the util.inherits part. I guess someone could rely on some checks that would now fail but it is quite unlikely as well. In this case I would just follow @ZYSzys and pull these changes out.

@BridgeAR BridgeAR force-pushed the v11.x-staging branch 4 times, most recently from f95e015 to 1fa5004 Compare March 14, 2019 16:15
targos pushed a commit that referenced this pull request Mar 28, 2019
@ZYSzys @targos
http: reduce usage of public util
04441b5 
Backport-PR-URL: #26650
PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
Copy link
Member

targos commented Mar 28, 2019

Landed in 04441b5 without the util.inherits changes.

@targos targos closed this Mar 28, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
@ZYSzys @targos
http: reduce usage of public util
5a29a94 
Backport-PR-URL: #26650
PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack refack deleted the backport-26548-to-v11.x branch April 14, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@ZYSzys ZYSzys ZYSzys left review comments

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.