Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview #10173

Conversation

yves-chan
Copy link
Contributor

@yves-chan yves-chan commented Jul 16, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 16, 2020

[Staging] Swagger Validation Report

BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooktemplates/{resourceName}' removed or restructured?
Old: Microsoft.Insights/preview/2019-10-17-preview/workbookTemplates_API.json#L76:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooks' removed or restructured?
Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' removed or restructured?
Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L88:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}' removed or restructured?
Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L85:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooks' removed or restructured?
Old: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooktemplates' removed or restructured?
Old: Microsoft.Insights/preview/2019-10-17-preview/workbookTemplates_API.json#L37:5
LintDiff: 31 Errors, 2 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}'
New: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks'
New: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooktemplates/{resourceName}'
New: Microsoft.Insights/preview/2019-10-17-preview/workbookTemplates_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooktemplates'
New: Microsoft.Insights/preview/2019-10-17-preview/workbookTemplates_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks'
New: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}'
New: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks'
New: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L36
R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}'
New: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L36
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
New: Microsoft.Insights/stable/2015-05-01/workbooks_API.json#L68
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
New: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L254
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 16, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from cf8821f with merge commit ee06806. SDK Automation 13.0.17.20200619.4
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from cf8821f with merge commit ee06806. SDK Automation 13.0.17.20200619.4
    • ️✔️@azure/arm-appinsights [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
      [npmPack] created ./dist/arm-appinsights.js in 599ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-appinsights@2.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 6.0kB   esm/operations/analyticsItems.js                                   
      [npmPack] npm notice 505B    esm/models/analyticsItemsMappers.js                                
      [npmPack] npm notice 6.1kB   esm/operations/annotations.js                                      
      [npmPack] npm notice 470B    esm/models/annotationsMappers.js                                   
      [npmPack] npm notice 5.3kB   esm/operations/aPIKeys.js                                          
      [npmPack] npm notice 499B    esm/models/aPIKeysMappers.js                                       
      [npmPack] npm notice 3.0kB   esm/applicationInsightsManagementClient.js                         
      [npmPack] npm notice 2.6kB   esm/applicationInsightsManagementClientContext.js                  
      [npmPack] npm notice 213.5kB dist/arm-appinsights.js                                            
      [npmPack] npm notice 76.3kB  dist/arm-appinsights.min.js                                        
      [npmPack] npm notice 2.1kB   esm/operations/componentAvailableFeatures.js                       
      [npmPack] npm notice 552B    esm/models/componentAvailableFeaturesMappers.js                    
      [npmPack] npm notice 3.5kB   esm/operations/componentCurrentBillingFeatures.js                  
      [npmPack] npm notice 514B    esm/models/componentCurrentBillingFeaturesMappers.js               
      [npmPack] npm notice 2.1kB   esm/operations/componentFeatureCapabilities.js                     
      [npmPack] npm notice 472B    esm/models/componentFeatureCapabilitiesMappers.js                  
      [npmPack] npm notice 6.1kB   esm/operations/componentLinkedStorageAccountsOperations.js         
      [npmPack] npm notice 905B    esm/models/componentLinkedStorageAccountsOperationsMappers.js      
      [npmPack] npm notice 2.0kB   esm/operations/componentQuotaStatus.js                             
      [npmPack] npm notice 456B    esm/models/componentQuotaStatusMappers.js                          
      [npmPack] npm notice 10.9kB  esm/operations/components.js                                       
      [npmPack] npm notice 990B    esm/models/componentsMappers.js                                    
      [npmPack] npm notice 7.6kB   esm/operations/exportConfigurations.js                             
      [npmPack] npm notice 507B    esm/models/exportConfigurationsMappers.js                          
      [npmPack] npm notice 7.2kB   esm/operations/favorites.js                                        
      [npmPack] npm notice 442B    esm/models/favoritesMappers.js                                     
      [npmPack] npm notice 345B    esm/models/index.js                                                
      [npmPack] npm notice 1.0kB   esm/operations/index.js                                            
      [npmPack] npm notice 1.7kB   esm/operations/liveToken.js                                        
      [npmPack] npm notice 426B    esm/models/liveTokenMappers.js                                     
      [npmPack] npm notice 68.1kB  esm/models/mappers.js                                              
      [npmPack] npm notice 3.6kB   esm/operations/operations.js                                       
      [npmPack] npm notice 522B    esm/models/operationsMappers.js                                    
      [npmPack] npm notice 8.4kB   esm/models/parameters.js                                           
      [npmPack] npm notice 5.2kB   esm/operations/proactiveDetectionConfigurations.js                 
      [npmPack] npm notice 857B    esm/models/proactiveDetectionConfigurationsMappers.js              
      [npmPack] npm notice 1.0kB   rollup.config.js                                                   
      [npmPack] npm notice 2.0kB   esm/operations/webTestLocations.js                                 
      [npmPack] npm notice 503B    esm/models/webTestLocationsMappers.js                              
      [npmPack] npm notice 9.9kB   esm/operations/webTests.js                                         
      [npmPack] npm notice 866B    esm/models/webTestsMappers.js                                      
      [npmPack] npm notice 6.3kB   esm/operations/workbooks.js                                        
      [npmPack] npm notice 878B    esm/models/workbooksMappers.js                                     
      [npmPack] npm notice 8.0kB   esm/operations/workItemConfigurations.js                           
      [npmPack] npm notice 543B    esm/models/workItemConfigurationsMappers.js                        
      [npmPack] npm notice 1.7kB   package.json                                                       
      [npmPack] npm notice 457B    tsconfig.json                                                      
      [npmPack] npm notice 2.6kB   esm/operations/analyticsItems.d.ts.map                             
      [npmPack] npm notice 3.4kB   esm/operations/analyticsItems.js.map                               
      [npmPack] npm notice 213B    esm/models/analyticsItemsMappers.d.ts.map                          
      [npmPack] npm notice 226B    esm/models/analyticsItemsMappers.js.map                            
      [npmPack] npm notice 2.5kB   esm/operations/annotations.d.ts.map                                
      [npmPack] npm notice 3.4kB   esm/operations/annotations.js.map                                  
      [npmPack] npm notice 224B    esm/models/annotationsMappers.d.ts.map                             
      [npmPack] npm notice 237B    esm/models/annotationsMappers.js.map                               
      [npmPack] npm notice 2.3kB   esm/operations/aPIKeys.d.ts.map                                    
      [npmPack] npm notice 3.0kB   esm/operations/aPIKeys.js.map                                      
      [npmPack] npm notice 209B    esm/models/aPIKeysMappers.d.ts.map                                 
      [npmPack] npm notice 222B    esm/models/aPIKeysMappers.js.map                                   
      [npmPack] npm notice 1.3kB   esm/applicationInsightsManagementClient.d.ts.map                   
      [npmPack] npm notice 1.9kB   esm/applicationInsightsManagementClient.js.map                     
      [npmPack] npm notice 505B    esm/applicationInsightsManagementClientContext.d.ts.map            
      [npmPack] npm notice 1.4kB   esm/applicationInsightsManagementClientContext.js.map              
      [npmPack] npm notice 494.3kB dist/arm-appinsights.js.map                                        
      [npmPack] npm notice 64.3kB  dist/arm-appinsights.min.js.map                                    
      [npmPack] npm notice 829B    esm/operations/componentAvailableFeatures.d.ts.map                 
      [npmPack] npm notice 1.1kB   esm/operations/componentAvailableFeatures.js.map                   
      [npmPack] npm notice 250B    esm/models/componentAvailableFeaturesMappers.d.ts.map              
      [npmPack] npm notice 263B    esm/models/componentAvailableFeaturesMappers.js.map                
      [npmPack] npm notice 1.4kB   esm/operations/componentCurrentBillingFeatures.d.ts.map            
      [npmPack] npm notice 1.8kB   esm/operations/componentCurrentBillingFeatures.js.map              
      [npmPack] npm notice 247B    esm/models/componentCurrentBillingFeaturesMappers.d.ts.map         
      [npmPack] npm notice 260B    esm/models/componentCurrentBillingFeaturesMappers.js.map           
      [npmPack] npm notice 833B    esm/operations/componentFeatureCapabilities.d.ts.map               
      [npmPack] npm notice 1.1kB   esm/operations/componentFeatureCapabilities.js.map                 
      [npmPack] npm notice 228B    esm/models/componentFeatureCapabilitiesMappers.d.ts.map            
      [npmPack] npm notice 241B    esm/models/componentFeatureCapabilitiesMappers.js.map              
      [npmPack] npm notice 2.4kB   esm/operations/componentLinkedStorageAccountsOperations.d.ts.map   
      [npmPack] npm notice 3.2kB   esm/operations/componentLinkedStorageAccountsOperations.js.map     
      [npmPack] npm notice 455B    esm/models/componentLinkedStorageAccountsOperationsMappers.d.ts.map
      [npmPack] npm notice 468B    esm/models/componentLinkedStorageAccountsOperationsMappers.js.map  
      [npmPack] npm notice 817B    esm/operations/componentQuotaStatus.d.ts.map                       
      [npmPack] npm notice 1.1kB   esm/operations/componentQuotaStatus.js.map                         
      [npmPack] npm notice 212B    esm/models/componentQuotaStatusMappers.d.ts.map                    
      [npmPack] npm notice 225B    esm/models/componentQuotaStatusMappers.js.map                      
      [npmPack] npm notice 4.8kB   esm/operations/components.d.ts.map                                 
      [npmPack] npm notice 6.6kB   esm/operations/components.js.map                                   

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from cf8821f with merge commit ee06806. SDK Automation 13.0.17.20200619.4
    • ️✔️azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-applicationinsights
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-applicationinsights
      [after_scripts|python] INFO:__main__:Default API version will be: v2020_03_01_preview
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 3.648% size of original (original: 71908 chars, delta: 2623 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter la_migration_date
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter ingestion_mode

    @yves-chan
    Copy link
    Contributor Author

    yves-chan commented Jul 16, 2020

    I mainly want to fix the typo on the paths on workbooks_API.json and workbookTemplates_API.json, but there are some CI errors. I added some suppression notes since this API is already in use. What is the best approach to fix the paths typos here?

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 16, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @mmyyrroonn
    Copy link
    Contributor

    @yves-chan Hi. Could you share more context about this PR since it's a breaking change.

    @yves-chan
    Copy link
    Contributor Author

    yves-chan commented Jul 20, 2020

    hi @myronfanqiu , so the purpose of this PR is to change the paths so that it's correct. Before it was using a typo in resourceGroup when it should be resourceGroups. The breaking change seems to be complaining about this path change? What should be the best course of action here?

    @yves-chan
    Copy link
    Contributor Author

    @myronfanqiu what is your Microsoft alias? maybe we can discuss this over teams?

    @mmyyrroonn
    Copy link
    Contributor

    @myronfanqiu what is your Microsoft alias? maybe we can discuss this over teams?

    Sorry!!! I miss the last response. Here is a general guideline for breaking change. We can discuss through Teams.

    “As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process”

    @yves-chan
    Copy link
    Contributor Author

    yves-chan commented Jul 23, 2020

    As of now, This change does not affect sdk, cli, or PS since the resource path is wrong to begin with so it never worked. The resource provider does not recognize ../resourceGroup/.. in the path but only recognizes ../resourceGroups/... In fact, of all the rest specs, these swaggers for workbooks_API.json and workbookTemplates_API.json are the only one which does not follow the normal convention. I think we should ago ahead with this change and fix the typo

    @mmyyrroonn mmyyrroonn added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 23, 2020
    @mmyyrroonn
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 3 pipeline(s).

    @mmyyrroonn
    Copy link
    Contributor

    /openapi pipeline

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @mmyyrroonn mmyyrroonn closed this Jul 23, 2020
    @mmyyrroonn mmyyrroonn reopened this Jul 23, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @mmyyrroonn mmyyrroonn merged commit ee06806 into Azure:master Jul 28, 2020
    @yves-chan yves-chan deleted the dev-applicationinsights-Microsoft.Insights-2018-06-17-preview branch September 11, 2020 17:23
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
    …into fix_kv_python_readme
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
      Key Vault 7.1-preview to stable (GA) (Azure#10239)
      Fix data plane cosmosdb (Azure#10277)
      Fix example request for expanding policyEvaluationDetails (Azure#10203)
      Databricks Swagger Changes for Double Encryption (Azure#9941)
      add column delimiter for SAP Table/open hub (Azure#10269)
      add doc for typescript md (Azure#10187)
      Fix sfrp 2020-01-01-preview (Azure#10268)
      [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
      Migrate TaskRun to ProxyResource. (Azure#9953)
      [Datashare]Add sorting query parameters (Azure#10209)
      [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
      Update dataController onPremise property (Azure#10263)
      Changed the Client description to include Gen2 (Azure#10178)
      Managed Clusters Generate SDK (Azure#10247)
      Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
      Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
      Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
      Add a new api and add 2020-02-02-preview versions (Azure#9710)
      Adding AML Workspace ID Property (Azure#10073)
      Add missing nullable attributes (Azure#10245)
      ...
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants