Key Vault 7.1-preview to stable (GA) #10239

jlichwa · 2020-07-23T16:32:57Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-23T16:33:02Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️❌LintDiff: 1 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` An error occurred while executing JSON.parse() on the linter output for specification/keyvault/data-plane/readme.md:	"role":"Lint Diff", "new":"https://github.com/Azure/azure-rest-api-specs/blob/444b667276579356c660c3a2771003491574bcae/specification/keyvault/data-plane/readme.md", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/keyvault/data-plane/readme.md"

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-23T16:33:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-07-23T16:33:49Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-07-23T16:34:35Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-23T16:34:35Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-23T16:34:37Z

azure-sdk-for-go - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 444b667 with merge commit de527c7. SDK Automation 13.0.17.20200619.4

[AutoRest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'JsonWebKeyType' and different values: EC,EC-HSM,RSA,RSA-HSM,oct,oct-HSM vs. RSA,RSA-HSM
[AutoRest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 147
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
[AutoRest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 179
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
[AutoRest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
[AutoRest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
[AutoRest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
[AutoRest]    at AutoRest.Modeler.Program.d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at NewPlugin.d__15.MoveNext()
[AutoRest] FATAL: go/imodeler1 - FAILED
[AutoRest] FATAL: Error: Plugin imodeler1 reported failure.
[AutoRest] Failure during batch task - {"tag":"package-7.2-preview"} -- Error: Plugin imodeler1 reported failure..
[AutoRest]   Error: Plugin imodeler1 reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.144 --go --verbose --multiapi --use-onever --preview-chk --version=previous --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/keyvault/data-plane/readme.md FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'JsonWebKeyType' and different values: EC,EC-HSM,RSA,RSA-HSM,oct,oct-HSM vs. RSA,RSA-HSM
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 179
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.d__15.MoveNext()
FATAL: go/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Failure during batch task - {"tag":"package-7.2-preview"} -- Error: Plugin imodeler1 reported failure..
  Error: Plugin imodeler1 reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-07-23T16:34:38Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-23T16:34:39Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-23T16:34:40Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-23T16:34:40Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-23T16:34:42Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

heaths

Swagger and MD files LGTM.

jlichwa · 2020-07-24T18:05:32Z

#sign-off

jlichwa · 2020-07-24T18:06:06Z

@lmazuel can we merge this PR?

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits) Key Vault 7.1-preview to stable (GA) (Azure#10239) Fix data plane cosmosdb (Azure#10277) Fix example request for expanding policyEvaluationDetails (Azure#10203) Databricks Swagger Changes for Double Encryption (Azure#9941) add column delimiter for SAP Table/open hub (Azure#10269) add doc for typescript md (Azure#10187) Fix sfrp 2020-01-01-preview (Azure#10268) [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235) Migrate TaskRun to ProxyResource. (Azure#9953) [Datashare]Add sorting query parameters (Azure#10209) [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173) Update dataController onPremise property (Azure#10263) Changed the Client description to include Gen2 (Azure#10178) Managed Clusters Generate SDK (Azure#10247) Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101) Add Location property to ExportPipeline and ImportPipeline (Azure#10177) Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134) Add a new api and add 2020-02-02-preview versions (Azure#9710) Adding AML Workspace ID Property (Azure#10073) Add missing nullable attributes (Azure#10245) ...

Key Vault 7.1-preview to stable (GA)

444b667

jlichwa requested review from heaths and schaabs July 23, 2020 16:32

jlichwa requested a review from RandalliLama as a code owner July 23, 2020 16:32

openapi-assignment-bot bot assigned lmazuel Jul 23, 2020

jlichwa marked this pull request as draft July 23, 2020 16:33

jlichwa requested a review from gdlxm July 23, 2020 17:26

heaths approved these changes Jul 23, 2020

View reviewed changes

jlichwa marked this pull request as ready for review July 24, 2020 18:05

lmazuel approved these changes Jul 28, 2020

View reviewed changes

lmazuel merged commit de527c7 into Azure:master Jul 28, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Key Vault 7.1-preview to stable (GA) (Azure#10239)

91abeb8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Key Vault 7.1-preview to stable (GA) #10239

Key Vault 7.1-preview to stable (GA) #10239

jlichwa commented Jul 23, 2020

openapi-pipeline-app bot commented Jul 23, 2020 •

edited

Loading

azure-pipelines bot commented Jul 23, 2020

azuresdkci commented Jul 23, 2020

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

heaths left a comment

jlichwa commented Jul 24, 2020

jlichwa commented Jul 24, 2020

Key Vault 7.1-preview to stable (GA) #10239

Key Vault 7.1-preview to stable (GA) #10239

Conversation

jlichwa commented Jul 23, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jul 23, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 23, 2020

azuresdkci commented Jul 23, 2020

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 23, 2020 • edited Loading

azure-sdk-for-js - Release

heaths left a comment

Choose a reason for hiding this comment

jlichwa commented Jul 24, 2020

jlichwa commented Jul 24, 2020

openapi-pipeline-app bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 23, 2020 •

edited

Loading