Update dataController onPremise property #10263

jorgbaca · 2020-07-27T16:32:33Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

Fixed systemData.

Fixed identitytype case.

…troller

openapi-pipeline-app · 2020-07-27T16:32:38Z

[Staging] Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1010 - AddingRequiredParameter	The required parameter 'dataControllerResource' was added in the new version. New: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L1521:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'dataController' renamed or removed? New: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L2304:7 Old: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L2294:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'dataController' renamed or removed? New: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L2304:7 Old: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L2294:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'onPremiseProperty' in response that was not found in the old version. New: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L2304:7 Old: Microsoft.AzureData/preview/2019-07-24-preview/azuredata.json#L2294:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-27T16:32:51Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-27T16:34:17Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-07-27T16:34:19Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-27T16:34:19Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 967a5b5 with merge commit 94ce889. SDK Automation 13.0.17.20200619.4
️✔️preview/azuredata/mgmt/2019-07-24-preview [View full logs] [Release SDK Changes]
- preview.azuredata.mgmt.2019-07-24-preview.zip

openapi-sdkautomation · 2020-07-27T16:34:19Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-27T16:34:20Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 967a5b5 with merge commit 94ce889. SDK Automation 13.0.17.20200619.4

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/_azure_data_management_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_azure_data_management_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_data_controllers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_postgres_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_managed_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_server_instances_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_server_registrations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/operations/_sql_servers_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/azuredata/version.py

openapi-sdkautomation · 2020-07-27T16:34:21Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 967a5b5 with merge commit 94ce889. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AzureData [View full logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-07-27T16:34:21Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 967a5b5 with merge commit 94ce889. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-27T16:34:22Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 967a5b5 with merge commit 94ce889. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-07-27T16:34:46Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-07-27T16:39:58Z

Can one of the admins verify this patch?

azure-pipelines · 2020-07-27T16:41:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-27T16:47:22Z

Azure Pipelines successfully started running 1 pipeline(s).

jorgbaca · 2020-07-27T17:05:53Z

Hi @weidongxu-microsoft , can you help us get this PR reviewed and merged? There are a few breaking changes but this is still a private-preview API in early stages. Our few internal customers are aware and we don't expect any impact.

Thank you for your help.

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits) Key Vault 7.1-preview to stable (GA) (Azure#10239) Fix data plane cosmosdb (Azure#10277) Fix example request for expanding policyEvaluationDetails (Azure#10203) Databricks Swagger Changes for Double Encryption (Azure#9941) add column delimiter for SAP Table/open hub (Azure#10269) add doc for typescript md (Azure#10187) Fix sfrp 2020-01-01-preview (Azure#10268) [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235) Migrate TaskRun to ProxyResource. (Azure#9953) [Datashare]Add sorting query parameters (Azure#10209) [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173) Update dataController onPremise property (Azure#10263) Changed the Client description to include Gen2 (Azure#10178) Managed Clusters Generate SDK (Azure#10247) Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101) Add Location property to ExportPipeline and ImportPipeline (Azure#10177) Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134) Add a new api and add 2020-02-02-preview versions (Azure#9710) Adding AML Workspace ID Property (Azure#10073) Add missing nullable attributes (Azure#10245) ...

* WIP: Updating Microsoft.AzureData * Minor changes * Adding new SystemData property to examples * Fixed formatting * Update azuredata.json Fixed systemData. * Update azuredata.json Fixed identitytype case. * Fixed formatting * Adding create data controller example properties * Removed extra file * Renamed parameter name * Ran prettier check

jorgbaca and others added 11 commits July 20, 2020 09:57

WIP: Updating Microsoft.AzureData

11ce62d

Merge remote-tracking branch 'azure-remote/master'

4c74ee7

Minor changes

e44ca90

Adding new SystemData property to examples

e55b9bd

Fixed formatting

a5ee8a3

Update azuredata.json

7337b93

Fixed systemData.

Update azuredata.json

78e2146

Fixed identitytype case.

Fixed formatting

7f7d4bf

Merge remote-tracking branch 'azure-remote/master'

b35a214

Merge remote-tracking branch 'azure-remote/master' into updateDataCon…

aac8219

…troller

Adding create data controller example properties

60ba789

openapi-assignment-bot bot assigned weidongxu-microsoft Jul 27, 2020

Removed extra file

89ecd4d

openapi-sdkautomation bot mentioned this pull request Jul 27, 2020

[AutoPR Microsoft.Azure.Management.AzureData] Update dataController onPremise property AzureSDKAutomation/azure-sdk-for-net#1438

Closed

Renamed parameter name

497f420

Ran prettier check

967a5b5

jorgbaca marked this pull request as ready for review July 27, 2020 17:03

weidongxu-microsoft approved these changes Jul 28, 2020

View reviewed changes

weidongxu-microsoft added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates labels Jul 28, 2020

weidongxu-microsoft merged commit 94ce889 into Azure:master Jul 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dataController onPremise property #10263

Update dataController onPremise property #10263

jorgbaca commented Jul 27, 2020

openapi-pipeline-app bot commented Jul 27, 2020 •

edited

Loading

azure-pipelines bot commented Jul 27, 2020

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

azure-pipelines bot commented Jul 27, 2020

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

azuresdkci commented Jul 27, 2020

azure-pipelines bot commented Jul 27, 2020

azure-pipelines bot commented Jul 27, 2020

jorgbaca commented Jul 27, 2020

Update dataController onPremise property #10263

Update dataController onPremise property #10263

Conversation

jorgbaca commented Jul 27, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jul 27, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 27, 2020

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

Azure CLI Extension Generation - Release

azure-pipelines bot commented Jul 27, 2020

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 27, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azuresdkci commented Jul 27, 2020

azure-pipelines bot commented Jul 27, 2020

azure-pipelines bot commented Jul 27, 2020

jorgbaca commented Jul 27, 2020

openapi-pipeline-app bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 27, 2020 •

edited

Loading