Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Clusters Generate SDK #10247

Merged
merged 7 commits into from
Jul 27, 2020
Merged

Conversation

a-santamaria
Copy link
Member

@a-santamaria a-santamaria commented Jul 24, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 24, 2020

[Staging] Swagger Validation Report

BreakingChange: 45 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1011 - AddingResponseCode The new version adds a response code '200'.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L526:11
1011 - AddingResponseCode The new version adds a response code '200'.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L330:11
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L416:11
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L595:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L591:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L682:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L677:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L519:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L515:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L526:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L521:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L636:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L630:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L718:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/managedcluster.json#L706:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L595:9
Old: Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json#L591:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e8849d8 with merge commit 3903ebe. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/servicefabric/mgmt-v2016_09_01 [View full logs]  [Release SDK Changes]
  • ⚠️sdk/servicefabric/mgmt-v2017_07_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
      [mvn]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-servicefabric: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[40,22] no suitable method found for createAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.createAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClusterInner) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/servicefabric/mgmt-v2017_07_01_preview/src/main/java/com/microsoft/azure/management/servicefabric/v2017_07_01_preview/implementation/ClusterImpl.java:[54,22] no suitable method found for updateAsync(java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters,com.microsoft.rest.ServiceCallback) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR]     method com.microsoft.azure.management.servicefabric.v2017_07_01_preview.implementation.ClustersInner.updateAsync(java.lang.String,java.lang.String,java.lang.String,java.lang.String,com.microsoft.azure.management.servicefabric.v2017_07_01_preview.ClusterUpdateParameters) is not applicable
      [mvn] [ERROR]       (actual and formal argument lists differ in length)
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ️✔️sdk/servicefabric/mgmt-v2018_02_01 [View full logs]  [Release SDK Changes]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 24, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from e8849d8 with merge commit 3903ebe. SDK Automation 13.0.17.20200619.4
    • ️✔️azure-mgmt-servicefabric [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-servicefabric
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-servicefabric
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 29.159% size of original (original: 72571 chars, delta: 21161 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model StatelessServiceUpdateProperties has a new parameter instance_close_delay_duration
      [ChangeLog]   - Model ApplicationResourceUpdate has a new parameter managed_identities
      [ChangeLog]   - Model Cluster has a new parameter application_type_versions_cleanup_policy
      [ChangeLog]   - Model ServiceResourceProperties has a new parameter service_dns_name
      [ChangeLog]   - Model ApplicationResource has a new parameter identity
      [ChangeLog]   - Model ApplicationResource has a new parameter managed_identities
      [ChangeLog]   - Model StatefulServiceProperties has a new parameter service_dns_name
      [ChangeLog]   - Model DiagnosticsStorageAccountConfig has a new parameter protected_account_key_name2
      [ChangeLog]   - Model StatelessServiceProperties has a new parameter instance_close_delay_duration
      [ChangeLog]   - Model StatelessServiceProperties has a new parameter service_dns_name
      [ChangeLog]   - Model ServiceResource has a new parameter service_dns_name
      [ChangeLog]   - Model ApplicationUpgradePolicy has a new parameter upgrade_mode
      [ChangeLog]   - Model ClusterUpdateParameters has a new parameter application_type_versions_cleanup_policy
      [ChangeLog]   - Added operation ClusterVersionsOperations.list_by_os
      [ChangeLog]   - Added operation group ManagedClustersOperations
      [ChangeLog]   - Added operation group NodeTypesOperations

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 24, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 24, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 24, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 24, 2020
    @pilor pilor added ARMReviewInProgress ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 24, 2020
    @pilor
    Copy link
    Contributor

    pilor commented Jul 24, 2020

    No ARM API review needed. These are swagger fixes and don't represent changes to the underlying API.

    @a-santamaria
    Copy link
    Member Author

    a-santamaria commented Jul 24, 2020

    @NullMDR can we bypass the breaking changes and merge the pr? the changes here are issues that were not showing up on the automation on the original pr #10085. We haven’t publish this version yet on the ARM manifest

    @PhoenixHe-NV
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 3 pipeline(s).

    @PhoenixHe-NV PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 26, 2020
    @PhoenixHe-NV PhoenixHe-NV reopened this Jul 26, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @PhoenixHe-NV
    Copy link
    Contributor

    @jianyexi Could you please help to point out what is this error message related to?

    R4005 - UniqueXmsEnumName
    Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique.
    at specification/servicefabric/resource-manager/Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json:539

    @jianyexi
    Copy link
    Contributor

    @jianyexi Could you please help to point out what is this error message related to?

    R4005 - UniqueXmsEnumName
    Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique.
    at specification/servicefabric/resource-manager/Microsoft.ServiceFabric/preview/2020-01-01-preview/nodetype.json:539

    Pls ignore the error, the result of staging LintDiff is correct , the version in prod has a bug wihch has been fixed in staging version

    @PhoenixHe-NV
    Copy link
    Contributor

    @akning-ms Please help to merge this PR with known issue in lintdiff

    @akning-ms akning-ms merged commit 3903ebe into Azure:master Jul 27, 2020
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
    …into fix_kv_python_readme
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
      Key Vault 7.1-preview to stable (GA) (Azure#10239)
      Fix data plane cosmosdb (Azure#10277)
      Fix example request for expanding policyEvaluationDetails (Azure#10203)
      Databricks Swagger Changes for Double Encryption (Azure#9941)
      add column delimiter for SAP Table/open hub (Azure#10269)
      add doc for typescript md (Azure#10187)
      Fix sfrp 2020-01-01-preview (Azure#10268)
      [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
      Migrate TaskRun to ProxyResource. (Azure#9953)
      [Datashare]Add sorting query parameters (Azure#10209)
      [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
      Update dataController onPremise property (Azure#10263)
      Changed the Client description to include Gen2 (Azure#10178)
      Managed Clusters Generate SDK (Azure#10247)
      Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
      Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
      Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
      Add a new api and add 2020-02-02-preview versions (Azure#9710)
      Adding AML Workspace ID Property (Azure#10073)
      Add missing nullable attributes (Azure#10245)
      ...
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    * changing default version in readme for sdk generation
    
    * adding managedclusters and nodetypes to tag package-2020-03 so sdk is generated for all
    
    * use the same AzureActiveDirectory model and rename others that have differences
    
    * fix lintDiff
    
    * fix lintDiff 2
    
    * fix array types
    
    * fix examples
    
    Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants