Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.PolicyInsights to update example for stable/2019-10-01 #10203

Conversation

j5lim
Copy link
Contributor

@j5lim j5lim commented Jul 20, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

This fixes $expand parameter in the example for expanding policyEvaluationDetails. The correct value the API supports is "PolicyEvaluationDetails" (case-sensitive).

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 20, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@j5lim j5lim changed the title [Hub Generated] Review request for Microsoft.PolicyInsights to add version stable/2019-10-01 [Hub Generated] Review request for Microsoft.PolicyInsights to update example for stable/2019-10-01 Jul 20, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 20, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 20, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 785e0ae with merge commit 758c7d4. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/policyinsights/mgmt-v2018_04_04 [View full logs]  [Release SDK Changes]
  • ⚠️sdk/policyinsights/mgmt-v2018_07_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
      [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:94: error: '{' expected
      [mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
      [mvn] [ERROR]                                ^
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error: = expected
      [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
      [mvn] [ERROR]                                             ^
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/src/main/java/com/microsoft/azure/management/policyinsights/v2018_07_01_preview/Remediation.java:100: error:  expected
      [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
      [mvn] [ERROR]                                                           ^
      [mvn] [ERROR] 
      [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
      [mvn] [ERROR] 
      [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2018_07_01_preview/target/apidocs' dir.
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
    • ⚠️sdk/policyinsights/mgmt-v2019_10_01 [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-policyinsights: MavenReportException: Error while creating archive: 
        [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:99: error: '{' expected
        [mvn] [ERROR]         interface WithMicrosoft.PolicyInsight {
        [mvn] [ERROR]                                ^
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error: = expected
        [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
        [mvn] [ERROR]                                             ^
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/src/main/java/com/microsoft/azure/management/policyinsights/v2019_10_01/Remediation.java:105: error:  expected
        [mvn] [ERROR]             WithCreate withExistingMicrosoft.PolicyInsight(String managementGroupId);
        [mvn] [ERROR]                                                           ^
        [mvn] [ERROR] 
        [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
        [mvn] [ERROR] 
        [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/policyinsights/mgmt-v2019_10_01/target/apidocs' dir.
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 20, 2020

      azure-sdk-for-go - Release

      ️✔️ succeeded [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Jul 20, 2020

      azure-sdk-for-net - Release

      failed [Logs] [Expand Details]
      • Generate from 785e0ae with merge commit 758c7d4. SDK Automation 13.0.17.20200619.4
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • Microsoft.Azure.Management.PolicyInsights [View full logs]  [Release SDK Changes]
          Failed to create the package Microsoft.Azure.Management.PolicyInsights.
          Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=policyinsights /v:n /p:SkipTests=true , {} 

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jul 20, 2020

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 785e0ae with merge commit 758c7d4. SDK Automation 13.0.17.20200619.4
        • ️✔️@azure/arm-policyinsights [View full logs]  [Release SDK Changes]
          Only show 100 items here, please refer to log for details.
          [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
          [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
          [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
          [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/policyInsightsClient.js → ./dist/arm-policyinsights.js...
          [npmPack] created ./dist/arm-policyinsights.js in 482ms
          [npmPack] npm notice 
          [npmPack] npm notice package: @azure/arm-policyinsights@3.2.0
          [npmPack] npm notice === Tarball Contents === 
          [npmPack] npm notice 184.1kB dist/arm-policyinsights.js                         
          [npmPack] npm notice 67.4kB  dist/arm-policyinsights.min.js                     
          [npmPack] npm notice 345B    esm/models/index.js                                
          [npmPack] npm notice 563B    esm/operations/index.js                            
          [npmPack] npm notice 54.2kB  esm/models/mappers.js                              
          [npmPack] npm notice 1.6kB   esm/operations/operations.js                       
          [npmPack] npm notice 478B    esm/models/operationsMappers.js                    
          [npmPack] npm notice 7.6kB   esm/models/parameters.js                           
          [npmPack] npm notice 18.3kB  esm/operations/policyEvents.js                     
          [npmPack] npm notice 490B    esm/models/policyEventsMappers.js                  
          [npmPack] npm notice 1.7kB   esm/policyInsightsClient.js                        
          [npmPack] npm notice 2.2kB   esm/policyInsightsClientContext.js                 
          [npmPack] npm notice 3.2kB   esm/operations/policyMetadataOperations.js         
          [npmPack] npm notice 517B    esm/models/policyMetadataOperationsMappers.js      
          [npmPack] npm notice 32.2kB  esm/operations/policyStates.js                     
          [npmPack] npm notice 705B    esm/models/policyStatesMappers.js                  
          [npmPack] npm notice 8.7kB   esm/operations/policyTrackedResources.js           
          [npmPack] npm notice 548B    esm/models/policyTrackedResourcesMappers.js        
          [npmPack] npm notice 32.5kB  esm/operations/remediations.js                     
          [npmPack] npm notice 600B    esm/models/remediationsMappers.js                  
          [npmPack] npm notice 994B    rollup.config.js                                   
          [npmPack] npm notice 1.7kB   package.json                                       
          [npmPack] npm notice 457B    tsconfig.json                                      
          [npmPack] npm notice 468.8kB dist/arm-policyinsights.js.map                     
          [npmPack] npm notice 60.3kB  dist/arm-policyinsights.min.js.map                 
          [npmPack] npm notice 31.8kB  esm/models/index.d.ts.map                          
          [npmPack] npm notice 252B    esm/operations/index.d.ts.map                      
          [npmPack] npm notice 126B    esm/models/index.js.map                            
          [npmPack] npm notice 267B    esm/operations/index.js.map                        
          [npmPack] npm notice 2.1kB   esm/models/mappers.d.ts.map                        
          [npmPack] npm notice 29.0kB  esm/models/mappers.js.map                          
          [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                 
          [npmPack] npm notice 908B    esm/operations/operations.js.map                   
          [npmPack] npm notice 228B    esm/models/operationsMappers.d.ts.map              
          [npmPack] npm notice 241B    esm/models/operationsMappers.js.map                
          [npmPack] npm notice 1.6kB   esm/models/parameters.d.ts.map                     
          [npmPack] npm notice 5.7kB   esm/models/parameters.js.map                       
          [npmPack] npm notice 6.8kB   esm/operations/policyEvents.d.ts.map               
          [npmPack] npm notice 10.6kB  esm/operations/policyEvents.js.map                 
          [npmPack] npm notice 232B    esm/models/policyEventsMappers.d.ts.map            
          [npmPack] npm notice 245B    esm/models/policyEventsMappers.js.map              
          [npmPack] npm notice 779B    esm/policyInsightsClient.d.ts.map                  
          [npmPack] npm notice 992B    esm/policyInsightsClient.js.map                    
          [npmPack] npm notice 428B    esm/policyInsightsClientContext.d.ts.map           
          [npmPack] npm notice 1.2kB   esm/policyInsightsClientContext.js.map             
          [npmPack] npm notice 1.4kB   esm/operations/policyMetadataOperations.d.ts.map   
          [npmPack] npm notice 2.0kB   esm/operations/policyMetadataOperations.js.map     
          [npmPack] npm notice 263B    esm/models/policyMetadataOperationsMappers.d.ts.map
          [npmPack] npm notice 276B    esm/models/policyMetadataOperationsMappers.js.map  
          [npmPack] npm notice 11.7kB  esm/operations/policyStates.d.ts.map               
          [npmPack] npm notice 17.8kB  esm/operations/policyStates.js.map                 
          [npmPack] npm notice 356B    esm/models/policyStatesMappers.d.ts.map            
          [npmPack] npm notice 369B    esm/models/policyStatesMappers.js.map              
          [npmPack] npm notice 3.5kB   esm/operations/policyTrackedResources.d.ts.map     
          [npmPack] npm notice 4.9kB   esm/operations/policyTrackedResources.js.map       
          [npmPack] npm notice 265B    esm/models/policyTrackedResourcesMappers.d.ts.map  
          [npmPack] npm notice 278B    esm/models/policyTrackedResourcesMappers.js.map    
          [npmPack] npm notice 14.5kB  esm/operations/remediations.d.ts.map               
          [npmPack] npm notice 19.4kB  esm/operations/remediations.js.map                 
          [npmPack] npm notice 288B    esm/models/remediationsMappers.d.ts.map            
          [npmPack] npm notice 301B    esm/models/remediationsMappers.js.map              
          [npmPack] npm notice 3.5kB   README.md                                          
          [npmPack] npm notice 86.1kB  esm/models/index.d.ts                              
          [npmPack] npm notice 247B    esm/operations/index.d.ts                          
          [npmPack] npm notice 81.7kB  src/models/index.ts                                
          [npmPack] npm notice 531B    src/operations/index.ts                            
          [npmPack] npm notice 2.7kB   esm/models/mappers.d.ts                            
          [npmPack] npm notice 41.7kB  src/models/mappers.ts                              
          [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                     
          [npmPack] npm notice 2.3kB   src/operations/operations.ts                       
          [npmPack] npm notice 168B    esm/models/operationsMappers.d.ts                  
          [npmPack] npm notice 444B    src/models/operationsMappers.ts                    
          [npmPack] npm notice 2.1kB   esm/models/parameters.d.ts                         
          [npmPack] npm notice 7.6kB   src/models/parameters.ts                           
          [npmPack] npm notice 20.6kB  esm/operations/policyEvents.d.ts                   
          [npmPack] npm notice 41.0kB  src/operations/policyEvents.ts                     
          [npmPack] npm notice 180B    esm/models/policyEventsMappers.d.ts                
          [npmPack] npm notice 454B    src/models/policyEventsMappers.ts                  
          [npmPack] npm notice 1.1kB   esm/policyInsightsClient.d.ts                      
          [npmPack] npm notice 1.9kB   src/policyInsightsClient.ts                        
          [npmPack] npm notice 657B    esm/policyInsightsClientContext.d.ts               
          [npmPack] npm notice 2.0kB   src/policyInsightsClientContext.ts                 
          [npmPack] npm notice 3.1kB   esm/operations/policyMetadataOperations.d.ts       
          [npmPack] npm notice 6.1kB   src/operations/policyMetadataOperations.ts         
          [npmPack] npm notice 207B    esm/models/policyMetadataOperationsMappers.d.ts    
          [npmPack] npm notice 471B    src/models/policyMetadataOperationsMappers.ts      
          [npmPack] npm notice 40.3kB  esm/operations/policyStates.d.ts                   

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jul 20, 2020

        azure-sdk-for-python - Release

        - Breaking Change detected in SDK

        ⚠️ warning [Logs] [Expand Details]
        • ⚠️ Generate from 785e0ae with merge commit 758c7d4. SDK Automation 13.0.17.20200619.4
        • ⚠️azure-mgmt-policyinsights [View full logs]  [Release SDK Changes] Breaking Change Detected
          [build_conf] INFO:packaging_tools:Building template azure-mgmt-policyinsights
          [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
          [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
          [build_conf] INFO:packaging_tools:Template done azure-mgmt-policyinsights
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] warning: no files found matching '*.py' under directory 'tests'
          [build_package] warning: no files found matching '*.yaml' under directory 'tests'
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] warning: no files found matching '*.py' under directory 'tests'
          [build_package] warning: no files found matching '*.yaml' under directory 'tests'
          [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
          [ChangeLog] Size of delta 6.609% size of original (original: 45618 chars, delta: 3015 chars)
          [ChangeLog] **Features**
          [ChangeLog] 
          [ChangeLog]   - Model PolicyEvent has a new parameter compliance_state
          [ChangeLog]   - Model PolicyEvent has a new parameter components
          [ChangeLog]   - Model PolicyState has a new parameter components
          [ChangeLog]   - Model QueryOptions has a new parameter skip_token
          [ChangeLog] 
          [ChangeLog] **Breaking changes**
          [ChangeLog] 
          [ChangeLog]   - Removed operation PolicyEventsOperations.get_metadata

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jul 20, 2020

        azure-sdk-for-python

        ⚠️ warning [Logs] [Expand Details]
        • ⚠️ Generate from 785e0ae with merge commit 28edb6cfc94b31b0b26df646ede7f08d0e2003af. SDK Automation 13.0.17.20200619.4
        • ⚠️azure-mgmt-policyinsights [View full logs
          [build_conf] INFO:packaging_tools:Building template azure-mgmt-policyinsights
          [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
          [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
          [build_conf] INFO:packaging_tools:Template done azure-mgmt-policyinsights
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] warning: no files found matching '*.py' under directory 'tests'
          [build_package] warning: no files found matching '*.yaml' under directory 'tests'
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] warning: no files found matching '*.py' under directory 'tests'
          [build_package] warning: no files found matching '*.yaml' under directory 'tests'
          No file is changed.

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jul 20, 2020

        Trenton Generation - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @azuresdkci
        Copy link
        Contributor

        Can one of the admins verify this patch?

        @j5lim j5lim requested a review from sandipsh July 21, 2020 16:46
        Copy link
        Contributor

        @sandipsh sandipsh left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        It's strange that $expand is case-sensitive while other options and properties are case-insensitive. But I guess any change to make it case-insensitive would be breaking change and not worth doing it. So, yeah, makes sense to fix the document instead.

        @j5lim
        Copy link
        Contributor Author

        j5lim commented Jul 22, 2020

        @fengzhou-msft Could you please review this pr?

        @fengzhou-msft fengzhou-msft merged commit 758c7d4 into Azure:master Jul 28, 2020
        @j5lim j5lim deleted the dev-policyinsights-Microsoft.PolicyInsights-2019-10-01 branch July 28, 2020 16:57
        iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
        …into fix_kv_python_readme
        
        * 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
          Key Vault 7.1-preview to stable (GA) (Azure#10239)
          Fix data plane cosmosdb (Azure#10277)
          Fix example request for expanding policyEvaluationDetails (Azure#10203)
          Databricks Swagger Changes for Double Encryption (Azure#9941)
          add column delimiter for SAP Table/open hub (Azure#10269)
          add doc for typescript md (Azure#10187)
          Fix sfrp 2020-01-01-preview (Azure#10268)
          [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
          Migrate TaskRun to ProxyResource. (Azure#9953)
          [Datashare]Add sorting query parameters (Azure#10209)
          [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
          Update dataController onPremise property (Azure#10263)
          Changed the Client description to include Gen2 (Azure#10178)
          Managed Clusters Generate SDK (Azure#10247)
          Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
          Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
          Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
          Add a new api and add 2020-02-02-preview versions (Azure#9710)
          Adding AML Workspace ID Property (Azure#10073)
          Add missing nullable attributes (Azure#10245)
          ...
        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
        Co-authored-by: Jin Soon Lim <jilim@microsoft.com>
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        None yet
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        4 participants