[Datashare]Add sorting query parameters #10209

vnvaditya · 2020-07-21T00:29:34Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-21T00:29:39Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-21T00:29:50Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-21T00:31:20Z

Azure CLI Extension Generation - Release

Installation instruction for service datashare [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10209/azure-cli-extensions/Azure/azure-cli-extensions/datashare/datashare-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 292e2cb with merge commit e8679c7. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Accounts/put/Accounts_Create
[AutoRest]     - name: /Accounts/get/Accounts_Get
[AutoRest]     - name: /Accounts/get/Accounts_ListByResourceGroup
[AutoRest]     - name: /Accounts/get/Accounts_ListBySubscription
[AutoRest]     - name: /Accounts/patch/Accounts_Update
[AutoRest]     - name: /ConsumerInvitations/get/ConsumerInvitations_Get
[AutoRest]     - name: /ConsumerInvitations/get/ConsumerInvitations_ListInvitations
[AutoRest]     - name: /ConsumerInvitations/post/ConsumerInvitations_RejectInvitation
[AutoRest]     - name: /ConsumerSourceDataSets/get/ConsumerSourceDataSets_ListByShareSubscription
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_Create
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDB_Create
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDWDataSetToAdlsGen2File_Create
[AutoRest]     - name: /DataSetMappings/put/DataSetMappings_SqlDW_Create
[AutoRest]     - name: /DataSetMappings/get/DataSetMappings_Get
[AutoRest]     - name: /DataSetMappings/get/DataSetMappings_ListByShareSubscription
[AutoRest]     - name: /DataSets/put/DataSets_Create
[AutoRest]     - name: /DataSets/put/DataSets_KustoCluster_Create
[AutoRest]     - name: /DataSets/put/DataSets_KustoDatabase_Create
[AutoRest]     - name: /DataSets/put/DataSets_SqlDBTable_Create
[AutoRest]     - name: /DataSets/put/DataSets_SqlDWTable_Create
[AutoRest]     - name: /DataSets/get/DataSets_Get
[AutoRest]     - name: /DataSets/get/DataSets_ListByShare
[AutoRest]     - name: /Invitations/put/Invitations_Create
[AutoRest]     - name: /Invitations/get/Invitations_Get
[AutoRest]     - name: /Invitations/get/Invitations_ListByShare
[AutoRest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_GetByShare
[AutoRest]     - name: /ProviderShareSubscriptions/get/ProviderShareSubscriptions_ListByShare
[AutoRest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Reinstate
[AutoRest]     - name: /ProviderShareSubscriptions/post/ProviderShareSubscriptions_Revoke
[AutoRest]     - name: /ShareSubscriptions/put/ShareSubscriptions_Create
[AutoRest]     - name: /ShareSubscriptions/get/ShareSubscriptions_Get
[AutoRest]     - name: /ShareSubscriptions/get/ShareSubscriptions_ListByAccount
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_CancelSynchronization
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSourceShareSynchronizationSettings
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizationDetails
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_ListSynchronizations
[AutoRest]     - name: /ShareSubscriptions/post/ShareSubscriptions_Synchronize
[AutoRest]     - name: /Shares/put/Shares_Create
[AutoRest]     - name: /Shares/get/Shares_Get
[AutoRest]     - name: /Shares/get/Shares_ListByAccount
[AutoRest]     - name: /Shares/post/Shares_ListSynchronizationDetails
[AutoRest]     - name: /Shares/post/Shares_ListSynchronizations
[AutoRest]     - name: /SynchronizationSettings/put/SynchronizationSettings_Create
[AutoRest]     - name: /SynchronizationSettings/get/SynchronizationSettings_Get
[AutoRest]     - name: /SynchronizationSettings/get/SynchronizationSettings_ListByShare
[AutoRest]     - name: /Triggers/put/Triggers_Create
[AutoRest]     - name: /Triggers/get/Triggers_Get
[AutoRest]     - name: /Triggers/get/Triggers_ListByShareSubscription
[AutoRest]     - name: /Accounts/delete/Accounts_Delete
[AutoRest]     - name: /DataSetMappings/delete/DataSetMappings_Delete
[AutoRest]     - name: /DataSets/delete/DataSets_Delete
[AutoRest]     - name: /Invitations/delete/Invitations_Delete
[AutoRest]     - name: /ShareSubscriptions/delete/ShareSubscriptions_Delete
[AutoRest]     - name: /Shares/delete/Shares_Delete
[AutoRest]     - name: /SynchronizationSettings/delete/SynchronizationSettings_Delete
[AutoRest]     - name: /Triggers/delete/Triggers_Delete
[AutoRest] --------------------------------------------------------

️✔️datashare [View full logs] [Release Azure CLI Changes]
- datashare-0.1.0-py3-none-any.whl
- datashare-0.1.0.zip

openapi-sdkautomation · 2020-07-21T00:31:24Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 292e2cb with merge commit e8679c7. SDK Automation 13.0.17.20200619.4
️✔️datashare/mgmt/2019-11-01 [View full logs] [Release SDK Changes]
- datashare.mgmt.2019-11-01.zip
️✔️preview/datashare/mgmt/2018-11-01-preview [View full logs] [Release SDK Changes]
- preview.datashare.mgmt.2018-11-01-preview.zip

openapi-sdkautomation · 2020-07-21T00:31:27Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 292e2cb with merge commit e8679c7. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataShare [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataShare.1.0.1.nupkg
- Microsoft.Azure.Management.DataShare.1.0.1.snupkg

openapi-sdkautomation · 2020-07-21T00:31:28Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-21T00:31:29Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 292e2cb with merge commit e8679c7. SDK Automation 13.0.17.20200619.4

⚠️azure-mgmt-datashare [View full logs] [Release SDK Changes] Breaking Change Detected

[build_conf] INFO:packaging_tools:Building template azure-mgmt-datashare
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-datashare
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 2.793% size of original (original: 70386 chars, delta: 1966 chars)
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
[ChangeLog]   - Operation DataSetMappingsOperations.list_by_share_subscription has a new signature
[ChangeLog]   - Operation DataSetsOperations.list_by_share has a new signature
[ChangeLog]   - Operation DataSetsOperations.list_by_share has a new signature
[ChangeLog]   - Operation InvitationsOperations.list_by_share has a new signature
[ChangeLog]   - Operation InvitationsOperations.list_by_share has a new signature
[ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
[ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronization_details has a new signature
[ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
[ChangeLog]   - Operation ShareSubscriptionsOperations.list_synchronizations has a new signature
[ChangeLog]   - Operation SharesOperations.list_synchronization_details has a new signature
[ChangeLog]   - Operation SharesOperations.list_synchronization_details has a new signature
[ChangeLog]   - Operation SharesOperations.list_synchronizations has a new signature
[ChangeLog]   - Operation SharesOperations.list_synchronizations has a new signature
[ChangeLog]   - Operation SharesOperations.list_by_account has a new signature
[ChangeLog]   - Operation ShareSubscriptionsOperations.list_by_account has a new signature

openapi-sdkautomation · 2020-07-21T00:31:32Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 292e2cb with merge commit e8679c7. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-datashare [View full logs] [Release SDK Changes]

azure-arm-datashare-1.0.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/dataShareManagementClient.js → ./dist/arm-datashare.js...
[npmPack] created ./dist/arm-datashare.js in 477ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-datashare@1.0.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 10.3kB  esm/operations/accounts.js                           
[npmPack] npm notice 1.3kB   esm/models/accountsMappers.js                        
[npmPack] npm notice 249.8kB dist/arm-datashare.js                                
[npmPack] npm notice 92.4kB  dist/arm-datashare.min.js                            
[npmPack] npm notice 4.3kB   esm/operations/consumerInvitations.js                
[npmPack] npm notice 1.3kB   esm/models/consumerInvitationsMappers.js             
[npmPack] npm notice 3.1kB   esm/operations/consumerSourceDataSets.js             
[npmPack] npm notice 1.3kB   esm/models/consumerSourceDataSetsMappers.js          
[npmPack] npm notice 7.1kB   esm/operations/dataSetMappings.js                    
[npmPack] npm notice 1.3kB   esm/models/dataSetMappingsMappers.js                 
[npmPack] npm notice 7.6kB   esm/operations/dataSets.js                           
[npmPack] npm notice 1.3kB   esm/models/dataSetsMappers.js                        
[npmPack] npm notice 2.3kB   esm/dataShareManagementClient.js                     
[npmPack] npm notice 2.6kB   esm/dataShareManagementClientContext.js              
[npmPack] npm notice 345B    esm/models/index.js                                  
[npmPack] npm notice 765B    esm/operations/index.js                              
[npmPack] npm notice 6.6kB   esm/operations/invitations.js                        
[npmPack] npm notice 1.3kB   esm/models/invitationsMappers.js                     
[npmPack] npm notice 90.1kB  esm/models/mappers.js                                
[npmPack] npm notice 2.2kB   esm/operations/operations.js                         
[npmPack] npm notice 623B    esm/models/operationsMappers.js                      
[npmPack] npm notice 4.4kB   esm/models/parameters.js                             
[npmPack] npm notice 8.2kB   esm/operations/providerShareSubscriptions.js         
[npmPack] npm notice 1.3kB   esm/models/providerShareSubscriptionsMappers.js      
[npmPack] npm notice 989B    rollup.config.js                                     
[npmPack] npm notice 11.3kB  esm/operations/shares.js                             
[npmPack] npm notice 1.4kB   esm/models/sharesMappers.js                          
[npmPack] npm notice 20.1kB  esm/operations/shareSubscriptions.js                 
[npmPack] npm notice 1.5kB   esm/models/shareSubscriptionsMappers.js              
[npmPack] npm notice 8.4kB   esm/operations/synchronizationSettings.js            
[npmPack] npm notice 1.3kB   esm/models/synchronizationSettingsMappers.js         
[npmPack] npm notice 9.5kB   esm/operations/triggers.js                           
[npmPack] npm notice 1.3kB   esm/models/triggersMappers.js                        
[npmPack] npm notice 1.7kB   package.json                                         
[npmPack] npm notice 457B    tsconfig.json                                        
[npmPack] npm notice 3.4kB   esm/operations/accounts.d.ts.map                     
[npmPack] npm notice 5.7kB   esm/operations/accounts.js.map                       
[npmPack] npm notice 708B    esm/models/accountsMappers.d.ts.map                  
[npmPack] npm notice 721B    esm/models/accountsMappers.js.map                    
[npmPack] npm notice 521.4kB dist/arm-datashare.js.map                            
[npmPack] npm notice 69.7kB  dist/arm-datashare.min.js.map                        
[npmPack] npm notice 2.0kB   esm/operations/consumerInvitations.d.ts.map          
[npmPack] npm notice 2.7kB   esm/operations/consumerInvitations.js.map            
[npmPack] npm notice 707B    esm/models/consumerInvitationsMappers.d.ts.map       
[npmPack] npm notice 720B    esm/models/consumerInvitationsMappers.js.map         
[npmPack] npm notice 1.3kB   esm/operations/consumerSourceDataSets.d.ts.map       
[npmPack] npm notice 1.7kB   esm/operations/consumerSourceDataSets.js.map         
[npmPack] npm notice 713B    esm/models/consumerSourceDataSetsMappers.d.ts.map    
[npmPack] npm notice 726B    esm/models/consumerSourceDataSetsMappers.js.map      
[npmPack] npm notice 3.1kB   esm/operations/dataSetMappings.d.ts.map              
[npmPack] npm notice 3.9kB   esm/operations/dataSetMappings.js.map                
[npmPack] npm notice 699B    esm/models/dataSetMappingsMappers.d.ts.map           
[npmPack] npm notice 712B    esm/models/dataSetMappingsMappers.js.map             
[npmPack] npm notice 2.8kB   esm/operations/dataSets.d.ts.map                     
[npmPack] npm notice 4.2kB   esm/operations/dataSets.js.map                       
[npmPack] npm notice 682B    esm/models/dataSetsMappers.d.ts.map                  
[npmPack] npm notice 695B    esm/models/dataSetsMappers.js.map                    
[npmPack] npm notice 1.0kB   esm/dataShareManagementClient.d.ts.map               
[npmPack] npm notice 1.4kB   esm/dataShareManagementClient.js.map                 
[npmPack] npm notice 516B    esm/dataShareManagementClientContext.d.ts.map        
[npmPack] npm notice 1.4kB   esm/dataShareManagementClientContext.js.map          
[npmPack] npm notice 41.4kB  esm/models/index.d.ts.map                            
[npmPack] npm notice 380B    esm/operations/index.d.ts.map                        
[npmPack] npm notice 126B    esm/models/index.js.map                              
[npmPack] npm notice 395B    esm/operations/index.js.map                          
[npmPack] npm notice 3.0kB   esm/operations/invitations.d.ts.map                  
[npmPack] npm notice 3.9kB   esm/operations/invitations.js.map                    
[npmPack] npm notice 688B    esm/models/invitationsMappers.d.ts.map               
[npmPack] npm notice 701B    esm/models/invitationsMappers.js.map                 
[npmPack] npm notice 3.7kB   esm/models/mappers.d.ts.map                          
[npmPack] npm notice 50.9kB  esm/models/mappers.js.map                            
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
[npmPack] npm notice 287B    esm/models/operationsMappers.d.ts.map                
[npmPack] npm notice 300B    esm/models/operationsMappers.js.map                  
[npmPack] npm notice 1.1kB   esm/models/parameters.d.ts.map                       
[npmPack] npm notice 3.3kB   esm/models/parameters.js.map                         
[npmPack] npm notice 2.8kB   esm/operations/providerShareSubscriptions.d.ts.map   
[npmPack] npm notice 4.0kB   esm/operations/providerShareSubscriptions.js.map     
[npmPack] npm notice 721B    esm/models/providerShareSubscriptionsMappers.d.ts.map
[npmPack] npm notice 734B    esm/models/providerShareSubscriptionsMappers.js.map  
[npmPack] npm notice 4.5kB   esm/operations/shares.d.ts.map                       
[npmPack] npm notice 6.5kB   esm/operations/shares.js.map                         
[npmPack] npm notice 743B    esm/models/sharesMappers.d.ts.map                    
[npmPack] npm notice 756B    esm/models/sharesMappers.js.map                      
[npmPack] npm notice 6.3kB   esm/operations/shareSubscriptions.d.ts.map           
[npmPack] npm notice 10.0kB  esm/operations/shareSubscriptions.js.map

openapi-sdkautomation · 2020-07-21T00:31:34Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-07-21T00:32:11Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-07-21T00:33:34Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

akning-ms · 2020-07-22T13:14:43Z

Hi @vnvaditya, can you give us change log for this PR? and help to adjust some order for operation to make diff tool more user friendly? it looks too many change in PR now

vnvaditya · 2020-07-22T18:14:44Z

Hello, here are the changes to the swagger that are included in this PR.

905c134ab079714cbbc85428fdf0c81339c53e6e
a7405c2d2ea24dbb8bda2ee2f6bc0354084e629d

1227fe1fe951c6fbcb34522882cb8981e2733164

1f903fcda5995e61a3b7b2f62b5a19258aa29c4c

ab26c7adf2cf678889772e233948ded338533ac3

39a0002fdf84927727f74b50c644a52c303cde9b (Just Sorting)

akning-ms · 2020-07-23T12:49:03Z

Hi @vnvaditya, I mean the order of path/operation in swagger is different in new swagger. it caused me difficult to review which part is your really change. is this swagger generated automatically?

vnvaditya · 2020-07-24T09:18:31Z

@akning-ms - We are automatically generating the swagger and it was causing issues with reviews. So, we decided that we will order the operations and paths etc alphabetically for once. This will make reviews better going forward.

vnvaditya · 2020-07-24T09:45:17Z

I can create one PR with just the changes but will have to followup another PR for re-ordering.

azure-pipelines · 2020-07-24T09:58:12Z

Azure Pipelines successfully started running 1 pipeline(s).

vnvaditya · 2020-07-24T11:15:47Z

@akning-ms - I reverted the ordering of the API's . Once this is approved and merged, I'll create another PR for re-ordering.

akning-ms · 2020-07-24T11:47:21Z

Thanks @vnvaditya, LGTM for API perspecitve, but FYI, your PR changed breaking change for python sdk as show here:
#10209 (comment) @changlong-liu for awareness (python SDK owner) . if you confirm it is expected. I will help you merge it

vnvaditya · 2020-07-24T16:39:48Z

@akning-ms - The python failure was for my first iteration. After I reverted the API ordering, all 27 checks are passed and I think there are no breaking changes.

changlong-liu · 2020-07-27T02:09:28Z

@akning-ms Arthur Ning FTE - The python failure was for my first iteration. After I reverted the API ordering, all 27 checks are passed and I think there are no breaking changes.

Hi @vnvaditya , this change will bring breaking changes in Python SDK: #10209 (comment) . It's because new parameters are added. Please make sure they are expected.

vnvaditya · 2020-07-27T14:51:49Z

@changlong-liu - We just added query parameters for filtering and sorting. I'm not sure if this should be considered as breaking changes. The industry standard is we should be ok with query parameters. Also, Java, .net and other sdk's seems fine.

If Python restricts us by doing so, we are fine with this breaking change. We don't have any Python SDK customers based on the traffic and communicate if we have any. Please sign off.

Thanks,
Aditya

changlong-liu · 2020-07-28T01:52:15Z

Hi @vnvaditya , adding query parameters is a breaking change in current Python SDK.

You may refer to here to understand why it is breaking: AzureSDKAutomation/azure-sdk-for-python@50af844#diff-6602c76927522f9562221eff283c90ceR250

For other languages: if they don't have tail parameters like custom_headers and raw, then it's not a breaking change.

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits) Key Vault 7.1-preview to stable (GA) (Azure#10239) Fix data plane cosmosdb (Azure#10277) Fix example request for expanding policyEvaluationDetails (Azure#10203) Databricks Swagger Changes for Double Encryption (Azure#9941) add column delimiter for SAP Table/open hub (Azure#10269) add doc for typescript md (Azure#10187) Fix sfrp 2020-01-01-preview (Azure#10268) [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235) Migrate TaskRun to ProxyResource. (Azure#9953) [Datashare]Add sorting query parameters (Azure#10209) [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173) Update dataController onPremise property (Azure#10263) Changed the Client description to include Gen2 (Azure#10178) Managed Clusters Generate SDK (Azure#10247) Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101) Add Location property to ExportPipeline and ImportPipeline (Azure#10177) Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134) Add a new api and add 2020-02-02-preview versions (Azure#9710) Adding AML Workspace ID Property (Azure#10073) Add missing nullable attributes (Azure#10245) ...

* unhidden status * add typescript to sdk automation * add pagination query parameters * re-vert re-ordering of the API's Co-authored-by: Crystal YU <chunyu@microsoft.com> Co-authored-by: Aditya Vutukuri <advutuku@microsoft.com>

chunyu3 and others added 5 commits June 11, 2020 17:14

unhidden status

1a427dc

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

ead1a66

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

6b438f9

add typescript to sdk automation

59f4416

add pagination query parameters

14c494e

openapi-assignment-bot bot assigned akning-ms Jul 21, 2020

This was referenced Jul 21, 2020

[AutoPR datashare] [Datashare]Add sorting query parameters AzureSDKAutomation/azure-cli-extensions#150

Closed

[AutoPR azure-mgmt-datashare] [Datashare]Add sorting query parameters AzureSDKAutomation/azure-sdk-for-python#1631

Closed

This was referenced Jul 21, 2020

[AutoPR @azure/arm-datashare] [Datashare]Add sorting query parameters AzureSDKAutomation/azure-sdk-for-js#1567

Closed

[AutoPR Microsoft.Azure.Management.DataShare] [Datashare]Add sorting query parameters AzureSDKAutomation/azure-sdk-for-net#1418

Closed

vnvaditya changed the title ~~Add sorting query parameters~~ [Datashare]Add sorting query parameters Jul 21, 2020

akning-ms added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jul 22, 2020

re-vert re-ordering of the API's

292e2cb

akning-ms added potential-sdk-breaking-change and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jul 24, 2020

akning-ms approved these changes Jul 28, 2020

View reviewed changes

akning-ms merged commit e8679c7 into Azure:master Jul 28, 2020

This was referenced Jul 29, 2020

[datashare] sort api's and definitions #10273

Merged

[DataShare] sort definitions in the 2019 version #10301

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Datashare]Add sorting query parameters #10209

[Datashare]Add sorting query parameters #10209

vnvaditya commented Jul 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2020 •

edited

Loading

azure-pipelines bot commented Jul 21, 2020

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

azuresdkci commented Jul 21, 2020

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

akning-ms commented Jul 22, 2020

vnvaditya commented Jul 22, 2020

akning-ms commented Jul 23, 2020

vnvaditya commented Jul 24, 2020

vnvaditya commented Jul 24, 2020

azure-pipelines bot commented Jul 24, 2020

vnvaditya commented Jul 24, 2020

akning-ms commented Jul 24, 2020 •

edited

Loading

vnvaditya commented Jul 24, 2020

changlong-liu commented Jul 27, 2020

vnvaditya commented Jul 27, 2020

changlong-liu commented Jul 28, 2020

[Datashare]Add sorting query parameters #10209

[Datashare]Add sorting query parameters #10209

Conversation

vnvaditya commented Jul 21, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jul 21, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jul 21, 2020

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azuresdkci commented Jul 21, 2020

openapi-sdkautomation bot commented Jul 21, 2020 • edited Loading

Trenton Generation - Release

akning-ms commented Jul 22, 2020

vnvaditya commented Jul 22, 2020

akning-ms commented Jul 23, 2020

vnvaditya commented Jul 24, 2020

vnvaditya commented Jul 24, 2020

azure-pipelines bot commented Jul 24, 2020

vnvaditya commented Jul 24, 2020

akning-ms commented Jul 24, 2020 • edited Loading

vnvaditya commented Jul 24, 2020

changlong-liu commented Jul 27, 2020

vnvaditya commented Jul 27, 2020

changlong-liu commented Jul 28, 2020

vnvaditya commented Jul 21, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 21, 2020 •

edited

Loading

akning-ms commented Jul 24, 2020 •

edited

Loading