Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the base for Cypress tests and automation #1016

Merged
merged 56 commits into from
May 10, 2021
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented May 7, 2021

closes #809

  • created a custom cy command to login with web3 (we should use it before any test)
  • added some specific test data to the UI elements that are needed according to cypress best practices
  • created a first test to make sure a reload with a saved browser logs in users directly without prompting for a password or anything
  • very slightly refactored the Tkey threshold context to avoid having to wait in tests when web3 login was successful, but the address wasn't available yet (it was a matter of a couple mili-sec)
  • added a Github action to run them for each commit

eventual todo for future PR:

@render
Copy link

render bot commented May 7, 2021

@Tbaut Tbaut requested review from FSM1, tanmoyAtb and RyRy79261 and removed request for FSM1 May 10, 2021 12:26
@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label May 10, 2021
@@ -1,6 +1,6 @@
registry=https://registry.yarnpkg.com/

@chainsafe:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=$GITHUB_PACKAGES_AUTH_TOKEN
//npm.pkg.github.com/:_authToken=${GITHUB_PACKAGES_AUTH_TOKEN}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird.. not sure why. This file must not be used is it? (bare in mind that this branch started something like 2 months ago and this is a side effect of this I guess)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that npmrc file is only utilized if installing the common-context dependencies without running a full install at the root

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awww yuss 🎉

Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some next level experience in testing.
I just can't stop myself from watching testing UI run through its steps :D .

Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some next level experience in testing.
I just can't stop myself from watching testing UI run through its steps :D .

@Tbaut Tbaut removed the Status: Review Needed 👀 Added to PRs when they need more review label May 10, 2021
@Tbaut Tbaut merged commit 72baa15 into dev May 10, 2021
@Tbaut Tbaut deleted the mnt/tbaut-cypress-test-809 branch May 10, 2021 17:39
@FSM1 FSM1 mentioned this pull request May 27, 2021
FSM1 added a commit that referenced this pull request May 31, 2021
* Fix upload (#1010)
* Bulk operations for Bin (#1017)
* Set the base for Cypress tests and automation (#1016)
* Update Send Feedback Link (#1024)
* only enable logging in non-mainnet env (#1020)
* Optimize tests (#1027)
* fix (#1030)
* File browser context provider (#1026)
* work on selections  (#1029)
* Remove release drafter for now (#1038)
* Update Readme for tests (#1036)
* Delete release_drafter.yml (#1039)
* Bulk DND Move files (#1028)
* Test file upload (#1035)
* Selection removal preventions (#1037)
* Theme selection UI fix (#1033)
* Update API client (#1032)
* make it light and the files blue (#1049)
* React-PDF Worker fixes (#1052)
* Store screenshots and video of failing tests (#1054)
* fix test classes and add rename test (#1055)
* Hide date for folders (#1060)
* s/testId/testid (#1064)
* folder path in route fixed (#1066)
* Resolve File Browser race condition (#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build the base for tests, starting by the file upload modal
4 participants