-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store screenshots and video of failing tests #1054
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1054.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2meaou31hsclcu05gq0. |
yay I managed to reproduce and have artifacts (screenshot and video) see https://github.com/ChainSafe/files-ui/actions/runs/874924400 Looks like the runner is freezing.. so nothing happens after. Could that be because of the viewport change.. There's no way localhost:3000 isn't there, it's been working well for all the other tests before, and my previous PR shows that waiting longer doesn't help settings.ts.mp4 |
Might this have something to do with Electron not liking the smaller viewport? Could we possibly try running the tests against the Cypress Chrome/Firefox docker container instead? |
So the thing is that it does work sometimes, so if Electron freezes with a viewport change, why sometimes not? Regarding the Firefox/Chrome implementation maybe can @asnaith take a look? |
It seems that cypress 7.0 has introduced performance issues, and 7.2 should have solved many of them but there are still many users reporting issues: cypress-io/cypress#16305 Some ways to keep the tests fasts:
I'll add this in this PR and hope that things will get better. |
…i into fix/tbaut-test-failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the tests are passing again 🎉
Well, they were passing sometimes... which is the whole problem. Let's see how things go with some more time. Now we have things in place to get the recorded video and screenshots quickly at least, and a small optimization. |
* Fix upload (#1010) * Bulk operations for Bin (#1017) * Set the base for Cypress tests and automation (#1016) * Update Send Feedback Link (#1024) * only enable logging in non-mainnet env (#1020) * Optimize tests (#1027) * fix (#1030) * File browser context provider (#1026) * work on selections (#1029) * Remove release drafter for now (#1038) * Update Readme for tests (#1036) * Delete release_drafter.yml (#1039) * Bulk DND Move files (#1028) * Test file upload (#1035) * Selection removal preventions (#1037) * Theme selection UI fix (#1033) * Update API client (#1032) * make it light and the files blue (#1049) * React-PDF Worker fixes (#1052) * Store screenshots and video of failing tests (#1054) * fix test classes and add rename test (#1055) * Hide date for folders (#1060) * s/testId/testid (#1064) * folder path in route fixed (#1066) * Resolve File Browser race condition (#1069)
replaces #1050