-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk DND Move files #1028
Bulk DND Move files #1028
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1028.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2dsd1b2v8pd0ivpk2m0. |
packages/files-ui/src/Components/Modules/FileBrowsers/views/FileSystemItem/FileSystemItem.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/FileSystemItem/FileSystemItem.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/FilesTable.view.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/FilesTable.view.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/DragPreviewLayer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/DragPreviewLayer.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…leSystemItem/FileSystemItem.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You convinced me, we can make the preview look better in the future, it's already great to be able to move several files at once 🚀
packages/files-ui/src/Components/Modules/FileBrowsers/views/DragPreviewLayer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/DragPreviewLayer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting this error from DragPreviewLayer
Removed the table row, and now just rendering an icon and the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks smooth and good to go!
* Fix upload (#1010) * Bulk operations for Bin (#1017) * Set the base for Cypress tests and automation (#1016) * Update Send Feedback Link (#1024) * only enable logging in non-mainnet env (#1020) * Optimize tests (#1027) * fix (#1030) * File browser context provider (#1026) * work on selections (#1029) * Remove release drafter for now (#1038) * Update Readme for tests (#1036) * Delete release_drafter.yml (#1039) * Bulk DND Move files (#1028) * Test file upload (#1035) * Selection removal preventions (#1037) * Theme selection UI fix (#1033) * Update API client (#1032) * make it light and the files blue (#1049) * React-PDF Worker fixes (#1052) * Store screenshots and video of failing tests (#1054) * fix test classes and add rename test (#1055) * Hide date for folders (#1060) * s/testId/testid (#1064) * folder path in route fixed (#1066) * Resolve File Browser race condition (#1069)
Closes #1001
Resolves some cases where the selection was not reset when navigating
Also fixes the grid view navigation into folders