Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk DND Move files #1028

Merged
merged 20 commits into from
May 19, 2021
Merged

Bulk DND Move files #1028

merged 20 commits into from
May 19, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented May 12, 2021

Closes #1001
Resolves some cases where the selection was not reset when navigating
Also fixes the grid view navigation into folders

@render
Copy link

render bot commented May 12, 2021

@FSM1 FSM1 added the Release: Minor only for PROD release PR label May 12, 2021
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label May 13, 2021
@FSM1 FSM1 marked this pull request as ready for review May 13, 2021 18:33
@FSM1 FSM1 self-assigned this May 13, 2021
@FSM1 FSM1 added the Type: Feature Added to PRs to identify that the change is a new feature. label May 13, 2021
FSM1 and others added 3 commits May 14, 2021 11:25
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…leSystemItem/FileSystemItem.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You convinced me, we can make the preview look better in the future, it's already great to be able to move several files at once 🚀

@FSM1 FSM1 requested a review from tanmoyAtb May 18, 2021 14:52
@tanmoyAtb
Copy link
Contributor

Getting this error from DragPreviewLayer

Screenshot 2021-05-18 at 11 14 59 PM

Copy link
Contributor Author

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error from DragPreviewLayer

Removed the table row, and now just rendering an icon and the name.

@FSM1 FSM1 requested review from RyRy79261 and tanmoyAtb May 19, 2021 11:09
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks smooth and good to go!

@FSM1 FSM1 merged commit fe02105 into dev May 19, 2021
@FSM1 FSM1 deleted the feat/bulk-dnd-move-files-1001 branch May 19, 2021 23:51
@FSM1 FSM1 mentioned this pull request May 27, 2021
FSM1 added a commit that referenced this pull request May 31, 2021
* Fix upload (#1010)
* Bulk operations for Bin (#1017)
* Set the base for Cypress tests and automation (#1016)
* Update Send Feedback Link (#1024)
* only enable logging in non-mainnet env (#1020)
* Optimize tests (#1027)
* fix (#1030)
* File browser context provider (#1026)
* work on selections  (#1029)
* Remove release drafter for now (#1038)
* Update Readme for tests (#1036)
* Delete release_drafter.yml (#1039)
* Bulk DND Move files (#1028)
* Test file upload (#1035)
* Selection removal preventions (#1037)
* Theme selection UI fix (#1033)
* Update API client (#1032)
* make it light and the files blue (#1049)
* React-PDF Worker fixes (#1052)
* Store screenshots and video of failing tests (#1054)
* fix test classes and add rename test (#1055)
* Hide date for folders (#1060)
* s/testId/testid (#1064)
* folder path in route fixed (#1066)
* Resolve File Browser race condition (#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor only for PROD release PR Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for DnD Move of multiple files
4 participants