Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve File Browser race condition #1069

Merged
merged 9 commits into from
May 31, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented May 30, 2021

Closes #1068

@render
Copy link

render bot commented May 30, 2021

@FSM1 FSM1 self-assigned this May 30, 2021
@FSM1 FSM1 added Priority: P0 Critical Added to issues relating to a critical severity bugs. Release: Patch only for PROD release PR Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug labels May 30, 2021
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, much cleaner!
Just a couple nits

@Tbaut Tbaut added Status: Merge Ready ✅ and removed Status: Review Needed 👀 Added to PRs when they need more review labels May 31, 2021
FSM1 and others added 2 commits June 1, 2021 02:05
@FSM1 FSM1 merged commit 5087dc2 into dev May 31, 2021
@FSM1 FSM1 deleted the fix/file-browser-content-race-condition-1068 branch May 31, 2021 14:43
@FSM1 FSM1 mentioned this pull request May 31, 2021
FSM1 added a commit that referenced this pull request May 31, 2021
* Fix upload (#1010)
* Bulk operations for Bin (#1017)
* Set the base for Cypress tests and automation (#1016)
* Update Send Feedback Link (#1024)
* only enable logging in non-mainnet env (#1020)
* Optimize tests (#1027)
* fix (#1030)
* File browser context provider (#1026)
* work on selections  (#1029)
* Remove release drafter for now (#1038)
* Update Readme for tests (#1036)
* Delete release_drafter.yml (#1039)
* Bulk DND Move files (#1028)
* Test file upload (#1035)
* Selection removal preventions (#1037)
* Theme selection UI fix (#1033)
* Update API client (#1032)
* make it light and the files blue (#1049)
* React-PDF Worker fixes (#1052)
* Store screenshots and video of failing tests (#1054)
* fix test classes and add rename test (#1055)
* Hide date for folders (#1060)
* s/testId/testid (#1064)
* folder path in route fixed (#1066)
* Resolve File Browser race condition (#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P0 Critical Added to issues relating to a critical severity bugs. Release: Patch only for PROD release PR Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket 'ls' race condition
4 participants