-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve File Browser race condition #1069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://files-ui-stage-pr-1069.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2q0p58irho589q0oajg. |
FSM1
added
Priority: P0 Critical
Added to issues relating to a critical severity bugs.
Release: Patch
only for PROD release PR
Status: Review Needed 👀
Added to PRs when they need more review
Type: Bug Fix
Added to PRs if they are addressing a bug
labels
May 30, 2021
…o fix/file-browser-content-race-condition-1068
RyRy79261
approved these changes
May 31, 2021
Tbaut
approved these changes
May 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, much cleaner!
Just a couple nits
packages/files-ui/src/Components/Modules/FileBrowsers/SearchFileBrowser.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/BinFileBrowser.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CSFFileBrowser.tsx
Outdated
Show resolved
Hide resolved
Tbaut
added
Status: Merge Ready ✅
and removed
Status: Review Needed 👀
Added to PRs when they need more review
labels
May 31, 2021
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
tanmoyAtb
approved these changes
May 31, 2021
Merged
FSM1
added a commit
that referenced
this pull request
May 31, 2021
* Fix upload (#1010) * Bulk operations for Bin (#1017) * Set the base for Cypress tests and automation (#1016) * Update Send Feedback Link (#1024) * only enable logging in non-mainnet env (#1020) * Optimize tests (#1027) * fix (#1030) * File browser context provider (#1026) * work on selections (#1029) * Remove release drafter for now (#1038) * Update Readme for tests (#1036) * Delete release_drafter.yml (#1039) * Bulk DND Move files (#1028) * Test file upload (#1035) * Selection removal preventions (#1037) * Theme selection UI fix (#1033) * Update API client (#1032) * make it light and the files blue (#1049) * React-PDF Worker fixes (#1052) * Store screenshots and video of failing tests (#1054) * fix test classes and add rename test (#1055) * Hide date for folders (#1060) * s/testId/testid (#1064) * folder path in route fixed (#1066) * Resolve File Browser race condition (#1069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: P0 Critical
Added to issues relating to a critical severity bugs.
Release: Patch
only for PROD release PR
Type: Bug Fix
Added to PRs if they are addressing a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1068