-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix first login on big screens #1030
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1030.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2f69n464cks7b2i1em0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to test this 😅
Create a new metamask account and log in? |
@FSM1 I dont have whats considered a big screen. |
@RyRy79261 i don't either, but just you can see how it looks with a window higher than your screen by extending the window in height, move it down so that the overflowing part is not visible but it doesn't matter as long as the window's height is high. Not sure what I'm saying is understandable |
Well if the bottom of the window is out of your screen, then yes it's expected. If in your screenshot the bottom of the window is actually where there's a task bar, then it's not expected :D |
* Fix upload (#1010) * Bulk operations for Bin (#1017) * Set the base for Cypress tests and automation (#1016) * Update Send Feedback Link (#1024) * only enable logging in non-mainnet env (#1020) * Optimize tests (#1027) * fix (#1030) * File browser context provider (#1026) * work on selections (#1029) * Remove release drafter for now (#1038) * Update Readme for tests (#1036) * Delete release_drafter.yml (#1039) * Bulk DND Move files (#1028) * Test file upload (#1035) * Selection removal preventions (#1037) * Theme selection UI fix (#1033) * Update API client (#1032) * make it light and the files blue (#1049) * React-PDF Worker fixes (#1052) * Store screenshots and video of failing tests (#1054) * fix test classes and add rename test (#1055) * Hide date for folders (#1060) * s/testId/testid (#1064) * folder path in route fixed (#1066) * Resolve File Browser race condition (#1069)
closes #986
Should be pretty straight forward. Please check with your screens (I did check on mobile and it looks good afaics).