Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first login on big screens #1030

Merged
merged 1 commit into from
May 14, 2021
Merged

Fix first login on big screens #1030

merged 1 commit into from
May 14, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented May 14, 2021

closes #986

Should be pretty straight forward. Please check with your screens (I did check on mobile and it looks good afaics).

@render
Copy link

render bot commented May 14, 2021

Copy link
Contributor

@RyRy79261 RyRy79261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test this 😅

@FSM1
Copy link
Contributor

FSM1 commented May 14, 2021

Not sure how to test this 😅

Create a new metamask account and log in?

@RyRy79261
Copy link
Contributor

@FSM1 I dont have whats considered a big screen.

@Tbaut
Copy link
Collaborator Author

Tbaut commented May 14, 2021

@RyRy79261 i don't either, but just you can see how it looks with a window higher than your screen by extending the window in height, move it down so that the overflowing part is not visible but it doesn't matter as long as the window's height is high. Not sure what I'm saying is understandable

@RyRy79261
Copy link
Contributor

@Tbaut

Is this expected?
image

@Tbaut
Copy link
Collaborator Author

Tbaut commented May 14, 2021

Well if the bottom of the window is out of your screen, then yes it's expected. If in your screenshot the bottom of the window is actually where there's a task bar, then it's not expected :D

@Tbaut
Copy link
Collaborator Author

Tbaut commented May 14, 2021

Like this is expected, because half of the window is actually hidden (my screen is much less than 1600px heigh)
image

@Tbaut Tbaut merged commit f7165ce into dev May 14, 2021
@Tbaut Tbaut deleted the fix/tbaut-big-screens-986 branch May 14, 2021 13:37
FSM1 added a commit that referenced this pull request May 31, 2021
* Fix upload (#1010)
* Bulk operations for Bin (#1017)
* Set the base for Cypress tests and automation (#1016)
* Update Send Feedback Link (#1024)
* only enable logging in non-mainnet env (#1020)
* Optimize tests (#1027)
* fix (#1030)
* File browser context provider (#1026)
* work on selections  (#1029)
* Remove release drafter for now (#1038)
* Update Readme for tests (#1036)
* Delete release_drafter.yml (#1039)
* Bulk DND Move files (#1028)
* Test file upload (#1035)
* Selection removal preventions (#1037)
* Theme selection UI fix (#1033)
* Update API client (#1032)
* make it light and the files blue (#1049)
* React-PDF Worker fixes (#1052)
* Store screenshots and video of failing tests (#1054)
* fix test classes and add rename test (#1055)
* Hide date for folders (#1060)
* s/testId/testid (#1064)
* folder path in route fixed (#1066)
* Resolve File Browser race condition (#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication selection doesn't look good on big screen
3 participants