Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme selection UI fix #1033

Merged
merged 6 commits into from
May 21, 2021
Merged

Theme selection UI fix #1033

merged 6 commits into from
May 21, 2021

Conversation

tanmoyAtb
Copy link
Contributor

closes #1019

@render
Copy link

render bot commented May 18, 2021

@tanmoyAtb tanmoyAtb added Release: Minor only for PROD release PR Status: Review Needed 👀 Added to PRs when they need more review labels May 18, 2021
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good :)

@FSM1 FSM1 added Status: Merge Ready ✅ and removed Status: Review Needed 👀 Added to PRs when they need more review labels May 19, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented May 21, 2021

Tests are flaky with a 60s load event on the main page. This is weird, I'll look into this:

 |   Settings
 |     ✓ can navigate to the settings profile page (10068ms)
 |     1) can navigate to the settings security page on a phone
 | 
 | 
 |   1 passing (1m)
 |   1 failing
 | 
 |   1) Settings
 |        can navigate to the settings security page on a phone:
 |      CypressError: Timed out after waiting `60000ms` for your remote page to load.
 | 
 | Your page did not fire its `load` event within `60000ms`.

@tanmoyAtb
Copy link
Contributor Author

Tests are flaky with a 60s load event on the main page. This is weird, I'll look into this:

 |   Settings
 |     ✓ can navigate to the settings profile page (10068ms)
 |     1) can navigate to the settings security page on a phone
 | 
 | 
 |   1 passing (1m)
 |   1 failing
 | 
 |   1) Settings
 |        can navigate to the settings security page on a phone:
 |      CypressError: Timed out after waiting `60000ms` for your remote page to load.
 | 
 | Your page did not fire its `load` event within `60000ms`.

Thanks, @Tbaut I was getting confused with this,
The tests have passed after a new merge with dev,
I am merging this PR for now.

@tanmoyAtb tanmoyAtb merged commit 8fb1499 into dev May 21, 2021
@tanmoyAtb tanmoyAtb deleted the fix/theme-settings-view-1019 branch May 21, 2021 09:24
@Tbaut
Copy link
Collaborator

Tbaut commented May 21, 2021

yeah I just relaunched it and it passed, that's def not normal. I'll see if it happens again.

@FSM1 FSM1 mentioned this pull request May 27, 2021
FSM1 added a commit that referenced this pull request May 31, 2021
* Fix upload (#1010)
* Bulk operations for Bin (#1017)
* Set the base for Cypress tests and automation (#1016)
* Update Send Feedback Link (#1024)
* only enable logging in non-mainnet env (#1020)
* Optimize tests (#1027)
* fix (#1030)
* File browser context provider (#1026)
* work on selections  (#1029)
* Remove release drafter for now (#1038)
* Update Readme for tests (#1036)
* Delete release_drafter.yml (#1039)
* Bulk DND Move files (#1028)
* Test file upload (#1035)
* Selection removal preventions (#1037)
* Theme selection UI fix (#1033)
* Update API client (#1032)
* make it light and the files blue (#1049)
* React-PDF Worker fixes (#1052)
* Store screenshots and video of failing tests (#1054)
* fix test classes and add rename test (#1055)
* Hide date for folders (#1060)
* s/testId/testid (#1064)
* folder path in route fixed (#1066)
* Resolve File Browser race condition (#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor only for PROD release PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings theme selection overflows
4 participants