Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test classes and add rename test #1055

Merged
merged 20 commits into from
May 27, 2021
Merged

fix test classes and add rename test #1055

merged 20 commits into from
May 27, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented May 26, 2021

  • test renaming a file
  • test the use of "enter" and "escape" keys
  • test "name length too small" error
  • found some forgotten translations
  • fixed small copy mistakes ("file" and "folder" where inverted)
  • fixed any use of className to query element and start adding testId props to our external components.

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label May 26, 2021
Base automatically changed from fix/tbaut-test-failing to dev May 27, 2021 09:03
@render
Copy link

render bot commented May 27, 2021

@Tbaut Tbaut removed the Status: Review Needed 👀 Added to PRs when they need more review label May 27, 2021
@Tbaut Tbaut merged commit 357ba7d into dev May 27, 2021
@Tbaut Tbaut deleted the mnt/tbaut-test-rename branch May 27, 2021 11:20
@FSM1 FSM1 mentioned this pull request May 27, 2021
FSM1 added a commit that referenced this pull request May 31, 2021
* Fix upload (#1010)
* Bulk operations for Bin (#1017)
* Set the base for Cypress tests and automation (#1016)
* Update Send Feedback Link (#1024)
* only enable logging in non-mainnet env (#1020)
* Optimize tests (#1027)
* fix (#1030)
* File browser context provider (#1026)
* work on selections  (#1029)
* Remove release drafter for now (#1038)
* Update Readme for tests (#1036)
* Delete release_drafter.yml (#1039)
* Bulk DND Move files (#1028)
* Test file upload (#1035)
* Selection removal preventions (#1037)
* Theme selection UI fix (#1033)
* Update API client (#1032)
* make it light and the files blue (#1049)
* React-PDF Worker fixes (#1052)
* Store screenshots and video of failing tests (#1054)
* fix test classes and add rename test (#1055)
* Hide date for folders (#1060)
* s/testId/testid (#1064)
* folder path in route fixed (#1066)
* Resolve File Browser race condition (#1069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants