Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Uncaught exception in share transfer module #871

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Apr 5, 2021

Closes #860

@FSM1 FSM1 self-assigned this Apr 5, 2021
@render
Copy link

render bot commented Apr 5, 2021

@render
Copy link

render bot commented Apr 5, 2021

@render
Copy link

render bot commented Apr 5, 2021

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks goot. This is another place where I would suggest a promise.then.catch as a little nicer way to handle this than async/await and the try/catch, but that's a nit.

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@FSM1
Copy link
Contributor Author

FSM1 commented Apr 6, 2021

Thanks, looks goot. This is another place where I would suggest a promise.then.catch as a little nicer way to handle this than async/await and the try/catch, but that's a nit.

@Tbaut which place is it that you're referring to?

@FSM1 FSM1 merged commit c59dccf into dev Apr 6, 2021
@FSM1 FSM1 deleted the fix/uncaught-exception-logging-out-after-having-selected-google-auth-860 branch April 6, 2021 16:32
@Tbaut
Copy link
Collaborator

Tbaut commented Apr 7, 2021

Sorry for the late reply @FSM1 I mean this lonely await here, but not a big deal.

FSM1 added a commit that referenced this pull request Apr 12, 2021
Crash when going back after having selected Google auth #860 (PR #871)
Login optimizations (PR #879)
Minor fixes + Updates to color manipulator (#874)
Merge pull request #879 from ChainSafe/fix/login-optimizations
Merge pull request #887 from ChainSafe/fix/tbaut-hover-color
Merge pull request #886 from ChainSafe/feat/tkey-darkmode
Remove code duplication (#889)
Merge pull request #895 from ChainSafe/fix/select-all-892
Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890
Merge pull request #894 from ChainSafe/fix/mobile-spinner-893
Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846
folder validation (#899)
saved browsers settings (#865)
Prevent the whole app from rerendering every 5s (#909)
Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… …
Merge pull request #905 from ChainSafe/fix/bin-file-view-873 …
Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 …
Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-…
Fix: Search results all show as files (#914) …
Fix double click opening the next file preview (#915) …
Rename tooltip and fixes (#912) …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when going back after having selected Google auth
3 participants