Prevent the whole app from rerendering every 5s #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://chainsafex-dev-pr-909.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1o8e9ncq1ljd22n372g. |
|
Your Render PR Server URL is https://files-ui-dev-pr-909.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1o8e9vcq1ljd22n3780. |
|
Your Render PR Server URL is https://files-landing-dev-pr-909.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1o8eafcq1ljd22n37rg. |
Tbaut
changed the title
tanmoyAtb
reviewed
Apr 9, 2021
packages/files-ui/src/Components/Modules/FileBrowsers/views/FileSystemItemRow.tsx
Outdated
Show resolved
Hide resolved
…leSystemItemRow.tsx Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
tanmoyAtb
reviewed
Apr 11, 2021
packages/files-ui/src/Components/Modules/FileBrowsers/CSFFileBrowser.tsx
Outdated
Show resolved
Hide resolved
tanmoyAtb
reviewed
Apr 11, 2021
packages/files-ui/src/Components/Modules/FileBrowsers/views/FileSystemItemRow.tsx
Outdated
Show resolved
Hide resolved
tanmoyAtb
approved these changes
Apr 11, 2021
…leSystemItemRow.tsx
…rowser.tsx Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
FSM1
added a commit
that referenced
this pull request
Apr 12, 2021
Crash when going back after having selected Google auth #860 (PR #871) Login optimizations (PR #879) Minor fixes + Updates to color manipulator (#874) Merge pull request #879 from ChainSafe/fix/login-optimizations Merge pull request #887 from ChainSafe/fix/tbaut-hover-color Merge pull request #886 from ChainSafe/feat/tkey-darkmode Remove code duplication (#889) Merge pull request #895 from ChainSafe/fix/select-all-892 Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890 Merge pull request #894 from ChainSafe/fix/mobile-spinner-893 Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846 folder validation (#899) saved browsers settings (#865) Prevent the whole app from rerendering every 5s (#909) Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… … Merge pull request #905 from ChainSafe/fix/bin-file-view-873 … Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 … Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-… Fix: Search results all show as files (#914) … Fix double click opening the next file preview (#915) … Rename tooltip and fixes (#912) …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a failed attempt to figure out #884 I did a lot of cleanup to prevent many components to re-render needlessly.
The only logic change here is to check if the amount of
shareTransferchanged before updating the state. We end up not refreshing the whole app every 5s because these events (new shareTransfer) actually happen rarely.The rest of this PR is bike shedding.