Security settings #877

Tbaut · 2021-04-06T12:57:24Z

closes #846

…ettings-security-846

render · 2021-04-06T12:57:26Z

Your Render PR Server URL is https://chainsafex-dev-pr-877.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1m5ldbs1gh9omc9jct0.

render · 2021-04-06T12:57:27Z

Your Render PR Server URL is https://files-ui-dev-pr-877.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1m5ldjs1gh9omc9jd2g.

render · 2021-04-06T12:57:28Z

Your Render PR Server URL is https://files-landing-dev-pr-877.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1m5le3s1gh9omc9jdng.

packages/files-ui/src/Components/Modules/LoginModule/PasswordSetup.tsx

packages/files-ui/src/Components/Modules/LoginModule/SaveBackupPhrase.tsx

packages/files-ui/src/Components/Modules/Settings/Security/index.tsx

packages/files-ui/src/Components/Modules/hooks/useLoggedInAs.ts

…etup.tsx

packages/files-ui/src/Components/Modules/hooks/useLoggedInAs.ts

RyRy79261 · 2021-04-08T05:58:18Z

@Tbaut There seems to be a max limit set on the Account Security items instead of full width

RyRy79261

Desktop:
[1/4] just the previous comment about the widths of the account security items

Mobile:
[2/4] Wallet settings needs padding:

[3/4] There's also a lot of white space at the bottom of wallet settings

[4/4] And I'm not sure how to go back to the option selection screen on mobile

Tbaut · 2021-04-08T08:22:18Z

I've set the grid to have width 8 on "md" because it looks pretty bad otherwise. Even with a 10 (see below), it doesn't look good IMHO, the item descriptions is just too far from the property.
and 3. fixed.
I've stick to the design here, there's nothing to click to go back, but on mobile using the browser "back" should work and I thought it is intuitive enough. That's something we should think about with @sweetpea22 and see if real users have troubles with that.

* shares * browserShares * hasPassword and hasMnemonic

FSM1 · 2021-04-08T12:21:24Z

I've stick to the design here, there's nothing to click to go back, but on mobile using the browser "back" should work and I thought it is intuitive enough. That's something we should think about with @sweetpea22 and see if real users have troubles with that.

Yeah agreed that this can be dealt with later... One potential solution could be to use the breadcrumb to go back Home > Settings > Security

packages/files-ui/src/Contexts/ThresholdKeyContext.tsx

tanmoyAtb · 2021-04-08T14:47:15Z

The setup password section just feels a little awkward with the spacings inside,
I get we are using the same component, maybe we could pass in a prop to make the design more like in figma.

tanmoyAtb · 2021-04-08T14:51:32Z

Needs some spaces above.

Not so major,
In Tab size screens things get very cramped, maybe pull up the mobile view in tab size screens

tanmoyAtb

Wonderful work !
Everything seems to be in order.
Left some UI related comments which can be addressed later if we want.

Tbaut · 2021-04-08T15:35:18Z

Agreed the design is far from perfect. Let me try to get this sorted a bit before merging. The same components are used but this shouldn't prevent me from doing something nice.

FSM1 · 2021-04-08T15:35:19Z

Wonderful work !
Everything seems to be in order.
Left some UI related comments which can be addressed later if we want.

I am also of the opinion that this should get merged as functionally it works really well, and we can sort out less critical styling and layout issues after release of all the latest to staging...

Tbaut · 2021-04-08T16:21:35Z

I couldn't figure out the "cramped" around 1000px resolution, this is due to the grid :( so creating an issue out of it.
The spacing for the password form should be better now:

mostly fixed

Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>

Crash when going back after having selected Google auth #860 (PR #871) Login optimizations (PR #879) Minor fixes + Updates to color manipulator (#874) Merge pull request #879 from ChainSafe/fix/login-optimizations Merge pull request #887 from ChainSafe/fix/tbaut-hover-color Merge pull request #886 from ChainSafe/feat/tkey-darkmode Remove code duplication (#889) Merge pull request #895 from ChainSafe/fix/select-all-892 Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890 Merge pull request #894 from ChainSafe/fix/mobile-spinner-893 Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846 folder validation (#899) saved browsers settings (#865) Prevent the whole app from rerendering every 5s (#909) Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… … Merge pull request #905 from ChainSafe/fix/bin-file-view-873 … Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 … Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-… Fix: Search results all show as files (#914) … Fix double click opening the next file preview (#915) … Rename tooltip and fixes (#912) …

Thibaut Sardan added 5 commits March 31, 2021 15:42

security setting base

62991f1

wip

c52ed9e

Merge branch 'dev' of github.com:ChainSafe/files-ui into feat/tbaut-s…

ed3f587

…ettings-security-846

create loggedinas and extract passwordform

7c6f678

lint

808450e

Thibaut Sardan added 4 commits April 6, 2021 16:37

nonce.umod is not a function

1f9b217

bump tkey and pw change working

6fc7e36

mnemonic

4e33303

translations

f289044

Tbaut requested review from RyRy79261 and FSM1 April 7, 2021 10:43

Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Apr 7, 2021

Tbaut requested a review from tanmoyAtb April 7, 2021 10:43

Tbaut marked this pull request as ready for review April 7, 2021 10:43

Tbaut commented Apr 7, 2021

View reviewed changes

packages/files-ui/src/Components/Modules/LoginModule/PasswordSetup.tsx Outdated Show resolved Hide resolved

Tbaut commented Apr 7, 2021

View reviewed changes

packages/files-ui/src/Components/Modules/LoginModule/SaveBackupPhrase.tsx Show resolved Hide resolved

Tbaut commented Apr 7, 2021

View reviewed changes

packages/files-ui/src/Components/Modules/Settings/Security/index.tsx Outdated Show resolved Hide resolved

Tbaut commented Apr 7, 2021

View reviewed changes

packages/files-ui/src/Components/Modules/hooks/useLoggedInAs.ts Outdated Show resolved Hide resolved

Update packages/files-ui/src/Components/Modules/LoginModule/PasswordS…

21ff6b3

…etup.tsx

FSM1 reviewed Apr 7, 2021

View reviewed changes

packages/files-ui/src/Components/Modules/hooks/useLoggedInAs.ts Outdated Show resolved Hide resolved

Thibaut Sardan added 3 commits April 7, 2021 19:06

merge dev

219c912

bring it to tkcontext

b42ddb2

mobile padding

72da72c

Tbaut requested a review from FSM1 April 7, 2021 17:46

forgotten className

672680a

RyRy79261 approved these changes Apr 8, 2021

View reviewed changes

RyRy79261 self-requested a review April 8, 2021 05:58

RyRy79261 previously requested changes Apr 8, 2021

View reviewed changes

RyRy79261 added the Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. label Apr 8, 2021

padding

1fa4cd1

Tbaut requested a review from RyRy79261 April 8, 2021 08:23

Tbaut removed the Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. label Apr 8, 2021

Thibaut Sardan and others added 2 commits April 8, 2021 10:24

stray comments

1a08132

Remove code duplication (#889)

2ebc246

* shares * browserShares * hasPassword and hasMnemonic

FSM1 approved these changes Apr 8, 2021

View reviewed changes

tanmoyAtb reviewed Apr 8, 2021

View reviewed changes

packages/files-ui/src/Contexts/ThresholdKeyContext.tsx Outdated Show resolved Hide resolved

tanmoyAtb approved these changes Apr 8, 2021

View reviewed changes

Thibaut Sardan added 2 commits April 8, 2021 18:16

better spacing

7a3fa7c

some more margin

16e9482

Tbaut requested review from RyRy79261 and removed request for RyRy79261 April 8, 2021 16:22

RyRy79261 approved these changes Apr 8, 2021

View reviewed changes

Update packages/files-ui/src/Contexts/ThresholdKeyContext.tsx

06b5a6f

Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>

FSM1 merged commit 336a1c3 into dev Apr 8, 2021

FSM1 deleted the feat/tbaut-settings-security-846 branch April 8, 2021 16:27

Tbaut mentioned this pull request Apr 8, 2021

Security setting screen "cramped" around 1000px resolution #900

Closed

FSM1 mentioned this pull request Apr 9, 2021

Release latest fixes to Staging #908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Security settings #877

Security settings #877

Tbaut commented Apr 6, 2021

render bot commented Apr 6, 2021

render bot commented Apr 6, 2021

render bot commented Apr 6, 2021

RyRy79261 commented Apr 8, 2021

RyRy79261 left a comment •

edited

Loading

Tbaut commented Apr 8, 2021 •

edited

Loading

FSM1 commented Apr 8, 2021

tanmoyAtb commented Apr 8, 2021

tanmoyAtb commented Apr 8, 2021

tanmoyAtb left a comment

Tbaut commented Apr 8, 2021

FSM1 commented Apr 8, 2021

Tbaut commented Apr 8, 2021

Security settings #877

Security settings #877

Conversation

Tbaut commented Apr 6, 2021

render bot commented Apr 6, 2021

render bot commented Apr 6, 2021

render bot commented Apr 6, 2021

RyRy79261 commented Apr 8, 2021

RyRy79261 left a comment • edited Loading

Choose a reason for hiding this comment

Tbaut commented Apr 8, 2021 • edited Loading

FSM1 commented Apr 8, 2021

tanmoyAtb commented Apr 8, 2021

tanmoyAtb commented Apr 8, 2021

tanmoyAtb left a comment

Choose a reason for hiding this comment

Tbaut commented Apr 8, 2021

FSM1 commented Apr 8, 2021

Tbaut commented Apr 8, 2021

RyRy79261 left a comment •

edited

Loading

Tbaut commented Apr 8, 2021 •

edited

Loading