Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed loader #894

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Fixed loader #894

merged 2 commits into from
Apr 8, 2021

Conversation

RyRy79261
Copy link
Contributor

closes #893

@RyRy79261 RyRy79261 added the Status: Review Needed 👀 Added to PRs when they need more review label Apr 8, 2021
@RyRy79261 RyRy79261 self-assigned this Apr 8, 2021
@render
Copy link

render bot commented Apr 8, 2021

Your Render PR Server URL is https://chainsafex-dev-pr-894.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1ncldvcq1lusigqff6g.

@render
Copy link

render bot commented Apr 8, 2021

Your Render PR Server URL is https://files-ui-dev-pr-894.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1ncle7cq1lusigqffc0.

@render
Copy link

render bot commented Apr 8, 2021

Your Render PR Server URL is https://files-landing-dev-pr-894.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1nclencq1lusigqfg0g.

Tbaut
Tbaut approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested approval, code looks good, I didn't have that huge spinner problem :D

FSM1
FSM1 suggested changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loader is too small on desktop now.

Could we not handle this responsive behaviour in the Loader component directly?

packages/files-ui/src/Components/Modules/LoginModule/InitialScreen.tsx Outdated Show resolved Hide resolved
@RyRy79261
Copy link
Contributor Author

@FSM1 Was a padding issue causing it to scrunch

@FSM1 FSM1 self-requested a review April 8, 2021 12:58
@FSM1 FSM1 merged commit 660c07e into dev Apr 8, 2021
@FSM1 FSM1 deleted the fix/mobile-spinner-893 branch April 8, 2021 12:58
@FSM1 FSM1 mentioned this pull request Apr 9, 2021
Merged
FSM1 added a commit that referenced this pull request Apr 12, 2021
@FSM1
Merge pull request #908 from ChainSafe/dev
0392f31 
Crash when going back after having selected Google auth #860 (PR #871)
Login optimizations (PR #879)
Minor fixes + Updates to color manipulator (#874)
Merge pull request #879 from ChainSafe/fix/login-optimizations
Merge pull request #887 from ChainSafe/fix/tbaut-hover-color
Merge pull request #886 from ChainSafe/feat/tkey-darkmode
Remove code duplication (#889)
Merge pull request #895 from ChainSafe/fix/select-all-892
Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890
Merge pull request #894 from ChainSafe/fix/mobile-spinner-893
Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846
folder validation (#899)
saved browsers settings (#865)
Prevent the whole app from rerendering every 5s (#909)
Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… …
Merge pull request #905 from ChainSafe/fix/bin-file-view-873 …
Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 …
Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-…
Fix: Search results all show as files (#914) …
Fix double click opening the next file preview (#915) …
Rename tooltip and fixes (#912) …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees

@RyRy79261 RyRy79261

Labels
Status: Review Needed 👀 Added to PRs when they need more review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web3 connecting mobile spinner is huge
3 participants
@RyRy79261 @FSM1 @Tbaut