Rename tooltip and fixes #912
Conversation
|
Your Render PR Server URL is https://chainsafex-dev-pr-912.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1pjli3s1gh5cdub0j80. |
|
Your Render PR Server URL is https://files-ui-dev-pr-912.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1pjlijs1gh5cdub0jdg. |
|
Your Render PR Server URL is https://files-landing-dev-pr-912.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1pjlirs1gh5cdub0k10. |
tanmoyAtb
added
the
Status: Review Needed 👀
| @@ -427,7 +431,7 @@ const FileSystemItemRow: React.FC<IFileSystemItemRowProps> = ({ | |||
| <TableCell | |||
| ref={preview} | |||
| align="left" | |||
| className={classes.filename} | |||
| className={clsx(classes.filename, editing && "editing")} | |||
There was a problem hiding this comment.
There is something wrong with this editing flag (certainly not from this PR, we can move this to another issue, just mentioning it here in case you know more). When I checked for it, I saw that all the rows actually get the .editing class, even the ones you're no editing. So in my example below, I have a long name for a folder. I edit a file (with a short name) and in the background, you can see the overflow visible, and the scrollbar:|
There was a problem hiding this comment.
I see, why thats happening. this can be fixed in this PR!
Great catch!
There was a problem hiding this comment.
As I suspected, having overflow in mobile view was root of the problem, also prevented editing styled to pass into all the rows.
Should be good now.
Thanks for getting to this!
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
tanmoyAtb
added
the
Status: Changes Requested ❌
tanmoyAtb
removed
the
Status: Changes Requested ❌
Crash when going back after having selected Google auth #860 (PR #871) Login optimizations (PR #879) Minor fixes + Updates to color manipulator (#874) Merge pull request #879 from ChainSafe/fix/login-optimizations Merge pull request #887 from ChainSafe/fix/tbaut-hover-color Merge pull request #886 from ChainSafe/feat/tkey-darkmode Remove code duplication (#889) Merge pull request #895 from ChainSafe/fix/select-all-892 Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890 Merge pull request #894 from ChainSafe/fix/mobile-spinner-893 Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846 folder validation (#899) saved browsers settings (#865) Prevent the whole app from rerendering every 5s (#909) Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… … Merge pull request #905 from ChainSafe/fix/bin-file-view-873 … Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 … Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-… Fix: Search results all show as files (#914) … Fix double click opening the next file preview (#915) … Rename tooltip and fixes (#912) …
closes #838