Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home button navigation #906

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Home button navigation #906

merged 1 commit into from
Apr 12, 2021

Conversation

tanmoyAtb
Copy link
Contributor

closes #885

Note: Clicking on Home button or the Home breadcrumb, reloads the "/" path content even if they are already there.
While this is fine for now, it may be logged as a new issue for when we refactor DriveContext.

@render
Copy link

render bot commented Apr 9, 2021

@render
Copy link

render bot commented Apr 9, 2021

@render
Copy link

render bot commented Apr 9, 2021

@tanmoyAtb tanmoyAtb self-assigned this Apr 9, 2021
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this will be refactored quite heavily probably during the course of this sprint

@FSM1 FSM1 merged commit db095c1 into dev Apr 12, 2021
@FSM1 FSM1 deleted the feat/home-folder-nav-885 branch April 12, 2021 11:52
FSM1 added a commit that referenced this pull request Apr 12, 2021
Crash when going back after having selected Google auth #860 (PR #871)
Login optimizations (PR #879)
Minor fixes + Updates to color manipulator (#874)
Merge pull request #879 from ChainSafe/fix/login-optimizations
Merge pull request #887 from ChainSafe/fix/tbaut-hover-color
Merge pull request #886 from ChainSafe/feat/tkey-darkmode
Remove code duplication (#889)
Merge pull request #895 from ChainSafe/fix/select-all-892
Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890
Merge pull request #894 from ChainSafe/fix/mobile-spinner-893
Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846
folder validation (#899)
saved browsers settings (#865)
Prevent the whole app from rerendering every 5s (#909)
Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… …
Merge pull request #905 from ChainSafe/fix/bin-file-view-873 …
Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 …
Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-…
Fix: Search results all show as files (#914) …
Fix double click opening the next file preview (#915) …
Rename tooltip and fixes (#912) …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking home folder icon when in sub-folder does nothing
4 participants