Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (24 February, 2019 - 3 March, 2019) #11577

Closed
weekly-digest bot opened this issue Mar 3, 2019 · 0 comments
Closed

Weekly Digest (24 February, 2019 - 3 March, 2019) #11577

weekly-digest bot opened this issue Mar 3, 2019 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Mar 3, 2019

Here's the Weekly Digest for PX4/Firmware:


ISSUES

Last week 43 issues were created.
Of these, 28 issues have been closed and 15 issues are still open.

OPEN ISSUES

💚 #11574 containers add Queue and testing, by dagar
💚 #11573 Enable convenient unit testing using googletest on POSIX, by MaEtUgR
💚 #11571 [DO NOT MERGE] move all drivers to new work queue, by dagar
💚 #11570 PX4 general work queue, by dagar
💚 #11568 Error while executing "make px4_sitl gazebo", by canberkgurel
💚 #11567 Unable to compile PX4 v1.8.2 on intel aero ready to fly done, by aomezzine
💚 #11565 simulator: fix to set system and component IDs as defined in params, by gamoreno
💚 #11564 Redefine Simulator::handle_message() prototype and create Simulator::set_publish() method., by mcsauder
💚 #11561 Smooth avoidance output, by mrivi
💚 #11558 VTOL return mode produces its own waypoint, by lingbuweibu
💚 #11551 Attitude glitches in velocity control, by bresch
💚 #11550 [WIP] Commander datalinks lost failsafe handing, by cmic0
💚 #11545 ekf2: Split static pressure correction into separate RH and LH ellipsoids, by priseborough
💚 #11540 Reintroduce slow down when landing manually, by MaEtUgR
💚 #11537 NuttX update to current master, by dagar

CLOSED ISSUES

❤️ #11575 Correct board-config PIN1/PIN0 typo in fmu-v5/src/board_config.h., by mcsauder
❤️ #11572 Format and edit a few comments in mavlink_receiver.h. - (Break apart PR#11274 into easily verifiable steps - Step 4) , by mcsauder
❤️ #11569 Pixhawk 4 and Pikhawk 4mini v5 not disarming., by Junkim3DR
❤️ #11566 Fix link to code style guide, by mortenfyhn
❤️ #11563 Master f7 stackcheck - result update stacks, by davids5
❤️ #11562 Standardize method definition newlines in mavlink_receiver.cpp - (Break apart PR#11274 into easily verifiable steps - Step 3) , by mcsauder
❤️ #11560 MC rate controller: do not disable integrators at min/max throttle, by bkueng
❤️ #11559 Jenkins hardware test temporarily disable px4_fmu-v5_stachcheck tests, by dagar
❤️ #11557 WIP: run all tests on all hardware, by dagar
❤️ #11556 create jlink gdb upload script and use in Jenkins Hardware pipeline, by dagar
❤️ #11555 [DO NOT MERGE] Jenkins hardware try running in parallel, by dagar
❤️ #11554 px4_fmu-v5 investigate stackcheck init hard fault, by dagar
❤️ #11553 Gazebo SITL simulation build fail in macOS, by feemi
❤️ #11552 Error make aerofc-v1_default on px4_atomic.h, by NLag
❤️ #11549 Re-add glitch-free position unlock, by bresch
❤️ #11548 Jenkins hardware test add px4_fmu-v2 and px4_fmu-v5, by dagar
❤️ #11547 WIP: Jenkins add more hardware, by dagar
❤️ #11546 Jenkins HIL test updates, by dagar
❤️ #11544 Wrong UDP Port when using -t argument, by hxdnshx
❤️ #11543 ManualSmoothVel - Split position lock condition and flag action, by bresch
❤️ #11542 Move variable initialization from constructor list to declarations, format whitespace in sf1xx.cpp., by mcsauder
❤️ #11541 Correted list of serial ports for lpe target for fmu v2 board, by fpvaspassion
❤️ #11539 List container updates and testing, by dagar
❤️ #11538 Avionics power only circuit breaker, by simonegu
❤️ #11536 Jenkins increase history retention, by dagar
❤️ #11535 FlightTasks minor coverity fixes, by dagar
❤️ #11534 Tools: fix style consistency in shell scripts "if [...]; then", by MaEtUgR
❤️ #11533 Makefile: streamline cmake-build & cleanup nuttx_, _default targets, by MaEtUgR

LIKED ISSUE

👍 #11573 Enable convenient unit testing using googletest on POSIX, by MaEtUgR
It received 👍 x0, 😄 x0, 🎉 x2 and ❤️ x0.

NOISY ISSUE

🔈 #11569 Pixhawk 4 and Pikhawk 4mini v5 not disarming., by Junkim3DR
It received 10 comments.


PULL REQUESTS

Last week, 66 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 35 pull requests were updated.
💛 #11574 containers add Queue and testing, by dagar
💛 #11571 [DO NOT MERGE] move all drivers to new work queue, by dagar
💛 #11570 PX4 general work queue, by dagar
💛 #11565 simulator: fix to set system and component IDs as defined in params, by gamoreno
💛 #11561 Smooth avoidance output, by mrivi
💛 #11550 [WIP] Commander datalinks lost failsafe handing, by cmic0
💛 #11545 ekf2: Split static pressure correction into separate RH and LH ellipsoids, by priseborough
💛 #11540 Reintroduce slow down when landing manually, by MaEtUgR
💛 #11525 [DO NOT MERGE]: posix shutdown investigation/hacks, by dagar
💛 #11518 [WIP]: PX4 platform layer, by dagar
💛 #11489 [WIP] uORB: add px4 work queue call back mechanism on publish, by dagar
💛 #11465 [WIP] Jenkins re-enable Catkin and Colcon builds, by dagar
💛 #11454 [WIP] HEARTBEAT and commander failsafe handling cleanup, by dagar
💛 #11400 simulator in hardware, new module, by romain-chiap
💛 #11382 VTOL: fix roll inversion, by jlecoeur
💛 #11373 FW position control add takeoff minimum pitch, by dagar
💛 #11357 Disable data link and RC loss reactions for SITL, by MaEtUgR
💛 #11351 [WIP Do not merge] NXP i.MXRT port of PX4 FMUv5, by davids5
💛 #11318 parameters metadata generate as single static constexpr header, by dagar
💛 #11308 Modularize Attitude Control, by MaEtUgR
💛 #11302 SPI: support for ISR and work_queue driven transfers, by dakejahl
💛 #11169 Introduce AutoManeuverSystem for BVLOS applications, by bresch
💛 #11092 EKF2: add usage to new exposed covariance, by TSC21
💛 #10912 [WIP] DO_CHANGE_SPEED work across LOITER, MISSION, RTL, by dagar
💛 #10883 weathervane: added configuration option via paramter, by RomanBapst
💛 #10780 Avoidance Interface CI, by mrivi
💛 #10733 Improve robustness to bad and lost airspeed data, by priseborough
💛 #10361 CI: unhide .ci directory, by bkueng
💛 #10288 mission:reset mission after finished, by jinchengde
💛 #10194 Accept onboard computer heartbeats as telemetry, by okalachev
💛 #9712 manual_control_setpoint split switches into new message manual_control_switches, by dagar
💛 #9659 AMOV-IMU codes for px4 1.8.0 rc0, by zarathustr
💛 #9473 [WIP] Telemetry status: report type and ID of remote system, by jlecoeur
💛 #7985 [WIP][do not merge] Add OBC datalink failsafe in parallel with GCS datalink failsafe, by TSC21
💛 #7432 [WIP] use local coordinates for position control (Global to local), by ChristophTobler

MERGED PULL REQUEST

Last week, 31 pull requests were merged.
💜 #11575 Correct board-config PIN1/PIN0 typo in fmu-v5/src/board_config.h., by mcsauder
💜 #11563 Master f7 stackcheck - result update stacks, by davids5
💜 #11562 Standardize method definition newlines in mavlink_receiver.cpp - (Break apart PR#11274 into easily verifiable steps - Step 3) , by mcsauder
💜 #11560 MC rate controller: do not disable integrators at min/max throttle, by bkueng
💜 #11559 Jenkins hardware test temporarily disable px4_fmu-v5_stachcheck tests, by dagar
💜 #11556 create jlink gdb upload script and use in Jenkins Hardware pipeline, by dagar
💜 #11549 Re-add glitch-free position unlock, by bresch
💜 #11548 Jenkins hardware test add px4_fmu-v2 and px4_fmu-v5, by dagar
💜 #11547 WIP: Jenkins add more hardware, by dagar
💜 #11546 Jenkins HIL test updates, by dagar
💜 #11543 ManualSmoothVel - Split position lock condition and flag action, by bresch
💜 #11542 Move variable initialization from constructor list to declarations, format whitespace in sf1xx.cpp., by mcsauder
💜 #11541 Correted list of serial ports for lpe target for fmu v2 board, by fpvaspassion
💜 #11539 List container updates and testing, by dagar
💜 #11536 Jenkins increase history retention, by dagar
💜 #11535 FlightTasks minor coverity fixes, by dagar
💜 #11534 Tools: fix style consistency in shell scripts "if [...]; then", by MaEtUgR
💜 #11533 Makefile: streamline cmake-build & cleanup nuttx_, _default targets, by MaEtUgR
💜 #11531 Feature: have the Mission Feasibility Checker check for a takeoff waypoint, by TSC21
💜 #11524 Fix ROI yaw wrapping, by MaEtUgR
💜 #11521 gpssim: populate s_variance_m_s with 0.25, by CarlOlsson
💜 #11519 Move most variable initializations out of the MavlinkReceiver constructor to the variable declarations - (Break apart PR#11274 into easily verifiable steps - Step 2) , by mcsauder
💜 #11517 navigator: Reset vehicle_roi before a mission, by potaito
💜 #11513 Rename Simulator class methods names to match convention in the class, by mcsauder
💜 #11511 mavlink/MavlinkReceiver: Use hrt_absolute_time for distance_sensor timestamps, by sfalexrog
💜 #11505 ADIS16497 Driver, by mhkabir
💜 #11499 Break apart handle_message() method into multiple handle_message_xxx() methods in simulator_mavlink.cpp…, by mcsauder
💜 #11482 Fx79 Frame: Reverse aileron outputs, by hamishwillee
💜 #11460 smooth takeoff - Support smooth takeoff triggered by jerk setpoint, by bresch
💜 #11444 Add Support for HW that indicates armed state., by davids5
💜 #11211 Fix Altitude Limitation, by MaEtUgR


COMMITS

Last week there were 53 commits.
🛠️ Correct board-config PIN1/PIN0 typo in fmu-v5/src/board_config.h. by mcsauder
🛠️ Standardize method definition newlines in mavlink_receiver.cpp. by mcsauder
🛠️ Revert "Jenkins hardware test temporarily disable px4_fmu-v5_stachcheck tests" This reverts commit 0df34af181ceb60a164b332d203a84f56c4da3bc. by davids5
🛠️ board:Set larger stack margin by davids5
🛠️ px4_fmuv5:Stack Check build Increase to 2624 The cause of the stack detection fault is because of the level of nesting in the start up script. We need to determine the worst case configuration and set the bar there. This fault occurred some 42 calls deep due to script calling script (repeat). The HW stack check requires as a margin of 204 bytes. That is ISR HW stacking of CPU(8) FPU(18) registers and SW stacking of CPU(11) and FPU(16) registers. Total CPU(19) registers is 68 bytes and the total FPU(34) registers is 136 bytes. On a system with a separate ISR stack This only needs to be 104 so there is 100 bytes of headroom. But as coded the detection will give a false positive detection and fault. This does not mean that the stack will be corrupted. Adjustments to that stack can have no effect due to rounding. A stack size of 2608 and 2616 can yield the exact same size stack. So even when the failure is due to a 4 byte overflow, it can take greater than a 16 bytes increase to fix it. Because the final stack size is calculated with an 8 byte alignment after a 4 byte decrease. So 2624 becomes 2620 at runtime and will boot with SYS_AUTOSTART=4001. by davids5
🛠️ List container improvements and testing - support range based for loops - add remove() method to remove a node - add clear() to empty entire list and delete nodes - add empty() helper by dagar
🛠️ mc airframes: reduce I gains a bit A side-effect of the previous commit is that the integral is loaded up during a flip, which leads to visible bounce-backs after a flip. Reducing the I helps, but there's a trade-off and we'll need a better solution. by bkueng
🛠️ fix mixer multicopter: do not clip for max/min throttle Except for the lower end with disabled airmode. Otherwise the rate controller would disable the integrals, which can lead to severe tracking loss in acro. It is noticeable when flying in FPV, e.g. simply when throttling straight up. Relevant part in the rate controller: https://github.com/PX4/Firmware/blob/master/src/modules/mc_att_control/mc_att_control_main.cpp#L702 by bkueng
🛠️ mc_pos_control_main - Re-add updateVelocityControllerIO for glitch-free position unlock by bresch
🛠️ Rename Simulator class private methods names to match snake case of other private class methods. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_HIL_STATE_QUATERNION content and paste into handle_message_hil_state_quaternion() method. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_HIL_OPTICAL_FLOW content and paste into handle_message_hil_optical_flow() method. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_DISTANCE_SENSOR content and paste into handle_message_distance_sensor() method. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_LANDING_TARGET content and paste into handle_message_landing_target() method. by mcsauder
🛠️ Jenkins hardware test temporarily disable px4_fmu-v5_stachcheck tests by dagar
🛠️ create jlink gdb upload script and use in Jenkins Hardware pipeline by dagar
🛠️ navigator: mission_feasibility_checker: remove lazy comparison by TSC21
🛠️ navigator: mission feasibility checker: minor cleanup by TSC21
🛠️ mission_feasibility_checker: takeoff: fix init of mission item by TSC21
🛠️ mission_feasibility_checker: takeoff: add a different log message when there's a takeoff item but it's not the first waypoint by TSC21
🛠️ mission_feasibility_checker: takeoff: minor spelling mistakes fixing by TSC21
🛠️ mission_feasibility_checker: takeoff: fix logic to return as valid by TSC21
🛠️ mission_feasibility_checker: takeoff: accept mission when takeoff is not the first item but the previous items are not waypoints by TSC21
🛠️ mission_feasibility_checker: takeoff: change warning message by TSC21
🛠️ navigator: mission feasibility checker: check for a takeoff waypoint on mission on specific conditions by TSC21
🛠️ Jenkins hardware test add px4_fmu-v2 and px4_fmu-v5 by dagar
🛠️ Jenkins hardware test add px4_fmu-v3 and px4_fmu-v4pro by dagar
🛠️ Jenkins hardware testing update to new configuration - the Jenkins slave now has the gdb server already started in the background by dagar
🛠️ fmuv5:Repurpose TIM5_SPARE_4 as nARMED nARMED is a Digital OUTPUT. GPIO will be set as input while not armed HW will have Pull UP. While armed it will be configured as a GPIO OUT set LOW. by davids5
🛠️ Commander:Support BOARD_INDICATE_ARMED_STATE for HW that supports external armed indiction by davids5
🛠️ board_common:Add BOARD_INDICATE_ARMED_STATE This adds an optional default support for HW that does not have and external armed indiction. by davids5
🛠️ Mavlink receiver: Move most variable initializations out of the constructor to the variable declarations by mcsauder
🛠️ Makefile: add function to check if cmake rerun is necessary by comparing the configuration options that cmake reports from the cache with the ones from the current build by MaEtUgR
🛠️ Makefile: help cleanup by MaEtUgR
🛠️ Makefile: streamline cmake-build and cleanup nuttx_, _default targets by MaEtUgR
🛠️ Move member variable initialization out of the constructor list to variable declarations, format whitespaces/tabs in sf1xx.cpp. by mcsauder
🛠️ ManualSmoothVel - Split position lock condition and flag action by bresch
🛠️ mc_pos_control: fix altitude limitation Before if you were above the maximum altitude you could not command to go down anymore until the position controller had overshoot to under the maximum altitude again. by MaEtUgR
🛠️ vmount: add missing yaw wrap at the end of a ROI update by MaEtUgR
🛠️ vmount: refactor ROI position update for readability by MaEtUgR
🛠️ Correted list of serial ports for lpe target for fmu v2 board by fpvaspassion
🛠️ Analog Device ADIS16497 IMU initial support by mhkabir
🛠️ navigator: reset vehicle_roi on mission update by potaito
🛠️ mavlink/MavlinkReceiver: Use hrt_absolute_time for distance_sensor timestamps by sfalexrog
🛠️ Flying Wing init files: Fix up main output docs by hamishwillee
🛠️ Fx79 Frame: Reverse aileron outputs by hamishwillee
🛠️ smooth takeoff - Support smooth takeoff triggered by jerk setpoint by bresch
🛠️ FlightTasks VelocitySmoothing initialize member - fixes Coverity CID 328485 by dagar
🛠️ FlightTasks AutoLineSmoothVel initialize member - fixes Coverity CID 328492 by dagar
🛠️ FlightTasks ManualPositionSmoothVel initialize member - fixes Coverity CID 332544 by dagar
🛠️ Jenkins increase history retention by dagar
🛠️ gpssim: populate s_variance_m_s with 0.25 (#11521) Signed-off-by: CarlOlsson carlolsson.co@gmail.com by CarlOlsson
🛠️ Tools: fix style consistency in shell scripts "if [...]; then" by MaEtUgR


CONTRIBUTORS

Last week there were 13 contributors.
👤 mcsauder
👤 davids5
👤 dagar
👤 bkueng
👤 bresch
👤 TSC21
👤 MaEtUgR
👤 fpvaspassion
👤 mhkabir
👤 potaito
👤 sfalexrog
👤 hamishwillee
👤 CarlOlsson


STARGAZERS

Last week there were 19 stagazers.
hanzheteng
enebubbz14
cyberpunk2099
leonmkim
Polarbeargo
ianmclinden
Lafon2
ThujaOccidentalis
MakingL
mrober09
soonhooi
wrd90
Freebreeze
isidroas
lrobot
Catflying
kjproj84
idoria75
ragymorkos
You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please 👀 Watch and Star the repository PX4/Firmware to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant