-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client/grpc): node.NewQueryServer
method not setting cfg
#20969
Conversation
WalkthroughWalkthroughThe recent changes enhance the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
client/grpc/node/service_test.go (1)
15-17
: Ensure consistency in configuration value types.The configuration values for
PruningKeepRecent
andPruningInterval
are set as strings, whileHaltHeight
is set as an integer. This inconsistency might lead to potential type errors or misconfigurations in other parts of the application that use these configurations.
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- client/grpc/node/service.go (1 hunks)
- client/grpc/node/service_test.go (1 hunks)
Additional context used
Path-based instructions (3)
client/grpc/node/service_test.go (2)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go
: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"client/grpc/node/service.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.CHANGELOG.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Additional comments not posted (3)
client/grpc/node/service_test.go (1)
25-26
: Approve updated unit tests for new configuration parameters.The unit tests have been correctly updated to check the new configuration parameters against expected values, ensuring that the
queryServer
struct is properly initialized and functional.client/grpc/node/service.go (1)
35-35
: Confirm the correct initialization of thecfg
field.The
cfg
field has been correctly added to thequeryServer
struct and is initialized properly in theNewQueryServer
function. This ensures that the server's configuration is maintained throughout its lifecycle.CHANGELOG.md (1)
118-118
: Changelog Entry ReviewThe changelog entry correctly references the PR and describes the fix applied. The link to the PR is valid and provides additional context.
) (cherry picked from commit 2d5983c)
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Bug Fixes
Tests