-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testutil/integration): allow to pass baseapp options #21816
Conversation
WalkthroughWalkthroughThe pull request introduces several enhancements across multiple modules in the codebase. Key changes include improved error messages for genesis validation in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
53-54
: Minor inconsistency in abbreviationsThe release notes are very well structured and detailed. One small inconsistency is the use of both "applications" and "apps". Consider standardizing on one or the other for clarity.
Overall the categorization, descriptions and PR links make these excellent release notes!
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- testutil/integration/router.go (2 hunks)
Additional context used
Path-based instructions (2)
CHANGELOG.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"testutil/integration/router.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (2)
testutil/integration/router.go (1)
58-58
: LGTM!The addition of the variadic parameter
baseAppOptions
to theNewIntegrationApp
function and its usage in thebaseapp.NewBaseApp
constructor enhances the flexibility of creating aBaseApp
instance for testing purposes. This change allows users to customize the behavior of theBaseApp
without modifying the core logic of the application.The change is backward compatible and provides more flexibility to the users of the function.
Also applies to: 67-67
CHANGELOG.md (1)
Line range hint
1-1253
: Excellent changelog overallThis is an exemplary changelog for a large project. The structure, categorization, and links back to PRs are all helpful for users and contributors.
Aside from the small inconsistency in abbreviations mentioned above, this is a thorough and well-maintained record of changes. Great work!
(cherry picked from commit bdda21f) # Conflicts: # CHANGELOG.md
(cherry picked from commit bdda21f) # Conflicts: # CHANGELOG.md # testutil/integration/router.go
Description
Extending the integration app with custom handlers wasn't possible before.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
genutil
module.sims2
framework and factory methods in thesims
module for easier message factory creation.NewIntegrationApp
with additional baseapp options for improved flexibility.Improvements