Register derived from (resolve merge conflicts) #301

burrbull · 2019-06-01T10:41:30Z

No description provided.

Also added `--list` to show what test cases would have been run using the current filters

errors

Also implements an alternate way to choose toolchain

The enums are just values so this should do no harm, and it helps building interfaces around the peripherals that do validation or otherwise pass those values around. Closes: rust-embedded#135

It only makes sense to export interrupt if the interrupt! macro is exported as well, since it's the only thing using it.

261: Only export Interrupt as interrupt when 'rt' is enabled r=japaric a=rnestler It only makes sense to export interrupt if the interrupt! macro is exported as well, since it's the only thing using it. Fixes rust-embedded#260 Co-authored-by: Raphael Nestler <raphael.nestler@gmail.com>

nightly

…for latest" This reverts commit 15064a9.

Escape brackets on all description doc strings

265: Consistent svd2rust output r=japaric a=jamesmunns NOTE: I believe there is still documentation that will need to be updated to represent this. I wanted to make sure my CI changes still work without the other changes (like Cargo.toml) after pulling these changes Co-authored-by: James Munns <james.munns@ferrous-systems.com>

this commit: - fixes cortex-m version in documentation (v0.5.x is the latest available version) - updates docs to note that svd2rust writes generated code to lib.rs for all targets - updates the CHANGELOG

v0.14.0

this removes the Linux GNU targets used to produce binaries but we still have the MUSL builds which will work everywhere because they statically linked binaries

297: CI: use Cargo instead of Cross r=therealprof a=japaric this removes the Linux GNU targets used to produce binaries but we still have the MUSL builds which will work everywhere because they statically linked binaries Co-authored-by: Jorge Aparicio <jorge@japaric.io>

…links Add missing release tags links

293: Fix rustc warnings. r=therealprof a=bjc This just removes two rustc warnings about an unused `mut` and redundant `use`. Co-authored-by: Brian Cully <bjc@kublai.com>

@wez

221: Improve ci r=therealprof a=Emilgardis This pr includes - Support for the changes done in v0.13 - `--toolchain foo` to specify what toolchain to build the chips with (makes building locally easier, no need to rebuild `svd2rust-regress`) - Add support for `--chip XXX YYY` - Added validators to chip, manufacturer and architecture - `-vv` will now output all stderr logs - Added `--list` to quickly troubleshoot what test cases will be run - A patched ATSAMD21G18A svd, thanks to @wez ## Open "issues" - Should we ignore case when filtering? - Should a `--chip XXX` always run even if it is set to only run on `--long-test` (and possibly `--bad-test`) - Add a `--` command to pass arguments to `svd2rust` and possibly also a way to pass arguments to `cargo check` - Colorize output - Add regress:beta test to gitlab-runner - Move test cases to a or multiple config file(s) (e.g json/toml/yaml) cc @jamesmunns Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com> Co-authored-by: Vadim Kaushan <admin@disasm.info>

If svd2rust fails its always useful to get some information about the where and why

Co-Authored-By: Daniel Egger <daniel@eggers-club.de>

295: Add support for 64-bit registers r=therealprof a=Disasm Some registers on K210 chip are 64-bit, so it's better to declare them as u64 in SVD for the reasons mentioned here: riscv-rust/k210-pac#1 (comment) At the moment, svd2rust forbids 64-bit register declarations. This PR fixes this. This change can cause silent bugs on platforms without 64-bit memory access operations due to the need for proper access sequence to 64-bit registers with two 32-bit accesses. Closes rust-embedded#289 Co-authored-by: Vadim Kaushan <admin@disasm.info>

281: Edition-2018-ify svd2rust r=ryankurte a=therealprof Signed-off-by: Daniel Egger <daniel@eggers-club.de> Co-authored-by: Daniel Egger <daniel@eggers-club.de>

298: Added RUST_BACKTRACE=1 to enable backtraces r=ryankurte a=therealprof If svd2rust fails its always useful to get some information about the where and why Co-authored-by: Daniel Egger <daniel@eggers-club.de>

238: Remove debug assert from Peripherals::steal r=therealprof a=thenewwazoo Very simple PR! :) This permits actually-unsafe use of the steal method, and avoids divergent behavior between debug and release modes. Co-authored-by: Brandon Matthews <bmatthews@zipcar.com>

…to register-derived-from

rust-highfive · 2019-06-01T10:41:33Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive · 2019-06-01T10:41:34Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against register-derived-from. Please double check that you specified the right target!

Emilgardis · 2019-06-01T11:43:33Z

bors try

EDIT:: oh yeah, no ci setup for that branch ofc.

this looks good to me, I don't particularly like merge commits however

Emilgardis

looks good, minor nit about merge commit, but unsure if that's even unavoidable with prs

burrbull · 2019-06-01T11:50:51Z

burrbull · 2019-06-01T11:57:25Z

Compare with master:

Emilgardis · 2019-06-01T21:01:55Z

thank you, merging 👍

bors · 2019-06-08T12:39:15Z

try

Merge conflict

Emilgardis and others added 30 commits May 16, 2018 19:02

Added proper ATSAMD21G18A file, with alternateGroup already patched in

e9ba96d

Made chip a vec and added validators

4583956

Implemented more verbose logs

a02a3d6

Also added `--list` to show what test cases would have been run using the current filters

Added way to pass --nightly to svd2rust and changed logic for showing

d616795

errors

Changed validation error messages and added a "no tests run" message

d0fa4c6

Add nightly flag to gitlab runner

50e846a

Change the way -vv works, doesn't allocate all the time anymore

d6a1f53

Update to be compatible with v0.13.0

82d2fc5

Also implements an alternate way to choose toolchain

Fix -vv* not showing full output on fails

0b03132

Derive common traits for write enums like for read enums

e69f477

The enums are just values so this should do no harm, and it helps building interfaces around the peripherals that do validation or otherwise pass those values around. Closes: rust-embedded#135

Remove debug assert from Peripherals::steal

efd3d93

Only export Interrupt as interrupt when 'rt' is enabled

93b6081

It only makes sense to export interrupt if the interrupt! macro is exported as well, since it's the only thing using it.

Remove private_no_mangle_static directives in generated code for latest

15064a9

nightly

Escape brackets on descriptions for bit fields too

712eb8a

Escape brackets on enum variants.

f6a8402

Add missing escape_brackets

1558880

Add another missing escape_brackets

8301b12

Revert "Remove private_no_mangle_static directives in generated code …

b53bbc7

…for latest" This reverts commit 15064a9.

Merge pull request rust-embedded#263 from craigjb/escape_brackets

56ad812

Escape brackets on all description doc strings

Extract just the consistent output of generated code

87ab5af

Revert change from tokens to items

f0d42a2

v0.14.0

389c4f5

this commit: - fixes cortex-m version in documentation (v0.5.x is the latest available version) - updates docs to note that svd2rust writes generated code to lib.rs for all targets - updates the CHANGELOG

Merge pull request rust-embedded#266 from rust-embedded/release

45aa702

v0.14.0

Provide library access to code generation

0f72f01

add build_rs to Generation struct

9e56759

Allow building on 1.31 (stable)

4c8adf5

Segregate device specific generation to its own struct

477531b

ci: remove rustfmt for speed

f799496

japaric and others added 16 commits May 21, 2019 20:49

CI: use Cargo instead of Cross

61a7aa6

this removes the Linux GNU targets used to produce binaries but we still have the MUSL builds which will work everywhere because they statically linked binaries

install rust-std component

7a3651e

drop the musl builds

10d2ef9

Merge pull request rust-embedded#286 from rust-embedded/release-tags-…

16c00cc

…links Add missing release tags links

Merge rust-embedded#293

1e456c1

293: Fix rustc warnings. r=therealprof a=bjc This just removes two rustc warnings about an unused `mut` and redundant `use`. Co-authored-by: Brian Cully <bjc@kublai.com>

Added RUST_BACKTRACE=1 to enable backtraces

24b861d

If svd2rust fails its always useful to get some information about the where and why

Add test with 64-bit registers

de3a621

Update ci/script.sh

6dc10b8

Co-Authored-By: Daniel Egger <daniel@eggers-club.de>

Merge rust-embedded#281

20d8bd4

281: Edition-2018-ify svd2rust r=ryankurte a=therealprof Signed-off-by: Daniel Egger <daniel@eggers-club.de> Co-authored-by: Daniel Egger <daniel@eggers-club.de>

Merge rust-embedded#298

2f237d0

298: Added RUST_BACKTRACE=1 to enable backtraces r=ryankurte a=therealprof If svd2rust fails its always useful to get some information about the where and why Co-authored-by: Daniel Egger <daniel@eggers-club.de>

Merge branch 'master' of https://github.com/rust-embedded/svd2rust in…

70c885b

…to register-derived-from

rm ref

b7965db

burrbull requested a review from a team as a code owner June 1, 2019 10:41

rust-highfive assigned Emilgardis Jun 1, 2019

rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jun 1, 2019

Emilgardis approved these changes Jun 1, 2019

View reviewed changes

Emilgardis merged commit e76f2c2 into rust-embedded:register-derived-from Jun 1, 2019

burrbull deleted the register-derived-from branch July 12, 2019 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Register derived from (resolve merge conflicts) #301

Register derived from (resolve merge conflicts) #301

burrbull commented Jun 1, 2019

rust-highfive commented Jun 1, 2019

rust-highfive commented Jun 1, 2019

Emilgardis commented Jun 1, 2019 •

edited

Loading

Emilgardis left a comment

burrbull commented Jun 1, 2019

burrbull commented Jun 1, 2019

Emilgardis commented Jun 1, 2019

bors bot commented Jun 8, 2019

Register derived from (resolve merge conflicts) #301

Register derived from (resolve merge conflicts) #301

Conversation

burrbull commented Jun 1, 2019

rust-highfive commented Jun 1, 2019

rust-highfive commented Jun 1, 2019

Emilgardis commented Jun 1, 2019 • edited Loading

Emilgardis left a comment

Choose a reason for hiding this comment

burrbull commented Jun 1, 2019

burrbull commented Jun 1, 2019

Emilgardis commented Jun 1, 2019

bors bot commented Jun 8, 2019

try

Merge conflict

Emilgardis commented Jun 1, 2019 •

edited

Loading