Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add search bar to errors #18

Closed

Conversation

sorenlouv
Copy link
Owner

Depends on #17
Related to: elastic#127036

mykolaharmash and others added 30 commits January 3, 2024 14:13
Fixes elastic#167484

Updates the [asset tracking
tutorial](https://www.elastic.co/guide/en/kibana/current/asset-tracking-tutorial.html)
with the following improvements:

* From elastic#167484, @Danouchka contributed improvements to the way the
Elasticsearch assets are defined to work with Elastic Agent
* Moved some content to use the Kibana Console to generate assets,
instead of going through all the UI elements
* Updated references to the data that tracks not only Portland buses but
also trains and light trains
* Replaces the alert to use the Index connector
* Adds a new section on visualizing the alerts
* Images updated to Kibana 8.11 UI
…#173453)

## Summary

Just a small Doc Update. In the first example a POST was used and
towards a non existing handle (`_security` instead of `security`)

In the basic license example posted below this one, this is already
correct.

### Checklist

All checked - none applied. 
(Though first PR in this repository, I am sorry if any mistakes were
made. If so - please point them out, will do better next time 😅 )

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…rm (elastic#174016)

## Summary

Closes elastic#173654

Adds an option to create a new anomaly detection job from the job
selector control.

<img width="614" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/1dc19cb9-b7e5-471c-9dec-3018103efb69">

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
- Resolves elastic#168856

## Summary

As per comment in
elastic#171572 (comment)

> As a simple way to mitigate this issue, what if we changed it so that
on hover/focus of a field list item we fade-out the token and fade-in
the drag handle to replace the token (in the same position)? In doing
so, we could also keep the old translate x-axis transition (where the
field list item slides a few pixels to the right) to emphasize that it's
draggable. That little bit of extra movement might be good, if the
appearance of the drag handle is no longer pushing the text (given the
above suggestion).

![Dec-19-2023
18-13-21](https://github.com/elastic/kibana/assets/1415710/e02cb7d6-ce1a-4507-a8a6-3004f89d7225)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…173810)

## Summary

Expose QueryStringInput via plugin contract this will make sure deps are
handled by the component itself.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes elastic#167648

PR adds "ES|QL" card to "Add Layer" interface. Creates a layer renders
an ES|QL statement on the map

<img width="250" alt="Screenshot 2023-12-16 at 2 03 04 PM"
src="https://github.com/elastic/kibana/assets/373691/4d1e24f6-405b-4016-8e6f-4736742c6166">

<img width="800" alt="Screenshot 2023-12-16 at 1 54 24 PM"
src="https://github.com/elastic/kibana/assets/373691/8387551f-c3b5-4b15-84eb-aef18254d371">

### Known limitations
This PR is intended to be a first start and does not cover all
functionality. The following list identifies known limitations that will
have to be resolved in future work.
1. tooltips - Existing documents source supports lazy loading tooltips
to avoid pulling unused data on map render. How would this look for
ES|QL? Should tooltips only support local data?
2. ES|QL layer does not surface data view to unified search bar so
search type-ahead and filter bar will not show index-pattern fields from
ES|QL layer.
3. ES|QL layer does not surface geoField. This affects control for
drawing filters on map.
4. ES|QL layer does not support pulling field meta from Elasticsearch.
Instead, data-driven styling uses ranges from local data set. This will
be tricky as we can't just pull field ranges from index-pattern. Also
need to account for WHERE clause and other edge cases.
5. fit to bounds

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
## Summary

Adding "third party" to E5 ML model description as per legal
requirements.

<img width="1372" alt="Screenshot 2024-01-03 at 09 11 25"
src="https://github.com/elastic/kibana/assets/14224983/29522e9a-d532-45da-93bd-efed6a1090eb">
<img width="960" alt="Screenshot 2024-01-03 at 09 12 04"
src="https://github.com/elastic/kibana/assets/14224983/1e5c2128-7111-4bdf-b1a5-8fe89b450a4e">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
## Summary

Upgrades `lmdb` from v2.6.9 to v2.9.2, and `msgpackr` from v1.7.2 to
v1.10.1.
RHEL 8.10 will be the final ubi8 release. We already have builds in
place for transitioning to ubi9.

Depends on elastic#170264.
## Summary

It will show all the associated configs at one place in json form,
configuration, ingest pipeline config, roll up transform and summary
transform config !!

Motivation is to understand things while onboarding devs to slo and
during normal development.



https://github.com/elastic/kibana/assets/3505601/a22ad292-ba59-4145-989e-80803b6a1e3e
…tistics/Data Visualizer (elastic#174050)

## Summary

This PR fixes elastic#173734 where the
clicking to filter a boolean value is searching as numeric
representation instead of the true boolean values.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Resolves elastic#172158

## Summary

- Adds AI assistant buttons to Logs Explorer header
- Adds separators to group related buttons

## Screenshots

### Classic

<img width="1341" alt="Screenshot 2023-12-20 at 17 45 15"
src="https://github.com/elastic/kibana/assets/190132/bc9dfd09-ee32-4306-8629-39cb6b70e6ed">

### Serverless

<img width="1338" alt="Screenshot 2023-12-20 at 17 36 22"
src="https://github.com/elastic/kibana/assets/190132/a6c164ef-c9f3-490d-8c84-7d1d1bb80cb3">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This is logging outdated warnings on 7.17. Opening with a main target to
backport a consistent version.
Resolves elastic#172518

## Summary

Updates the retry delay calculation to cap the delay at 1hr and
introduces jitter.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


### To verify
- Create a rule and then force a retry failure
- Verify that the retry follows the pattern below:

  Attempt 1: now
  Attempt 2: 30s after the first attempt
  Attempt 3: 0 - 5m after the second attempt
  Attempt 4: 0 - 10m after the third attempt
  Attempt 5: 0 - 20m after the fourth attempt
  Attempt 6: 0 - 40m after the fifth attempt
  Attempt n: 0 - 1hr for all other attempts
Adds a pipeline for a daily SonarQube scan.


https://buildkite.com/elastic/kibana-bot-sonarqube/builds/7#018ca703-4b56-4a56-b6ce-ae6630cd81e3
(ignore the pipeline name/slug, that was a copy paste error. I'll fix it
after)
…ic#173989)

## Summary

This adds default error toast messages to all API calls in the
Serverless Elasticsearch plugin, and provides some ways to skip or
modify the toasts.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary

Part of elastic#173529

Adapt theme access based on `uiSettings.get('theme:darkMode')` with the
correct approach of using `core.theme` or the `useDarkMode` react hook.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…enu (elastic#174183)

## Summary

`Panel Settings` action is not compatible with Security Solution
([bug](elastic#168670)), removing them
in this PR.

Steps to verify:
1. Visit network / hosts / users / rules / alerts page
2. Find a visualization rendered with Lens Embeddable
3. Click on `...`, and find `Panel settings` should not exist

![Screenshot 2024-01-03 at 22 41
51](https://github.com/elastic/kibana/assets/6295984/f97866a4-0d97-42f5-94d1-46e1b4f3395e)



- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
…astic#172819)

## Summary

Fixes elastic#168445

We follow the approach:
1. if we can render we are able to save even with errors
2. If we cannot render, we cannot save

There are 3 cases we have to think when approaching this task. 

1. When the error comes from the request (for example, incorrect KQL in
'filter by' or wrong response from ES)
We don't catch those cases in Lens app so I didn't fix it here either.
It would be very difficult to do so.

2. When the chart cannot be rendered
(whether there's a missing dimension or errors stop the expression to be
generated)
<img width="524" alt="Screenshot 2023-10-16 at 13 30 32"
src="https://github.com/elastic/kibana/assets/4283304/9ecafcd8-7a70-45b8-babe-ca65bc1e4903">

3. When the chart has errors but can be rendered
We allow saving in this case.

<img width="381" alt="Screenshot 2023-10-17 at 15 02 47"
src="https://github.com/elastic/kibana/assets/4283304/d2358ef7-d7b7-4cbf-8532-0caa60d73008">

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
…aggregation (elastic#173898)

Closes elastic#173396

## Summary

This PR removes disabling missing group settings when aggregation is
document count because it also works as expected for this case. ([more
info](elastic#173396 (comment)))

<img
src="https://github.com/elastic/kibana/assets/12370520/d5b974cf-e18d-4d34-82ff-3891f57e719d"
width=500 />
Refactors according to this
[comment](elastic#172498 (comment))

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
janmonschke and others added 28 commits January 11, 2024 21:24
## Summary

Unskips the fullscreen timeline tests.

Looking at the issue described in
elastic#172547, it appears that the
timeline was somehow not opening correctly in some cases. This flakiness
has been removed in elastic#173413, so it
should be possible to unskip these tests.

In addition to unskipping the tests, an unnecessary task execution was
removed and two force clicks were cleaned up.

[Flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4834)
(200/200)

fixes elastic#172547
elastic#174123)

## Summary

Add technical preview to the S1 Host isolation flyout

<img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 02 35"
src="https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306">

<img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 17 58"
src="https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb">
## Fix enrichments cypress tests

[Related PR with removing
ILM](elastic#167916) as it not supported
in serverless. Here the
[error](https://buildkite.com/elastic/kibana-pull-request/builds/179121)
in the CI related to that

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…hars (elastic#174676)

## Summary

Add support for automatic quoting on autocomplete. Added tests.


![esql_quote_special_fields](https://github.com/elastic/kibana/assets/924948/c74d2535-5ff5-42fe-9ec8-285fc4818a3c)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@sorenlouv sorenlouv force-pushed the add-search-bar-to-errors branch from eb25d17 to 64e94ea Compare January 12, 2024 11:33
@sorenlouv sorenlouv closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.