This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Queue RPCs by Worker_EntityId * Apply suggestions from code review Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Changed Worker_EntityId to Worker_EntityId_Key for Linux compilation. Fixed function signature * Moved initialisation inside if statements
* Warnings fix * Removed bad file
* Fixed potential bad states and check for GEditor * Made notificaitons safe * Remove uneeded IsValid * Grab module dynamically * Remove pragma * Made GetProjectName safer and restart spatial service on every project start * Updated changelog * Better logging for 'not available' project file * Removed preventing start local deployment if the we suspect the spatial service is in the wrong project * Always try to stop the service
* Cross-server RPCs should now be properly handled. RPCs for destroyed objects might not be queued * Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialReceiver.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
… worker type (#1151) * Only pack RPCs that are destined for the owning worker type of the connection (PlayerController). * Add new method to ActorGroupManager for checking 2 actors are owned by the same worker type
…tor (#1153) * Fixed a crash that may happen if rpcs are sent to tornoff actor * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp Co-Authored-By: Matt Young <matthewyoung@improbable.io>
Preserve URL options on ClientTravel
* Now only client and multicast RPCs can be sent on entity creation from the server * Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialSender.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Added CrossServer RPC warning
* WIP * Removed references to unreliable when packing rpcs
* Add max net cull distance * Add warning * Add disable setting and changelog
* Add IsReplayConnection func * Apply suggestions from code review * Update EngineVersionCheck.h * Updated engine version * Update SpatialGDK/Source/SpatialGDK/Public/EngineClasses/SpatialNetConnection.h
…bat for local launch outside of editor (#1178) * Making sure the script for local editor gets set correctly. * Change string.format to string interpolation for clarity. * Adding info to the changelog.
* Added config for not auto starting local deployment on play. Updated log and notification for redeploy required. * Updated changelog * Rename variable * Updated property name * Fixed schema gen causing infinite local deployment restarts
* Add pinned spatial version * Added static version
* Cleanup dynamic objects on entity removal * PR feedback
* Use weak pointer in UnrealMetadata * Add log for stale classes
* When launching worker, create logs directory to prevent the native server launch script failing
* Added control flow for callbacks only be triggered for the right commands on external schema generated code.
…omewhere in the outer chain. (#1217)
* fixing compatibility * update Setup.sh and Build solution * disabling deployment manager for MacOS * remove whitelisting * whitespacing * removed whitespace in uplugin
* Update editor & runtime settings tooltips
* Revert macos build setup changes * Increment requiresetup
* Reuse subobbject schema names * Cleanup * Remove comment * Switch check to error message * Update SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp Co-Authored-By: Matt Young <matthewyoung@improbable.io> * update error message
* Add warning messages about loading stale classes * Compile BEFORE pushing * Cleaned up messages * Don't force load stably named objects * Update SpatialGDK/Source/SpatialGDK/Public/Schema/UnrealMetadata.h * Add comment
* fix for deserializing fields to clear, and wrapping batch magic in quotes
* Initial AlwaysRelevant support * Add id checks * PR feedback
* Add header image, fix links * Header image * Simpler name * simpilfy * latest not alpha
* Update CHANGELOG.md * feature/upgrade-to-13.8.1 * feature/UNR-1303-namespace-rename * break up this mad paragraph long release note * /pull/1190 * pull/930 * Update CHANGELOG.md * Update CHANGELOG.md * fix typo: dureing * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Apply suggestions from code review * Mention RPC tracking * Fix engine branch names * Update CHANGELOG.md * Adjusted the 4.20 support note * Update CHANGELOG.md * Update CHANGELOG.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
improbable-valy
requested review from
joshuahuburn,
m-samiec,
aleximprobable and
a team
July 31, 2019 15:00
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
labels
Jul 31, 2019
joshuahuburn
approved these changes
Jul 31, 2019
m-samiec
approved these changes
Jul 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Merge the changes which were merged into the RC back into master.
Primary reviewers
@m-samiec @joshuahuburn