Skip to content

v6.23.0

Compare
Choose a tag to compare
@cservakt cservakt released this 08 Dec 21:36
· 364 commits to master since this release
bea15d4

🌟 Highlights

GCC Static Analyzer support

We are happy to announce that CodeChecker added native support for the GCC Static Analyzer! This analyzer checks code in the C family of languages, but its latest release at the time of writing is still best used only on C code. Despite it being a bit immature for C++, we did some internal surveys where the GCC Static Analyzer seemed to be promising.

We expect this analyzer to be slower than clang-tidy, but faster than the Clang Static Analyzer. You can enable it by adding --analyzers gcc to your CodeChecker check or CodeChecker analyze commands. For further configuration, check out the GCC Static Analyzer configuration page.

GNU GCC 13.0.0. (the minimum version we support) can be tricky to obtain and to make CodeChecker use it, as CodeChecker looks for the g++ binary, not g++-13. As a workaround, you can set the environmental variable CC_ANALYZER_BIN which will make CodeChecker use the given analyzer path (e.g. CC_ANALYZER_BIN="gcc:/usr/bin/g++-13"). You can use CodeChecker analyzers to check whether you have the correct binary configured.

You can enable gcc checkers by explicitly mentioning them at the analyze command e.g.

CodeChecker analyze -e gcc

gcc checkers are only added to the exterme profile. After evaluation, some checkers may be added to other profiles too.

Under the same breath, we added partial support for the SARIF file format (as opposed to using plists) to report-converter, with greater support planned for future releases.

Review status config file

In previous CodeChecker versions, you could set the review status of a report using two methods: using in-source comments, or setting a review status rule in the GUI. The former sets the specific report's review status, the latter sets all matching reports' review status.

This release introduces a third way, a review status config file! One of the motivations behind this is that we wanted to have a way to set review statuses on reports in specific directories (which was not possible on the GUI). CodeChecker uses a YAML config file that can be set during analysis:

$version: 1
rules:
  - filters:
      filepath: /path/to/project/test/*
      checker_name: core.DivideZero
    actions:
      review_status: intentional
      reason: Division by zero in test files is automatically intentional.

  - filters:
      filepath: /path/to/project/important/module/*
    actions:
      review_status: confirmed
      reason: All reports in this module should be investigated.

  - filters:
      filepath: "*/project/test/*"
    actions:
      review_status: suppress
      reason: If a filter starts with asterix, then it should be quoted due to YAML format.

  - filters:
      report_hash: b85851b34789e35c6acfa1a4aaf65382
    actions:
      review_status: false_positive
      reason: This report is false positive.

This is how you can use this config file for an analysis:

CodeChecker analyze compile_commands.json --review-status-config review_status.yaml -o reports

The config file allows for a great variety of ways to match a report and set its review status. For further details see this documentation.

Enable/disable status of checkers

In this release the unknown Checker status has been eliminated. CodeChecker will enable only those checkers that are either present in the default profile (see CodeChecker checkers --profile default) or enabled using the --enable argument (through another profile or explicitly through a checker name).

In previous CodeChecker versions, when you ran an analysis, we assigned three states to every checker: it's either enabled, disabled, or neither (unknown). We kept the third state around to give some leeway for the analyzers to decide which checkers to enable or disable, usually to manage their checker dependencies. We now see that this behavior can be (and usually is) confusing, party because it's hard to tell which checkers were actually enabled.

You can list the checkers enabled by default using the CodeChecker checkers command:

CodeChecker 6.22.0 output:
 
CodedeChecker checkers |grep clang-diagnostic-varargs -A7
clang-diagnostic-varargs
  --> Status: unknown <---
  Analyzer: clang-tidy
  Description:
  Labels:
    doc_url:https://clang.llvm.org/docs/DiagnosticsReference.html#wvarargs
    severity:MEDIUM
 
=>
CodeChecker 6.23.0 output:
 
CodeChecker checkers |grep clang-diagnostic-varargs -A7
clang-diagnostic-varargs
  ---> Status: disabled <---
  Analyzer: clang-tidy
  Description:
  Labels:
    doc_url:https://clang.llvm.org/docs/DiagnosticsReference.html#wvarargs
    severity:MEDIUM

Major fixes to run/tag comparisons (diff)

Following a thorough survey, we identified numerous areas to improve on our run/tag comparisons. We landed several patches to improve the results of diffs both on the CLI and the web GUI (which should be almost always identical). Despite that this feature has the appearance of a simple set operation, diff is a powerful tool that can express a lot of properties on the state of your codebase, and has a few intricacies. For this reason, we also greatly improved our docs around it.

A detailed description of the issues are described in this ticket: #3884

One example is that the if the suppression was removed for a finding, the diff did not show the reappearing result as new (in local/local diff):

// Code version 1:
void c() {
  int i = 0; // deadstore, this value is never read
  // codechecker_suppress [all] SUPPRESS ALL
  i = 5;
}


// Code version 2 (suppression removed):

void c() {
  int i = 0; // deadstore, this value is never read
  i = 5;
}

CodeChecker diff -b version1.c -n version2.c --new 
Did not show the deadstore finding as new.

Web GUI improvements

We landed several patches to improve the readability and usability of the GUI, with more improvements to come in later releases! The currently selected event's visual highlight pops a little more now in the report view, and we no longer show unused columns in the run view.

In this image, you can see how much the selected event "pops" after this release, and also, how other events' opacity was a lowered a bit, which allows arrows to be seen through them.
image

  1. In the report detail page, outstanding and closed issues are clearly organized into a left tree view. So it will be easier to see which report needs more attention (fixing or triaging).

image

Report limit for storing to the server

Especially in the case of clang-tidy, we have observed some unreasonable number of reports by certain checkers. In some instances, we saw hundreds of thousands (!) of reports reported by some individual checkers, and its more than unlikely that anyone will inspect these reports individually (you probably got the message about using parantheses around macros after the first 15 000 reports).

We found that these checkers were usually enabled by mistake, and put unnecessary strain both on the storage of results to the server, and on the database once stored. Moving forward, CodeChecker servers will reject stores of runs that have more than 500 000 reports. This limit is a default value that you can change or even set to unlimited. Our intent is not to discourage legitemately huge stores, only those that are whose size is likely this large by mistake.

When creating a new product called My product at endpoint myproduct, you can set the report limit from the CLI with the following invocation:

CodeChecker cmd products add -n "My product" --report-limit 1000000 myproduct

For an already existing product, you can change the limit by clicking the pencil at the products page:
image
image

❗ Backward incompatible changes

  • [analyzer] Promote the missing analyzer warning to an error #3997
    • If analyzers are specified with --analyzers flag and one of them is missing, CodeChecker now emits an error.
    • Previously, the user could only specify the analyzers without version number e.g.: CodeChecker analyze compile_commands.json -o reports --analyzers clangsa
    • Now, you can also validate the analyzer's version number e.g.: CodeChecker analyze compile_commands.json -o reports --analyzers clangsa==14.0.0
    • In both cases, if a wrong analyzer was given, the system exit would trigger.

--all and --details were deprecated for CodeChecker analyzers

With the introduction of the GCC Static Analyzer, we think that the --all flag was more confusing than useful -- its a reasonable assumption that any system will have a version of GCC available. The default behaviour prior to this release was to only list analyzers that were available for analysis: the binary was found, met the version criteria, and was functional. The --all flag listed all supported analyzers, even if they were not available. We changed the default behaviour to always list all supported checkers, and --all is ignored. We emit helpful warnings for analyzers that CodeChecker supports, but can't analyze with.

--details could be used to print additional version information of the binary, but we didn't feel like it provided any value above what the non-detailed query gave, and it was impossible to pretty print. After this release, this flag will also be ignored.

🐛 Analyzer improvements

  • Replaced the multiprocessing library with multiprocess. This resolved issues in multiprocess library usage on different platforms but mostly on OSX. Added in #4076
  • Fixing a crash when CC_ANALYZERS_FROM_PATH env variable is set in #4084
  • Corrected a bug about the --enable-all flag not disabling specific warnings in #4080 by @bruntib
  • Fixed non-determinism in the appearance of clang-tidy checkers.
  • Prevented duplicate addition of extra arguments in cppcheck.
  • Resolved an issue with the AnalyzerContext lazy initialization.
  • [fix] Recognize -pthread for gcc compile commands #3969
  • [bugfix] Allow the disabling of statisticsbased checkers #3972
  • [bugfix] Include platform to ldlogger.so path #3976
  • [analyzer] Ignore another unknown gcc options #4028
  • [report-converter] Support sarif format and Gcc analyzer #4011
  • Gcc analyzer native support #4030
  • [clang-tidy] Fix Clang tidy checker option output #4050
  • [analyzer] Add support the CC_ANALYZER_BIN env var #4057

💻 CLI/Server improvements

  • [fix] An error was fixed when loading the report in the report view that caused the review status dropdown menu's value to fail to update when switching to a report with a different status. Fixed in in #4082 by @cservakt
  • Eliminate "unknown" checker state #3949
  • [bugfix] Don't trigger analyzer without enabled checkers #3970
  • [fix] Refine when a report is regarded as outstanding for tags #3995
  • [cmd] Fix FP annotations in the case of local-remote diffs #3956
  • [diff] Fix a CLI remote-remote bug where we checked the detection status #3996
  • [cmd][diff] Ignore detection status for tags #4013
  • [gui] Update run filter when setting the filter options #3963
  • replace os.uname() with platform.uname() for Windows support #4012
  • [feat] Introduce review status config file #4054
  • [fix][clang-tidy] Fix env var replace for extra args #4033
  • [enhancement] --cppcheckargs flag was missing #3978
  • feat(store): Explicitly time the client out if the connection hung #4039
  • [server] Rate limit based on report count #3843
  • [analyzers] Deprecate --all and --details for analyzers #4056
  • Parse file speed up #4000

🌳 Environment

  • [req] Upgrade PyYAML to 6.0.1 #3961
  • [test] Fix package test #3965
  • [check actions] setting GITHUB_TOKEN permissions to read #3983
  • Create SECURITY.md #3990
  • [db] Eliminating duplicate key constraint violations #3712
  • Bump gitpython from 3.1.30 to 3.1.32 in /web #3987
  • Bump gitpython from 3.1.30 to 3.1.32 in /web/requirements_py/dev #3985
  • Bump cryptography from 3.3.2 to 41.0.3 in /web/requirements_py/dev #3986
  • Bump minimist from 1.2.5 to 1.2.8 in /web/server/vue-cli #3993
  • Bump word-wrap from 1.2.3 to 1.2.5 in /web/server/vue-cli #3988
  • Bump webpack from 5.66.0 to 5.76.0 in /web/server/vue-cli #3991
  • Bump json5 from 1.0.1 to 1.0.2 in /web/server/vue-cli #3992
  • Bump qs from 6.5.2 to 6.5.3 in /web/server/vue-cli #3998
  • Bump loader-utils from 1.2.3 to 1.4.2 in /web/server/vue-cli #3999
  • Bump gitpython from 3.1.32 to 3.1.34 in /web/requirements_py/dev #4005
  • Bump gitpython from 3.1.32 to 3.1.34 in /web #4004
  • Bump cryptography from 41.0.3 to 41.0.4 in /web/requirements_py/dev #4015
  • Bump gitpython from 3.1.34 to 3.1.35 in /web #4016
  • Bump gitpython from 3.1.34 to 3.1.35 in /web/requirements_py/dev #4017

📖 Documentation updates

  • The issue with building ReadTheDocs has been rectified. You can view the latest docs here: https://codechecker.readthedocs.io/en/latest/
    In addition, we have implemented modifications to the PyPI action in order for a more reliable package publishing by @vodorok
  • Add more checks from clang-tidy #3959
  • [config] Add some checkers to "default" profile #3971
  • Document new clang-tidy checkers #4024
  • chore(config): Add labels for new checks of Clang SA & Tidy #4051
  • fix typo: 'hte' to 'the' #3960

🔨 Other

  • [docs] Leave a better TODO for gcc docs by @Szelethus in #4069
  • chore(store): Give a name to the timeout watchdog thread by @whisperity in #407
  • Bump @babel/traverse from 7.16.8 to 7.23.2 in /web/server/vue-cli by @dependabot in #4043
  • Bump gitpython from 3.1.35 to 3.1.37 in /web/requirements_py/dev by @dependabot in #4038
  • Bump gitpython from 3.1.35 to 3.1.37 in /web by @dependabot in #4037
  • [version] Bump up to version 6.23.0 #3893
  • [logger] + add missing header fcntl.h #3958
  • [GUI] Change the selected bubble's brightness #3981
  • [test] Add several more cmdline tests for tag diffs #3979
  • [bugfix] Make None assignments to be initializations, not overwrites #4001
  • [GUI] Jump directly to documentation url without error modal #3974
  • [GUI] Unnecessary reports columns #4014
  • [gui] Retain filter configuration between reports and statistics views #4058
  • [fix] Fix commentCount related error in gui #4034
  • Making an analyze and parse testcase checker set independent #4045
  • Fix typo in log #4023

Full Changelog: v6.22.2...v6.23.0