feat: filter dashboards by dashboard roles #12407

amitmiran137 · 2021-01-11T11:25:23Z

SUMMARY

a poc demonstrating for dashboard level access

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov-io · 2021-01-11T12:32:38Z

Codecov Report

Merging #12407 (d9a9c2c) into master (f13f2e2) will decrease coverage by 15.93%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #12407       +/-   ##
===========================================
- Coverage   66.88%   50.94%   -15.94%     
===========================================
  Files        1014      473      -541     
  Lines       49528    16864    -32664     
  Branches     5074     4339      -735     
===========================================
- Hits        33125     8591    -24534     
+ Misses      16273     8273     -8000     
+ Partials      130        0      -130

Flag	Coverage Δ
cypress	`50.94% <ø> (+0.01%)`	⬆️
javascript	`?`
python	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js	`0.00% <0.00%> (-100.00%)`	⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js	`0.00% <0.00%> (-100.00%)`	⬇️
...dashboard/components/resizable/ResizableHandle.jsx	`0.00% <0.00%> (-100.00%)`	⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js	`0.00% <0.00%> (-93.48%)`	⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx	`11.76% <0.00%> (-88.24%)`	⬇️
...src/dashboard/components/gridComponents/Header.jsx	`10.52% <0.00%> (-86.85%)`	⬇️
superset-frontend/src/components/IconTooltip.tsx	`13.33% <0.00%> (-86.67%)`	⬇️
...rc/dashboard/components/gridComponents/Divider.jsx	`13.33% <0.00%> (-86.67%)`	⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx	`8.00% <0.00%> (-84.00%)`	⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx	`14.70% <0.00%> (-82.97%)`	⬇️
... and 866 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13f2e2...d9a9c2c. Read the comment docs.

…ml and helm values.yaml (apache#12337)

* chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback

* fix(explore): long metric name display * add tooltip to control

* add birth names fixture * fix birth names related tests * fix test_import_v0_dataset_cli_export columns order * fix celery tests drop table * fix mysql datetime type * fix mysql typo in charts/api_tests * refactor * add licence * fix use fixture for presto * fix presto, hive query * fix flaky metadata * fix mysql bigint type * fix run query * fix hive datatype in metadata * fix slice owner for cypress * refactor num_boys num_girls * fix is_dttm column * debug logging * fix query offset * fix presto ds type in metadata * fix presto ds type * clean up debug logging

…pache#12232) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.1 to 1.19.4. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.1...v1.19.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: remove additional incubator references remove incubator.png from the main docs page * fix: improve text for contributing-page.mdx * fix: lint no-unused-vars

* fix styles and add angolia search classes * add class * fix black

* fix(api): prefix class names on events actions * fix bulk delete

…2411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io>

Apply capitalization guidelines defined in apache#12343 Use sentence casing for most places.

apache#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier

* fix: import ZIP files that have been modified * Add unit test

* feat: new Slack dashboard * Add ASL license * Fix test

…2478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for apache#11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* feat(db-engine-specs): add support for Postgres root cert * remove logging of json decode exception message * fix error message * fix error message

* fix: make pyparsing thread safe * remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test

* fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>

* add world bank data fixture * fix fixture cleanup, add fixture to dashboard_tests * apply world bank fixtures, fix tests * fix fixture typo, dashboard ids * fix export dashboard metadata * fix test_export_dashboard_command_key_order * fix export dash tests, not add row when no orphans * debug timeout * fixes after merge * fix lint * run pre-commit * comment test for debug * fix save.test.js Co-authored-by: Karol Kostrzewa <karol.kostrzewa@polidea.com>

…rdingly (apache#12405) * chore: remove duplicate DashboardFilter class and change imports accordingly * fix: pre-commit isort issue

draft: filter dashboards by dashboard roles

d9a9c2c

pull-request-size bot added the size/M label Jan 11, 2021

amitmiran137 and others added 27 commits January 14, 2021 21:35

chore: rename docker image in build_docker_image.sh, docker-compose.y…

16473c9

…ml and helm values.yaml (apache#12337)

chore: change Datasource to Dataset in Explore ui (apache#12402)

2c69ad8

* chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback

chore: upgrade eslint, babel, and prettier (apache#12393)

c5ddd5a

fix(explore): long metric name display (apache#12387)

2e2552d

* fix(explore): long metric name display * add tooltip to control

feat(explore): add tooltip to timepicker label (apache#12401)

64d37c1

docs: reword and cleanup docs for local dev server (apache#11869)

f18a226

chore: remove additional incubator references (apache#12336)

404bd0b

* chore: remove additional incubator references remove incubator.png from the main docs page * fix: improve text for contributing-page.mdx * fix: lint no-unused-vars

[explore] Prevent duplicated query by data table (apache#12404)

8334093

fix: Refresh Interval Modal dropdown (apache#12406)

fb9e9d8

chore: Show datasets when search input is empty (apache#12391)

503fc2b

docs: fix styles and add algolia search classes (apache#12267)

27cde37

* fix styles and add angolia search classes * add class * fix black

refactor: from superset.utils.core break down date_parser (apache#12408)

6821c70

Fixes control panel fields styling (apache#12236) (apache#12326)

bc9d713

fix(native-filters): incorrect queriesData state (apache#12409)

d77098a

fix(api): prefix class names on events actions (apache#12354)

85cf65e

* fix(api): prefix class names on events actions * fix bulk delete

fix: update savedatasetmodal message (apache#12433)

e52ee7c

fix(explore): fixed table header in chrome (apache#12432)

28adeed

bump superset-ui packages for rolling window change (apache#12426)

ddce527

feat: Resizable dataset and controls panels on Explore view (apache#1…

99cc3ae

…2411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io>

chore: apply capitalization guidelines - iteration 1 (apache#12447)

b6091c2

Apply capitalization guidelines defined in apache#12343 Use sentence casing for most places.

fix(dashboard): artefacts shown while drag and dropping deck.gl charts (

def2914

apache#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier

fix: import ZIP files that have been modified (apache#12425)

b83bf58

* fix: import ZIP files that have been modified * Add unit test

feat: new Slack dashboard (apache#12415)

2904d50

* feat: new Slack dashboard * Add ASL license * Fix test

fix: do not show vertical scrollbar for charts in dashboard (apache#1…

0547146

…2478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for apache#11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

ktmud and others added 17 commits January 14, 2021 21:35

build: add cancel-workflow-runs action locally (apache#12394)

3b081cd

Fix uneven list header padding (apache#12029) (apache#12412)

c2bcd09

chore: bump superset-ui deckgl plugin (apache#12466)

17fa72a

fix(releasing): svn dockerfile requirements path (apache#12461)

9954d05

feat(db-engine-specs): add support for Postgres root cert (apache#11720)

e273d17

* feat(db-engine-specs): add support for Postgres root cert * remove logging of json decode exception message * fix error message * fix error message

fix(timepicker): make pyparsing thread safe (apache#12489)

6c10372

* fix: make pyparsing thread safe * remove parenthesis for decorator

fix(dashboard): use datasource id from slice metadata (apache#12483)

55ae8d7

fix (SQL Lab): disappearing results on tab switch (apache#12472)

c3f5552

* fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test

fix: styling for change dataset confirmation (apache#12471)

de08fad

fix: impose dataset ownership check on old API (apache#12491)

bf0ebfa

* fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update

remove crontab guru link (apache#12467)

50310c8

keep modal open on error, utilize useEffect (apache#12360)

3e870b9

Add owner field to the alerts list (apache#12420)

ebcbba5

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>

Fix list filters vertical alignment (apache#12497)

7a9ea03

chore: remove duplicate DashboardFilter class and change imports acco…

64a22f0

…rdingly (apache#12405) * chore: remove duplicate DashboardFilter class and change imports accordingly * fix: pre-commit isort issue

refactor: move to specific dashboard_roles table

bfcc1ee

amitmiran137 closed this Jan 14, 2021

amitmiran137 deleted the feat/dashboard_access_rbac branch January 14, 2021 19:44

Renganayaki1 mentioned this pull request Feb 3, 2021

Giving access based on Dashboards instead of Datasources. #12910

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: filter dashboards by dashboard roles #12407

feat: filter dashboards by dashboard roles #12407

amitmiran137 commented Jan 11, 2021 •

edited

Loading

codecov-io commented Jan 11, 2021 •

edited

Loading

feat: filter dashboards by dashboard roles #12407

feat: filter dashboards by dashboard roles #12407

Conversation

amitmiran137 commented Jan 11, 2021 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov-io commented Jan 11, 2021 • edited Loading

Codecov Report

amitmiran137 commented Jan 11, 2021 •

edited

Loading

codecov-io commented Jan 11, 2021 •

edited

Loading