Feature/appeals 34965 demo #22265

#21170)

* remove unused route and fix typo * standardize prop names * use standardized prop names * use standardized prop names and abstract magic strings * remove unnecessary scoping * CorrespondenceIntakeTask status in_progress on create * update spec for changes * update helper to reflect workflow * correspondence intake task status in progress on creation * efolder upload failed task no longer needs task url since its not displayed on the table * rubocop style fix * rubocop fix extra blank line

* Fix Code Climate Issues * Improve Code - Add class comments to service files. - Add underscores to unused method params in the fake BGS Service. * Fix Bad Method Invocation * Fix Param Causing Spec Failures

* Fix Code Climate Issues * Improve Code - Add class comments to service files. - Add underscores to unused method params in the fake BGS Service. * Fix Bad Method Invocation * Fix Param Causing Spec Failures * Make BGS Service Method Static - This will allow the other static methods to use the init_client_params method.

* adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

* modified to show error in date filter * modified datecomplete * change name in header * fix style issue * Fix spec file * Add new test in spec file

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* sorting query for date completed column on correspondence tables * optimize task query for your correspondence completed tab * optimize task query for corresepondence cases completed tab * update correspondence task filter for new column name * add name props to avoid console errors * correct prop types * update with new column name * update seeds to reflect expected workflow * update broken tests * remove unnecessarily bloated test case setup * update broken test expectation

* Fix Code Climate Issues * Improve Code - Add class comments to service files. - Add underscores to unused method params in the fake BGS Service. * Fix Bad Method Invocation * Fix Param Causing Spec Failures * Make BGS Service Method Static - This will allow the other static methods to use the init_client_params method. * Fix Misc. UAT Issues - Handle errors raised by the BGS service. - Update the auto assign status ping to include the correct assigned count. - Fix bug that caused CorrespondenceAutoAssignRunVerifier to incorrectly report that runs are OK. * Fix Incorrect Field Checked for Run Verification

…21202) * mostly finished modal * added conditional rendering of textarea * updated RadioField name * added redux setup for selected veteran details. * added RadioFieldWithChildren component. * Added complete modal for reassign * stored veteran details on click * added diasbled button logic for confirm * wired button for remove package task. * Wired banner message prototype * fixed crash * task now reassigns properly * implemented failure banner and reject option * fixed banner messages. * fixed sizing issue and added textarea to reject * fixed frontend css * improved backend logic. * fixed modal closing X button * fixed error in method call, commented data changing code * backbone for reassign and remove modal tests * added parent_task_url * Implemented taskurl for remove/ reassign task * delete binding pry * tests suite for correspondence cases * refactored logic * data seeding and minor refactors * fix test suit * uncommented experimental code * added remove modal * cleaned up controller logic * final AC work in progress * Fixes for linting and update reviewpackagetask error * futher reduced code climate issues * mode code climate fixes * fixed more code climate issues * fixed linting errors. fixed submit disable logic * refined logic for cleaner user experience * added seed data for reassign / remove package task * fixed bug on buildMailUserData * swapped mismatched messages * finished spec tests * Hot fix to remove Intake from Veterans Details (#21087) * fix feature test * Revert "fix feature test" This reverts commit 948d637. * pushing up tests for ryan to run * feature tests * remove Intake from Veteran Details * resolve pr conflicts --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Khalin/appeals 35818 - Bug Fix (#21091) * WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec * The completed tab now showing dates * Bug Fix * created completed_by_date and added business logic to root task (#21103) * APPEALS-35488: Update UAT Seed Scripts for Correspondence (#21129) * refactored correspondence seeds to accept vet and user. refactored create_correspondence. * refactored seed to create intake correspondence with upload failed task * updated seed to create correspondence with intake task * refactored rest of queue correspondence seed to be able to accept a user and veteran. * lowered count for correspondence seeds * refactored multi_correspondences to create review package tasks, handle user input, and use queue helpers * disabled linting check * added multi correspondence and queue correspondence seeds to rake task * cleaned up correspondence rake to be more DRY * Khalin/appeals 35818 Date Completed Column Filtering Bug Fix (#21134) * WIP for new seeds file * Updated query so data shows in table * Revert "WIP for new seeds file" This reverts commit ea1dd11. * Updated query so data shows in table * Your Correspondence completed tab completed test spec * The completed tab now showing dates * Bug Fix * Date Completed Filtering Fixed * Updated changes * Fixing Failing test --------- Co-authored-by: Jim Foley <james.foley4@va.gov> * updated completed filter to filter on closed_at value (#21166) * Edit VA DOR access for InboundOpsTeamAdmin user (#21150) * 🔀 jcroteau/APPEALS-38492 - Fix duplicate results from joins on certain AR associations (#21097) * refactored seed scripts for correspondence to have more detailed notes (#21170) * Wmedders21/appeals 41493 (#21162) * remove unused route and fix typo * standardize prop names * use standardized prop names * use standardized prop names and abstract magic strings * remove unnecessary scoping * CorrespondenceIntakeTask status in_progress on create * update spec for changes * update helper to reflect workflow * correspondence intake task status in progress on creation * efolder upload failed task no longer needs task url since its not displayed on the table * rubocop style fix * rubocop fix extra blank line * updated props to new branch props * sanitized string with react * fixed missing end in queue_correspondence * sanitize newUrl attempt #2 * fixed buildMailUserData * added missing end statement * fixed linting * modified per github feedback * refactored redundant code * linting fix. refactored correspondence_controller logic * linting fix * partial refactor with code migrated to correspondence_controller_util * refactored a very large amount of code to the CorrespondenceControlletUtil * Justin/APPEALS-42009 (#21118) * adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov> * Piedram/appeals 41494 (#21196) * modified to show error in date filter * modified datecomplete * change name in header * fix style issue * Fix spec file * Add new test in spec file * Error banner now working as intended (#21206) Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * added comment * Justin/APPEALS-42009 (#21118) * adding correspondence intake controller * moving methods that seem to be suited for the intake-specific controller * refactor conditional * updating the routes * Updating the remainder of intake routes * removing a repeated method found * moving intake specs to new intake controller spec * fixing file for failing tests * Fixing failing specs --------- Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: Jim Foley <james.foley4@va.gov> * Piedram/appeals 41494 (#21196) * modified to show error in date filter * modified datecomplete * change name in header * fix style issue * Fix spec file * Add new test in spec file * Wmedders21/appeals 42552 (#21209) * sorting query for date completed column on correspondence tables * optimize task query for your correspondence completed tab * optimize task query for corresepondence cases completed tab * update correspondence task filter for new column name * add name props to avoid console errors * correct prop types * update with new column name * update seeds to reflect expected workflow * update broken tests * remove unnecessarily bloated test case setup * update broken test expectation * updated linting * fixed linting issues --------- Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: William Medders <medders_william@bah.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com>

* Initial commit for search bar * Search bar chnages and removed post request * Modified the search results display * Removed unused code * Removed searchValue from unnecessary places * Search results on page load * APPEALS-38964 - Search criteria for all columns * moved search logic from table builder into queue table * Removed unused method * Made the changes back for tabPaginationOptions * Remove Console Log * Feature test cases for Search bar * Added few more feature test cases for Search bar * Added pagination spec * Failing spec * Added few more test cases * APPEALS-38964 - Additioanl RSpec tests, Fixed page visits * Edit VA DOR access for InboundOpsTeamAdmin user (#21150) * 🔀 jcroteau/APPEALS-38492 - Fix duplicate results from joins on certain AR associations (#21097) * refactored seed scripts for correspondence to have more detailed notes (#21170) * Modified the test spec for sorted by veteran details * APPEALS-38964 - Updated Flaky Test * APPEALS-38964 - Notes Update * Added serializer for few more columns * Added serializer for label and closed_at columns * APPEALS-38964 - Linting, Assigned_By * Sort and pagination column fix * Removed logic for sort and pagination fix * Modified column_names with self class in all the tab class * DRY all the tabs * Extra Linting and Test Updates * Can able to search with number * Updates for tabs and linting * Linting * fix for completed date serializer * Reverting Conditional for VetDetails and VADOR --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…umn (#21228) * fixed select column appearing in superuser table * linting fixes * fixed linter issues * fixed merge conflicts --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* prevent overwriting correspondence uuid on page load * provide saved redux store to view if the intake form has been previously worked * Update test expectations * Merge with feature

* fixed missing text * updated instructions text * added instructions to action required tasks --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…1542-34964-32900

* Initial commit for Optimize Correspondence Table Queries * Removed instance variable --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* fix for filter value VADOR and Date Completed * fix selected filter --------- Co-authored-by: piedram <maite.piedrayera@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

… Logs the Correspondence Explain Page (Test Environments) (#21290) * APPEALS-42721 - Under Construction rerouting * APPEALS-42721 - Explain Page Route Fix * Add to App Controller * APPEALS-42721 - Working Right-Click Explain Linking * Linting and Cleanup * Update correspondence_task_column_serializer.rb * Update correspondence_task_column_serializer.rb * Route * APPEALS-42721 - Update Spec Pathing for Correspondence Explain --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

#21312) Co-authored-by: Jim Foley <james.foley4@va.gov>

…21302) Co-authored-by: Jim Foley <james.foley4@va.gov>

* updated correspondence table * run correspondence nod column migration * Add nod value to seed helper for correspondence queue * semi functional nod column * Add package doc type filter options to constants file * Add column title to constants file * remove binding.pry * add filtering logic for package doc type * Add search logic for package doc type * Update package doc type column for filtering and searching * rollback nod migration * added feature test for package document type column * fixed several receipt date failures * test fixes * update selectors for specs to account for new column * fixed several failing rspecs * reverted taskCompletedDateColumn to master version * fixed failing rspecs * removed stray binding.pry * fied linting issues * fixed linting issue * removed binding.pry * fixed ordering of assigned columns --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: Jim Foley <james.foley4@va.gov>

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Move Auto Assign Button to Correspondence Queue * Fix Lint Errors

…1542-34964-32900

…inally merged in on #21295

* Move Auto Assign Button to Correspondence Queue (#21324) * Move Auto Assign Button to Correspondence Queue * Fix Lint Errors * Include RunAsyncable --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Move Auto Assign Button to Correspondence Queue (#21324) * Move Auto Assign Button to Correspondence Queue * Fix Lint Errors * Include RunAsyncable * Fix Broken Task Factories --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

#21329) * replaced correspondences_appeals with correspondence_appeal * added safe indecies to new correspondence_appeals table * updated correspondence_appeal namespace --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* Moving the queue method to a new controller * updating routing to the queue controller * Creating a spec file but leaving it empty for future changes * added a test for the correspondence_cases route --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* changed contents of correspondence seed notes (#21259)  Resolves [Jira Issue Title](https://jira.devops.va.gov/browse/JIRA-12345) # Description Please explain the changes you made here. ## Acceptance Criteria - [ ] Code compiles correctly ## Testing Plan  1. Go to [Jira Issue/Test Plan Link](https://jira.devops.va.gov/browse/JIRA-12345) or list them below - [ ] For feature branches merging into master: Was this deployed to UAT? # Frontend ## User Facing Changes - [ ] Screenshots of UI changes added to PR & Original Issue BEFORE|AFTER ---|--- ## Storybook Story *For Frontend (Presentation) Components* * [ ] Add a [Storybook](https://github.com/department-of-veterans-affairs/caseflow/wiki/Documenting-React-Components-with-Storybook) file alongside the component file (e.g. create `MyComponent.stories.js` alongside `MyComponent.jsx`) * [ ] Give it a title that reflects the component's location within the overall Caseflow hierarchy * [ ] Write a separate story (within the same file) for each discrete variation of the component # Backend ## Database Changes *Only for Schema Changes* * [ ] Add typical timestamps (`created_at`, `updated_at`) for new tables * [ ] Update column comments; include a "PII" prefix to indicate definite or potential [PII data content](https://github.com/department-of-veterans-affairs/appeals-team/blob/master/caseflow-team/0-how-we-work/pii-handbook.md#what-is-pii) * [ ] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`) (see [Writing DB migrations](https://github.com/department-of-veterans-affairs/caseflow/wiki/Writing-DB-migrations)) * [ ] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method)) * [ ] Perform query profiling (eyeball Rails log, check bullet and fasterer output) * [ ] For queries using raw sql was an explain plan run by System Team * [ ] Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes) * [ ] Run `make check-fks`; add any missing foreign keys or add to `config/initializers/immigrant.rb` (see [Record associations and Foreign Keys](https://github.com/department-of-veterans-affairs/caseflow/wiki/Record-associations-and-Foreign-Keys)) * [ ] Add `belongs_to` for associations to enable the [schema diagrams](https://department-of-veterans-affairs.github.io/caseflow/task_trees/schema/schema_diagrams) to be automatically updated * [ ] Document any non-obvious semantics or logic useful for interpreting database data at [Caseflow Data Model and Dictionary](https://github.com/department-of-veterans-affairs/caseflow/wiki/Caseflow-Data-Model-and-Dictionary) ## Integrations: Adding endpoints for external APIs * [ ] Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo * [ ] Request: Service name, method name, input field names * [ ] Response: Check expected data structure * [ ] Check that calls are wrapped in MetricService record block * [ ] Check that all configuration is coming from ENV variables * [ ] Listed all new ENV variables in description * [ ] Worked with or notified System Team that new ENV variables need to be set * [ ] Update Fakes * [ ] For feature branches: Was this tested in Caseflow UAT # Best practices ## Code Documentation Updates - [ ] Add or update code comments at the top of the class, module, and/or component. ## Tests ### Test Coverage Did you include any test coverage for your code? Check below: - [ ] RSpec - [ ] Jest - [ ] Other ### Code Climate Your code does not add any new code climate offenses? If so why? - [ ] No new code climate issues added ## Monitoring, Logging, Auditing, Error, and Exception Handling Checklist ### Monitoring - [ ] Are performance metrics (e.g., response time, throughput) being tracked? - [ ] Are key application components monitored (e.g., database, cache, queues)? - [ ] Is there a system in place for setting up alerts based on performance thresholds? ### Logging - [ ] Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? - [ ] Are logs structured (e.g., using log tags) for easier querying and analysis? - [ ] Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs? - [ ] Is log retention and rotation configured correctly? - [ ] Are logs being forwarded to a centralized logging system if needed? ### Auditing - [ ] Are user actions being logged for audit purposes? - [ ] Are changes to critical data being tracked ? - [ ] Are logs being securely stored and protected from tampering or exposing protected data? ### Error Handling - [ ] Are errors being caught and handled gracefully? - [ ] Are appropriate error messages being displayed to users? - [ ] Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)? - [ ] Are unhandled exceptions being caught at the application level ? ### Exception Handling - [ ] Are custom exceptions defined and used where appropriate? - [ ] Is exception handling consistent throughout the codebase? - [ ] Are exceptions logged with relevant context and stack trace information? - [ ] Are exceptions being grouped and categorized for easier analysis and resolution? * WIP * Working as intended * Spec tests * Added instructions to modal * Linting Errors * Addressing comments --------- Co-authored-by: Jim Foley <james.foley4@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* refactored props being passed down to child components * refactored permissions checks for reassign and remove package tasks * removed unecessary router useage * addressed name change concerns for supervisor/superuser to be more in line with correspondence workflow

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…1542-34964-32900

…/github.com/department-of-veterans-affairs/caseflow into integration/APPEALS-27311-31542-34964-32900

Co-authored-by: Jim Foley <james.foley4@va.gov>

* Reset BGS Service * Add New Sensitivity Check Method - Create new method in BGSService for checking participant sensitivity using the BGS gem. - Update auto assign logic to use new method for checking sensitivity for user/veteran pairs. * Fix Lint Error * Update Sensitivity Check Logic - Use new method in BGS gem for checking user sensitivity levels. - Update specs and supporting files accordingly.

* Move Auto Assign Button to Correspondence Queue (#21324) * Move Auto Assign Button to Correspondence Queue * Fix Lint Errors * Reset BGS Service (#21352) * Use New BGS Gem Sensitivity Check Methods (#21356) * Reset BGS Service * Add New Sensitivity Check Method - Create new method in BGSService for checking participant sensitivity using the BGS gem. - Update auto assign logic to use new method for checking sensitivity for user/veteran pairs. * Fix Lint Error * Update Sensitivity Check Logic - Use new method in BGS gem for checking user sensitivity levels. - Update specs and supporting files accordingly. --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>

* Initial commit for UI/UX changes * Added the existing caseflow search properties * Updated the checkboxes style fix * Changes for spec file with the latest code changes * Modified the seed data to check pagination

* Initial commit for UI/UX changes * Added the existing caseflow search properties * Updated the checkboxes style fix * Changes for spec file with the latest code changes * Modified the seed data to check pagination * Modified the lint issue change for if condition * Modified the lint issue change for if condition

…21371) * create CMP rake task to generate correspondence data in UAT * added vbms doc types to rake task * removed useless method

…-of-veterans-affairs/caseflow into feature/APPEALS-32900

* change eFolderUploadFailedTask Routing * change condicion for efolder --------- Co-authored-by: Jim Foley <james.foley4@va.gov>

* creating review package controller, moving methods, editing routing * Moving review package spec tests to new RP Spec file * cleaning up code from intake controller spec

…1380) Co-authored-by: Jim Foley <james.foley4@va.gov>

- Fix bug causing correspondences not be sorted by VA DOR in ascending (oldest -> newest) order. - Update specs to test this scenario.

* Added a join clause of appeal_type = 'Appeal' to the with_original_appeal_and_judge_task method in the distribution_scopes.rb to prevent a sequential table scan which was causing a database timeout with large datasets in the tasks table in production and prod test. (#21386) Co-authored-by: = <tyler.broyles@va.gov> * Hotfix/appeals 21696 (#21343) * fix(create conference): update test for nil appellant email * fix(create conference): nil appellant email check * fix(conference job): lint * fix(create conference): minor * null * null * null --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Hotfix/appeals 23420 v3 (#21347) * Add LegacyAppealSearchSerializer to rendering * Make additional improvements to the Legacy Serializer * Add MST and PACT to both search serializers respectively * schema check-in --------- Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * hotfix/APPEALS-27522 (#21326) * update erroneous db cleaner syntax and add temp fix to changeset_at_index_for_task method * update changeset_at_index_for_task method to account for lint error * fix lint error and code climate error --------- Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Hotfix/appeals 10993 v2 (#21349) * added logic for deciding aod on attorney claimant * added tests * refactored test to return true when motion is granted --------- Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> * Fixed a bug where some of the Specialty Case Team assign queue settings would take priority over judge assign queue settings for judges who were also members of the specialty case team organization. (#21387) Co-authored-by: = <tyler.broyles@va.gov> * Merge hotfix/APPEALS-43956 into release/FY24Q2.7.0 (#21389) * Added additional logic checks to the attorney task cancel to fix a bug where the cancel attorney task would attempt to update a non existing SpecialtyCaseTeamAssignTask when the appeal matches the sct_appeal? criteria of a 'vha' benefit type. * Removed feature toggle from the checks since the cancel task should work properly for appeals that were disributed while the feature toggle used in distribution was turned on. * Added a regression test. --------- Co-authored-by: = <tyler.broyles@va.gov> * Merge hotfix/APPEALS-43990 into release/FY24Q2.7.0 (#21388) * Added a nil value to the inclusion field of the distributed case validation for the sct_appeal boolean that was causing an error when calling the rename_for_redistribution! on a distributed case where the value was not already set to true and false * Added a regression test for the sct_appeal validation. --------- Co-authored-by: = <tyler.broyles@va.gov> * Added a null coalesce to prevent a javascript error caused by a race condition where remaining users could be nil instead of an array if the user is searching for a user at the same time they are adding a user. (#19487) * APPEALS-43712, APPEALS-43835: Open VeteranRecordRequest and QualityReviewTask are causing distributions to fail (#21354) * remove Appeal.can_redistribute_appeal? from JudgeAssignTask creation during normal distribution * update test * re-add tests for validating each bug scenario * disable mail task test that is failing due to how it is written * updating hearing_shift_date to prevent future hearing dates from occuring in local/demo (#21306) Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> * Lint fixes (#21383) * APPEALS-43423 - AssignedReassignPackageTask remove user limitation (#21400) * Ryandwill/appeals 43393 (#21339) * refactored correspondence_controller_util into correspondence_controller_concern * refactor correspondence_controller * updated method to be class level and in CorrespondenceTask model * Updating the class methods from controller to model * Updated the correspondence_task.rb * Update intake endpoint with custom serialization and move logic to models * update QueueApp with new props * remove controller passed props from redux * update frontend components for correspondence objects new data shape * Update test for controller changes * update test for new controller changes * update test for controller changes * fix typo in error msg and related tests * remove unused argument * remove unneeded prop validation * move task update logic and banner presentation to correspondence tasks controller * move team action to queue controller * rubocop fix * remove review package methods to prepare for feature merge * clean up review package veteran update * fix test to follow assertion * update spec for new pagination requirements * fix typo * refactor reassign/remove package modals for RP page * fix test setup to create RemovePackageTask properly * fix test selector * fix test - quotation marks and hyphen character in string * fix style issues * rspec fixes * update rp controller inbound ops team check * remove pry * removed leftover binding pry * remove pry * remove previously deleted code * fix flaky test * fix tests --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Move Correspondence ART CSS Styling Into a Single Stylesheet- Queue - APPEALS-43392 (#21384) * WIP * All styling has meen moved to scss * Small fixes * fixed inbound ops team being listed in queuetable dropdown (#21405) * fixed inbound ops team being listed in queuetable dropdown * refactored isMailTeamAffiliated * removed commented out code --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Reassign Correspondence Allows Reassignment over 60 Limit (#21403) * Reassign Correspondence Allows Reassignment over 60 Limit * Reassign Correspondence Allows Reassignment over 60 Limit * added limit check to banner message and resolve linting error with safety operator * remove file app/models/concerns/correspondence_controller_util.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Kamalam7/appeals 35469 (#21407) * Return to queue from the Intake form * specs for Return to queue from Intake form * Resolved merge conflicts for Return to queue Intake form * Lint fix in Correspondence intake file --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Wmedders21/appeals 44301 (#21413) * correspondence controller specs live in spec/requests * Remove unused veteran endpoint * Add request tests for user access and feature flag * add tests for review package controller * remove unnecessary line * refactor test for simplecov coverage * remove unneeded test * add intake spec * add controller tests * add erroneously removed method * Fix rubocop style * fix selector in flaky test * add error class to rescue --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Justin/appeals 43606 (#21399) * lining up misaligned brackets * CorrespondencePdfFooter inline styles removed * removing unused class and styling * CmpDocuments.jsx styles into a stylesheet * CorrespondenceReviewPackage.jsx styles into a stylesheet * ReviewForm.jsx WIP * moving css out of ReviewPackageCaseTitle * ReviewForm.jsx styles into a stylesheet * scss fix * CorrespondencePdfToolBar.jsx styles into a stylesheet * ReviewPackageData file scss * removing excess styling to keep textarea at application default sizing * updated test on intake spec * cleaned up old binding pry --------- Co-authored-by: Dev-KRedd <khalin.redding@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Add unit tests (#21421) * added completed_by_date * APPEALS-44300 - Prior Mail test * created approve unit test on ReassignPackageTask model. * added tests * added remove package tasks approve and reject methods * Reassign Correspondence Allows Reassignment over 60 Limit (#21403) * Reassign Correspondence Allows Reassignment over 60 Limit * Reassign Correspondence Allows Reassignment over 60 Limit * added limit check to banner message and resolve linting error with safety operator * remove file app/models/concerns/correspondence_controller_util.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Kamalam7/appeals 35469 (#21407) * Return to queue from the Intake form * specs for Return to queue from Intake form * Resolved merge conflicts for Return to queue Intake form * Lint fix in Correspondence intake file --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * Wmedders21/appeals 44301 (#21413) * correspondence controller specs live in spec/requests * Remove unused veteran endpoint * Add request tests for user access and feature flag * add tests for review package controller * remove unnecessary line * refactor test for simplecov coverage * remove unneeded test * add intake spec * add controller tests * add erroneously removed method * Fix rubocop style * fix selector in flaky test * add error class to rescue --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> --------- Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Christian Cain <149622375+christian-cain-bah@users.noreply.github.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com> Co-authored-by: Aiman Kayad <Akaya005@fiu.edu> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Dani Coleman <60626984+dcoleman21@users.noreply.github.com> Co-authored-by: Drew Hadley <50673809+VandelayUtd@users.noreply.github.com> Co-authored-by: Andrew Hadley <hadley_andrew@bah.com> Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com> Co-authored-by: piedram <110848569+piedram@users.noreply.github.com> Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com> Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com> Co-authored-by: Dev-KRedd <khalin.redding@va.gov>

* consolidated backend checks to use inbound_ops_team_superuser over mail_superuser * updated superuser namespace in the frontend

* cleaned up magic string usage * updated cancel routing for superusers * fixed linting issues * added rerouting for users that cannot access a specific intake * updated Review Package task to be the same user that was assigned the Intake * resolved linting issues * updated inbound ops team superuser check * refactored intake controller test * refactored reassign package task specs and reassignment on cancel * refactored task specs to be more DRY * added intake task fix to intake_form_spec * cleaned up test failures related to intake task within intake. * refactored related correspondence spec tests * updated test to click correct section * updated failing snapshots * fixed typo on prop validations

…ask (#21497)

* added migrations to refactor correspondence intake relationship to task instead of user/correspondence * updated model relations and controller check for an open intake * updated specs to reflect code changes. * removed leftover pry

* draft pr * Completing AC for ticketing for styling and error portion of page. Now doing feature test * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* ccc * gggg * gggg

* working checkboxes and permissions area * latest changes for sharing * changing css styling and moving stuff over to .scss file * added state tracking for nod checkbox * Added superuser checkbox functionality * moving scss to dedicated file * changing padding to add with checkbox padding for total of 30px * removing console logs and adding back top border * permissions now come through props * updated to dynamically render checkboxes * generating nod checkbox if parent exists * Adding column default_for_admin on organization_permissions * reducing payload for organizationPermissions * Fixing checkboxes to behave when different boxes are checked * Proptypes addition for linting * creating route for patch * WIP user permissions * Getting started on spec writing. Not working yet! * reverted organization_permissions to hopefully avoid everyone running a make reset for this data. * reworked the remove and add permissions patch method. * added a little documentation to OrganizationUserPermissionChecker * Moving to correct spec, and working on other ways of writing the test to get it to pass * checkboxes now read state off the backend * checkboxes partially working * fixed state bug * implemented superuser checkbox and disabling of it. * schema change and re-adding default admin column * created basic feature tests for inbound ops team management * continuing working on the controller spec * moved user permission/admin check to user model * house keeping * added conditional for admin permission checkbox rendering. * working superuser checkbox restriction * fixed checkbox default value bug * refactored permission shape * removed old methods * checkboxes fixed (I think) * set up admin check to return bool instead of obj * refactored organization permissions and updated test factories to stage permissions * working seed data * removed binding prys * fixed checkbox logic. needs suggestion changes though * created feature test for inbound ops team * changed list to div * fixed several parts of code based on feedback * added conditional rendering * refactored glamor style into javascript object for checkbox * fixed schema * reverted org permissions json file to its intended design * reverted valid_permission_names back to its intended state. * fixed seed data * linting fix * mostly refactored * included new frontend data (not wired) * data population refactor finished * fixed color * Added a customizable per page task limitation attribute to QueueTab that is used by task_pager to allow an adjustable maximum number of tasks per tab. (#21594) Co-authored-by: = <tyler.broyles@va.gov> * fixed lingering css * APPEALS-42958: Consolidated Superuser Permissions Check (#21454) * consolidated backend checks to use inbound_ops_team_superuser over mail_superuser * updated superuser namespace in the frontend * APPEALS-44391: Intake Correspondence Rerouting (#21447) * cleaned up magic string usage * updated cancel routing for superusers * fixed linting issues * added rerouting for users that cannot access a specific intake * updated Review Package task to be the same user that was assigned the Intake * resolved linting issues * updated inbound ops team superuser check * refactored intake controller test * refactored reassign package task specs and reassignment on cancel * refactored task specs to be more DRY * added intake task fix to intake_form_spec * cleaned up test failures related to intake task within intake. * refactored related correspondence spec tests * updated test to click correct section * updated failing snapshots * fixed typo on prop validations * added prop to hide dropdown if review package has an efolder failed task (#21497) * APPEALS-44390: Soft Delete Correspondence Intake (#21508) * added migrations to refactor correspondence intake relationship to task instead of user/correspondence * updated model relations and controller check for an open intake * updated specs to reflect code changes. * removed leftover pry * APPEALS-43421: Attorney Selection Sticking on Dropdown after Assignment (#21401) * redo init commit * updated imp. logic * attorney widget fix --------- Co-authored-by: Calvin <Calvin.Costa@va.gov> * Add ruby CE API Gem * remove correspondence changes from schema.rb (#21468) * Revert "Add ruby CE API Gem" (#21479) This reverts commit c78afe3. * Override SCT Bulk Assign Page task limit (#21465) * Override SCT Bulk Assign Queue 15 case limit & Adjust SCT attorney assign task action label * feature/APPEALS-35707-29633-29632 (prodtest) (#21485) * 🔀 Squash merge AlecK/APPEALS-35707 - Replace `database_cleaner` with `database_cleaner-active_record` * 🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances * 🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash * feature/APPEALS-44871 Steps for installing node in the Caseflow demo environment (#21483) (#21484) * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Revert "feature/APPEALS-44871 Steps for installing node in the Caseflow demo …" (#21489) This reverts commit a626200. * Sbashamoni/appeals 44871 node14 demo fixes (#21490) (#21495) * Changed dockerfile to install node through NVM * Update env.sh with node 14.20 path * Removed unused node env * Update Dockerfile Removed unused node env variable * Removed unused node env * add error rules to demo builds (#21496) (#21498) Co-authored-by: davis-dwayne <47563178+davis-dwayne@users.noreply.github.com> * added back in schema changes removed from master * draft pr (#21509) * draft pr * Completing AC for ticketing for styling and error portion of page. Now doing feature test * added ability for user to search by css id * added feature tests for using search bar * reverted changes in package.json * removed added file * removed linting error --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * draft pr * searchable by 2 characters instead of 1 * added ability for user to search by css id * reverted changes in package.json * removed added file * fixed params.permit issue * removed organization made with includes * reverted gemfile to master branch version * Fixed linting. fixed get request back to patch * removed unused glamor * pulled gemfile from feature * removed old tests that were cancelled. fixed typo * added dryness to seed data, and fixed rubocop warnings. * fixed method name * disable_permission helper method added * added enable permission helper method * linting fix. removed lingering unused tests * fixed reek issues, moved several methods to private * moved other seed helper methods into private * removed unused variable i * experimental schema fix * fixed failing test * fixed bug so that props is now used as fallback * fixed bug for finding org users * removed permission because constants file was reverted * removed old constants file reworks now that they're reworked * bugfix for admin checked value, improved linting * removed stray comment --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com> Co-authored-by: Calvin <Calvin.Costa@va.gov> Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: sbashamoni <138054633+sbashamoni@users.noreply.github.com> Co-authored-by: davis-dwayne <47563178+davis-dwayne@users.noreply.github.com> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com> Co-authored-by: IsaiahBar <isaiah.barnett@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com>

…21558) * updated styling for correspondence cases and tasks related/not to appeals * fixed linting issue * updated class styling to be an array to match props * updated css in intake, add appeal view, and add evidence submission view * added missing div * moved css for add task view, add appeal tasks view, and unrelated tasks view * updated existing appeal tasks view * Modified the scss file with defined variable * Modified the scss file with defined variable for other colors * adjusted button padding --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov>

* seedcreating superusers * changing superuser definitions * auto assign seed work * updating superuser test factory for spec tests * fixing tests * fixing linting and DB column conflicts * verifying inbound ops superusers have the new superuser permission * updating fixing the seed file

* updated mail_supervisor? to inbound_ops_team_supervisor? * added admin check for inbound ops team supervisor permission * updated isMailSupervisor namespace to isInboundOpsSupervisor * updated userIsCorrespondenceSupervisor to userIsInboundOpsSupervisor * added inbound_ops_team_supervisor and added to correspondence cases spec. * fixed some tests, left binding pry to mark where it starts failing again * fixed failing tests * fixed all failing tests * fixed failing va dor field failure * fixed search bar spec * fixed more failing tests * fixed failing specs * fixed failing tests * fixed failing tests * fixed failing tests * fixed failures that emerged with fixes * potentially fixed several rspecs * resolved failing test * fixed autotext modal test * fixed more failing tests * fixed failing controller tests by changing where user is treated as supervisor * fixed failing test * fixed failing test * fixed timeout on test * several linting fixes * additional linting fixes * linting fix * linting fixes * linting fix for spacing * css and linting fix * fixed failing rspec * maybe fixed failing prs on knapsack * attempted intake_spec fix --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* added component. component renders permissions. * added userPermissions to OrganizationPermissions * updated changes * unstuck sticky checkboxes * added additional fix for checkboxes * added prop to OrganizationPermissions. Added db reading for checkbox values. * set up organization permission checkboxes to appear in correct order * fixed checkbox state. * added checkboxes children handling * removed console log * fixed checkboxes rendering when super user permission was enabled by admin * removed leftover code in OrganizationUsers, resolved linting errors. * added clarifying comment * removed unused code * added conditional check for org permissions to display checkboxes --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Removes unnecessary columns from correspondences table * Updated the datatype bigint * Commit for spec failuers * Lint fixes and some spec fixes * Revert the changes for correspondence_task_helpers.rb * Updated back with previous changes * Revert the changes for client/app/queue/correspondence/intake/components/ReturnToQueueModal.jsx * Updated the PG::ForeignKeyViolation: ERROR for package_document_types --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* added component. component renders permissions. * added userPermissions to OrganizationPermissions * updated changes * unstuck sticky checkboxes * added additional fix for checkboxes * added prop to OrganizationPermissions. Added db reading for checkbox values. * set up organization permission checkboxes to appear in correct order * fixed checkbox state. * added checkboxes children handling * removed console log * fixed checkboxes rendering when super user permission was enabled by admin * removed leftover code in OrganizationUsers, resolved linting errors. * added clarifying comment * updated seed data to include default_for_admin on superuser --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

Fix for merge conflict

* Moved the 3 checks to public method initial commit * Modified the code as per the suggestions * Lint fixes * Updated the spec fixes

* fixed css causing searchbar errors * removed dead css attributes * improved edge matching on searchbar width

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Inital commit for Remove of MAX_QUEUED_ITEMS * Modified current_user * added auto assign permission check to process_tasks_if_applicable * Banner modifications for unassignable_reason in auto_assignable_user_finder.rb file * fixed duplicate warnings * bug fix for user permission checker * updated NOD error message to reflect ACs * removed redundant permission check * updated the error message for bulk capacity failure. * Updated sensitivity error message * Updated the spec file issues * fixed failing tests * Nod permission check spec * changed query type --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov>

* new branch for inbound_ops_team_user changes * more changes * changes for database * updated changes for InboundOpsTeam * update inbound name * update name * update spec test * remove comma * namespace validation * fixed plurality * change namespace for correspondence verification * fix plurality changes * remove brackets * fixing spec test * update naming * update spec tests... again :) * update affilaited * updated correspondence access check to handle if no user is present, and removed old checks that are not needed * excluded admins from inbound ops team user check * added comment for validation check * added check for system users and allow system users to create correspondence tasks * updated seeds and correspondence validation to check current session user * fixed linting issues * updated factory to sign out system user, removed other org checks from the controller validation, and added back in guard clause for correspondence intake task creation. * reverted mail team change from inbound ops * added saftey operator to system user check * removed factory changes and added validations to correspondence create_from_params methods * moved created methods to self and updated failing test * fixed failing tests * fixed failing correspondence tests * fixed failing tests by adding test user back into MailTeam org * fixed failing test in review package spec by adding back in MailTeam or assignment * updated failing tests and linting issues in tests * fix linting issues in organization users scss * pshing up linting fixes for correspondence.scss * finish lint clean up * fixed test failures * resolved linting issues in stylesheet * resolved failing test in intake spec * resolved failing test * fixed permission check to check current user * fixed styling issue with pagination buttons * removed Jolly Postman from seed data * upped wait time. * updated verify_correspondence_access to accept a user param * fixed linting issues in _correspondence.scss * fixed correspondence_intake_spec test and fixed linting issues on _correspondence.scss stylesheet * fixed method name on inbound ops team seed member creation in correspondence_auto_assign.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Ki/APPEALS-41707 - Intake: Update and remove fields (#21473) * APPEALS-41707 - Functionality and some CSS * APPEALS-41707 - Updates * APPEALS-41707 - Unrelated Specs and Correspondence CSS Lint fixes * APPEALS-41707 - Additional Linting * APPEALS-41707 - More Clean up * APPEALS-42281 - displaying NOD of correspondence in review package page (#21528) * APPEALS-42281 - displaying NOD of correspondence in review package page * fixing package document type alignment * Khalin/appeals 41705 (#21450) * WIP * VA DOR update * VA DOR date text area working as intended * Functionality working as intended * Styling * CPM info removed * Fixed some failing tests * WIP * VA DOR Read Only Styling * Edit CMP Test Passing * Fix Jest Job Test * Jest test fix WIP * Jest test fix WIP #2 * ReviewForm.test.js Provider Store Update * Styling * style * styling * remove unused --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> * Package document type styling (#21546) * bug fix for NOD update (#21544) * bug fix for NOPD update * APPEALS-42281-bug-fix - fix to update the nod on selection of correspondence document * Add data for VA 10182 (#21553) * Review Package General Info Section Spacing Change (#21559) * Review Package text spacing (#21560) * Ki/APPEALS-45367 - Intake - Confirm 3 - Package Document Type (#21571) * APPEALS-45367 - Fixed Linting. Fixed unnecessary delete * Rspec fixes * update package document type NOD/NON-NOD (#21584) * update NOD * fix rubocop issues * Khalin/appeals 45567 Request Package Action Modals Updated (#21590) * Functionally complete * Jest test fix * Khalin/appeals 41706 Intake: Remove Mail Tasks (#21572) * 'Returned or undeliverable mail' and 'Sent to ROJ' to be removed * Fix faling tests wip * Fixed test * Update correspondence_intake_processor.rb * Update tasks.js --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Mail Task Position Correction (#21597) * added changes to display intake appeal button based on NOD NON-NOD (#21618) * added changes to display intake appeal button based on NOD NON-NOD * updated to display intake appeal button after editing the document type * fixing lint issues * Update correspondence_review_package_controller.rb Updated syntax instead of each to find_each --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Khalin/Appeals 45367 - NOD/Non-NOD Bug Fix (#21619) * Bug Fixed NOD/Non-NOD Functioning Correctly * Triggering test --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Khalin/appeals 45367 NON/Non-NOD Status Fix v2 (#21664) * NOD/Non-NOD status Fix * Kicking off tests * Kicing off tests * Caceves/appeals 46003 (#21661) * Add inbound ops super user & adjust inbound ops normal user, disable VA DOR logic for super user * Add automatic seeding of inbound ops team super user * fix for continue button on select of yes no (#21721) * Sivakesh/appeals 44110 - Correspondence CSS Issues (#21763) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * Khalin/appeals 45867 (#21703) * WIP * Reverting changes * Save Changes Bug Fixed * Return To Queue button working as intended * Prevents save action in case of errorMessage * WIP * WIP * Working as intended * Removing comments * fixing tests * fixing lint error --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> * Sivakesh/appeals 44110 (#21775) * #44110 - moved all ReceiptDatePicker styles to correspondence scss file * #44110 - moved all TaskCompletedDatePicker styles to correspondence scss file * #44110 - moved all AddLetter styles to correspondence scss file * #44110 - moved all NewLetter styles to correspondence scss file * #44110 - moved all CorrespondencePdfUI.jsx styles to correspondence scss file * #44110 - lint errors * Remove old seed data (#21780) --------- Co-authored-by: Ki Mau <ki.mau@va.gov> Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com>

…correspondence_nod

* added previous work to new branch * removed magic strings

…djustment (#21797) * fix team management verbiage * fix verbiage spec test

…ondences.rb (#21805) * refactored seed data to prevent bug where a user wasn't available. * moved auto assign logic higher up and updated superuser selection

…0 success message. (#21820)

* Created new file for correspondence and modified some changes from correspondence_auto_assign to user * Shifted the auto_assign_permissions method to users.rb file * Nod Permissions method is shifted to users * Modified the create! method with find_or_create_by * Fix for inbound_ops_team_superuser check * Moved correspondence_types and package_document_types into new seed file * Move code from queue_correspondence to new seed * Added a document type for every correspondence * Removed all the related correspondences seed files * Deleted the merged files again * Modified the rake tasks file and renamed the file to correspondence * Modified the appeals creation for veteran from 10 to 15 * Updated the spec files with seed class * Users sepec count update

…down (#21826) * draft pr * DELETE COMMENT * satisfy line length * pushing up changes for "Create Record" button * refactored correspondence button check in review package workflow * removed useEffect that was causing the button to become enabled when it shouldn't * disable create record button if there is no correspondence type on the correspondence --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Renamed the vbms types file * Renamed the vbms types file old file

* Removed aria-label for link in veteran details * Modified the spec file of aria-label --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* remove redundant find_by's * removed comma * removed commas --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Caceves/appeals 41709 v5 (#21878) * APPEALS-41709 - Uncorrupted Branch; First commit - Remove Columns from Correspondences * APPEALS-41709 - Drop package_document_types Table * Update remove * Updating Serializer for Correspondence * Removing portal_entry_date * Removing source_type * Removing cmp_packet_number * Removing cmp_queue_id * Removing package_document_type_id * package_document_type * Fix merge issues with table * Update Migration inheritance * Remove package_document_type from correspondence model * WIP working on safely removing old package document type * Restore queue_column * Restore correspondence_queue_column.rb * Restore client test correspondence.js * More package doc type removals * Remove unused package document type * Remove package document type and fix closing end statement * Remove package document type from spec * Fix 2 linter issues * Update queue_helpers to not use package_doc_type * Adjust docket_number & docket_name because was getting an error on the explain page * Fixed lint issue --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> * Update migration to have safety assured * Siva-Khalin/Appeals 43239 (#21811) * Setting up skeleton for future ACs * #43239 - AC 2 * #43239 - create new route and verify access is added * #43239 - #AC2 added link to queue tab * AC1 WIP * Updating access_allowed method * WIP * #43239 - #AC4 added new correspondence_admin feature toggle * AC1 Done * #43239 - added AC5.1 and AC5.2 * #43239 - moved text to constants * AC 5 WIP * #43239 - added number field and submit button * #43239 - limiting veteran file numbers to 10 * AC 5 continued WIP * #43239 - CSS Updates * #43239 - AC 5.6.2 and AC 5.6.4 * file_number check method * invalid_file_num_error_message ruby Method * #43239 - correspondence controller specs * #43239 - removed unused code * Routes WIP * Get Correspondence Test Route Working * #43239 - generate correspondence route * #43239 - Added FE changes for success response * #43239 - removed correspondence size in the api response * Fix various minor rubocop offenses * WIP generate_correspondence * #47513 - Test Correspondence Jest Tests * #47518 - Generate Correspondence updates * #47518 #47512 - specs for BE methods * #43239 - lint * #41709 - removed columns * removed unused code * lint * lint fixes * revert Gemfile.lock --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com> --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com> Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov> Co-authored-by: Alexander Smith <alex.smith.99@thunderyard.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com>

* Removing requirement for correspondence_type_id to be assigned * removing correspondence_type_id from being built in seeds files in queue_helpers

Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

…oller (#21940)

* comment for source change to register * refactored appeals_controller to use params safely. regression test clean. * untested correspondence_controller params change. * refactored correspondence_document_controller. regression tested. * refactored unsafe params. regression tested. * removed shared params inside concern (bad practice) * refactored param safety. regression tested. * refactored unsafe code. manually tested * refactored params to be secure. regression tested. * broke params into multiple lines * refactored missing params into secure ones. regression tested again. * refactored potential incorrect param * minor param refactor. * removed binding.pry and updated params.permit. regression tested again. * fixed param issue * updated params.permit * fixed params issue * another param fix * second attempted fix * might have actually fixed it * another fix attempt * fixed linting issues * removed unused default params * fixed rubocop complains with helper methods * changed helper methods to be a constant * moved pdf_params into separate method in correspondence_review_package_controller --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* #44296 - Updated labels * #44296 - Updated specs * #44296 - Updated labels to sync with every other label in file

* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * Spec fixes for single and multiple batch assignment * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * made changes to grammar and updated unit tests to match * refactored banner logic to let auto user finder be the source of truth for assignment errors * refactored logger to log the most recent unassignable reason from the auto assign user finder. * fixed linting errors --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

…kage modal on Review Package form (#21964) * initial commit * added .match.params to handle history props in QueueApp routing * displaying banners for the correspondence review package actions * Removing debugger * removing the comment --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Passing rspec tests * correspondence_review_package_controller_spec.rb fix * Fixing checkbox test spec

* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * updating failed assignment header texts * Spec fixes for single and multiple batch assignment * updating failed assignment reason errors * updating tests to pass with new messages * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * Changing the banner text method name to match incoming changes from feature * adding build method for single error message * fixing a mistake in my switch case code * Fixing up some reasons for single errors * correcting capacity error wording from multiple assignments ticket * adding "to user" text and matching messages across single and multiple assignment errors * Updating comments and spacing for code readability * Reverting to feature from tests because of wacky failures * updating mail team user to inbound ops team user in test descriptions * updating single assignment and batch assignment tests to match new labels * removing deprecated methods * fixed linting errors --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

#21939) * APPEALS-48218 - edit_cmp_information_rspec Updates * #48582 - Corrected test data and added initial states * APPEALS-48218 - CodeClimate Updates * APPEALS-48218 - CodeClimate Updates * Lint * Linting * CC Updates --------- Co-authored-by: psivakeshva <sivakesh.pachipulusu@va.gov>

…or does not show (#22029) * fixing an accidental bug where a bullet point containing a single error does not show * updating name

* CodeClimate TL Approved Comments * CodeClimate Updates 2 * Reek Update * Reek 2

…ment Type (#22019) * update nod * update nod * push up changes for nod * update parameters for create_correspondence_document * remove method --------- Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* fix for the save changes button * fixing jest and rspecs * fix rspec

…was removed when merging master

…eview (#22066) * created testCommits git command * updated git-test-commits namespace and reorged file to run ruby tests then js tests * added clean push command * added clean test and user input to script * updated namespace of clean-pr and refactored to allow the use of a branch parameter * test commit * reverted test commit change * refactored git commit and reverted test code change in correspondence.rb * added formatting, fasterer, scss-lint, lint, and prettier tests * added scss commit changes * added safe auto correct option to clean-pr command

…espondence (#22092)

…Creating Correspondences (#22115) * added guard clause to response * added document creation to UAT test correspondence workflow * remove domplexity note creation

* #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>

* Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>

* Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

This reverts commit 20a6a09.

* Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov>

…rs are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>

* Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov>

…rs are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>

* Save Button Is Not Enabled When VA DOR Date Is Updated (#22049) * fix for the save changes button * fixing jest and rspecs * fix rspec * updated parameters in controller to permit batch id (#22084) * Update explain controller appeal_affinity to test if appeal is a correspondence (#22092) * added guard clause to response (#22113) * APPEALS-51209: UAT Test Data Workflow Does Not Create Documents When Creating Correspondences (#22115) * added guard clause to response * added document creation to UAT test correspondence workflow * remove domplexity note creation * Sivakesh/appeals 48375 (#22064) * #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * APPEALS-51367: Fixed Bug with Improper Routes in Review Package (#22126) * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> * APPEALS-50730 : Auto Assign Algorithm Continues when No Available Users are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * removed unused task (#22143) * Ki/APPEALS-42516 - Create Details Page Shell (#22122) * Reforged * Reinstante VetCorrespondence * correspondence_details temporary fix * Sivakesh/appeals 48375 (#22064) * #48376 - Restricted Generate Correspondence button * #48381 - Restricted correspondence count to 1-40 * #50329 - created auto assign checkbox * #50330 - generate correspondence functionality * #50392 - specs for the generate correspondence functionality * resolved merge conflicts * lint issues addressed * #48377 - Jest Tests * Fix of rubocop offense --------- Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * Refactor Review Package Frontend (#22073) * Call the serialized correspondence in Review Package * Added correspondenceTypes to review_package controller method * Added has_efolder_failed_task private method to review_package controller method response * Modified the efolder_upload_failed_before method in backend and frontend as per the comments * Replacing with serialized methods * safespot for rollback * reviewform appearing stable and not regressing * stable rework point * Fixed the banner alert when hasEfolderFailedTask is true * remaning banner updates to the useEffect function * Modified the change to display correspondenceDocuments array inside the hash of correspondence * Replaced apiresponse with props * Adjusted the display intake button to enabled after save changes * Removed show method * Commit changes for isEditableDataChanged with prop values * fixed issue with page load due to out of bounds array accessing * potential fix for form fields * Can able to edit notes * Removed correspondenceDocuments props and utilize the props from correspondence props * Modified the reviewPackageReducer.js * fixed params issue. removed unused method. fixed intake appeal logic. * fixed params issue. removed unused method. fixed intake appeal logic. * changes variable name from NEW_DATA_CHANGEME to reviewPackageData * Intake Appeal Button enabled fix * Fix for Document Type edit form * Fix for PDF reader when we click on edit link * fixed params issue * Removed puts * Spec fixes for review package controller * Rubocop fixes * fixed linting issues * Fix for form updates for review package * Changed disable flag. * fixed intake button logic * Updated the veteran file number fix * Modified to previous change for veteran file number fix * Rubocop fixes * Lint fix * Jest fixes * APPEALS-47125: Refactor frontend (#22102) * refactored review package to not use editable data * removed reviewDetails and refactored save button state management * fixed linting errors in routes page * refactored review form saving and error handling * updated efolder check to display review package actions if there is no efolder failed task * updated props for new props route * fixed bug where package action wouldn't be created if a review package had closed child tasks * added safe params * removed requirement for notes to be filled out in form * removed unused routes * resolved linting errors in correspondence test controller * removed outdated tests * fixed bug where document type wasn't updating NOD (redux action was disconnected) * refactored intake button to only show if NOD and the page isn't Read Only * removed unused document action * fixed failing lint issues and updated rspec * Jest tests fixed and working again. --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> * APPEALS-51367: Fixed Bug with Improper Routes in Review Package (#22126) * Update Scope * Revert "Update Scope" This reverts commit 20a6a09. * updated review package routes * Intake Updates * resolved issues on intake spec --------- Co-authored-by: KiMauVA <Ki.Mau@va.gov> * APPEALS-50730 : Auto Assign Algorithm Continues when No Available Users are Available (#22106) * draft pr for error for unassigned auto assign * fix * call error method in auto assigner file * return error method in assign method * update logger banner * removed outdated code. * update spec test from nil to error * update test * update auto assigner file * refactored break condition in auto assigner logic and updated tests --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> * APPEALS-42516 - Controller Updates, Spec and Route details * Remove facols file --------- Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com> Co-authored-by: Christopher Aceves <christopher.aceves@va.gov> Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com> * Lint fixes (#22134) * Lint fixes * Updated the color variables * Updated the color variables for hsl values * Fix for MergeableSelector for corr class * Fix rubocop offenses * Continue fixing rubocop offenses * Update gemfile lint rubocop offense * MergeableSelector fix for class cf-form-textinput * Fix for the newly added lint issues * Fix for the cf-form-textinput lint issue * Fix for MergeableSelector in team_management.scss --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> * Revert "Ki/APPEALS-42516 - Create Details Page Shell (#22122)" This reverts commit 667d590. * Fix flaky lint & specs --------- Co-authored-by: vinner57 <128258952+vinner57@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: psivakeshva <168677299+psivakeshva@users.noreply.github.com> Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com> Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: divyadasari-va <135847343+divyadasari-va@users.noreply.github.com> Co-authored-by: KiMauVA <Ki.Mau@va.gov> Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com>

* fix code climate issues * fix 4 parameters isseus * fix argument error code climate * fix lint issues * lint fix * fix lint issuues * adding double quotes

* removed all glamor css. * fixed linting.

* APPEALS-42516 - CSS Updates * APPEALS-42516 - Additional CSS for View all link * Deleting empty rulesets for linter * Lintagain * &nsp removal --------- Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>

* Completed Tabs link code modifications * Modified the code changes as commented

…22218) * return the updated serialized correspondence when updating * removed unused veteranInformation (#22221)

…OR date (#22227)

…ews Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method.

* filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues.

…22218) * return the updated serialized correspondence when updating * removed unused veteranInformation (#22221)

…OR date (#22227)

…ews Dropdown (#22230) * added correspondence dropdown checks on the user model * refactored Switch Views dropdown to populate values from backend * removed unused props * added missing param that was passed to method.

* filtered attorney tasks to not include correspondence * added correspondence filtering for other Appeal Queues.

* overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors

…sks. (#22256) * overriding method for all caseflow users to access correspondence details page * Adding tests for other caseflow users on correspondence details page * updating lint failure * Linting fix * adding back true, hopefully fixing lint errors * adding temporary under_constructions task urls for merge and split tasks.

Feature/appeals 34965 demo #22265

Feature/appeals 34965 demo #22265

Commits on Mar 15, 2024

Commits on Mar 18, 2024

Commits on Mar 19, 2024

Commits on Mar 20, 2024

Commits on Mar 21, 2024

Commits on Mar 22, 2024

Commits on Mar 25, 2024

Commits on Mar 26, 2024

Commits on Mar 27, 2024

Commits on Mar 28, 2024

Commits on Mar 29, 2024

Commits on Apr 1, 2024

Commits on Apr 2, 2024

Commits on Apr 3, 2024

Commits on Apr 4, 2024

Commits on Apr 5, 2024

Commits on Apr 8, 2024

Commits on Apr 9, 2024

Commits on Apr 10, 2024

Commits on Apr 11, 2024

Commits on Apr 12, 2024

Commits on Apr 22, 2024

Commits on Apr 25, 2024

Commits on Apr 29, 2024

Commits on Apr 30, 2024

Commits on May 2, 2024

Commits on May 3, 2024

Commits on May 6, 2024

Commits on May 14, 2024

Commits on May 17, 2024

Commits on May 21, 2024

Commits on May 22, 2024

Commits on May 23, 2024

Commits on May 24, 2024

Commits on May 29, 2024

Commits on May 30, 2024

Commits on May 31, 2024

Commits on Jun 3, 2024

Commits on Jun 4, 2024

Commits on Jun 5, 2024

Commits on Jun 6, 2024

Commits on Jun 12, 2024

Commits on Jun 13, 2024

Commits on Jun 14, 2024

Commits on Jun 17, 2024

Commits on Jun 18, 2024

Commits on Jun 20, 2024

Commits on Jun 21, 2024

Commits on Jun 24, 2024

Commits on Jun 25, 2024

Commits on Jun 26, 2024

Commits on Jun 27, 2024

Commits on Jun 28, 2024

Commits on Jul 2, 2024

Commits on Jul 3, 2024

Commits on Jul 5, 2024

Commits on Jul 9, 2024

Commits on Jul 10, 2024

Commits on Jul 11, 2024

Commits on Jul 12, 2024

Commits on Jul 15, 2024

Commits on Jul 16, 2024

Commits on Jul 17, 2024

Commits on Jul 18, 2024

Commits on Jul 19, 2024

Commits on Jul 22, 2024

Commits on Jul 23, 2024