-
Notifications
You must be signed in to change notification settings - Fork 687
Standup Notes 2020 02 10
Erik Moeller edited this page Feb 12, 2020
·
1 revision
Participants (alphabetical): Allie, Conor, Erik, Jen, John, Kevin, Kushal (async), Mickael, Nina, Ro
- Status of signing procedures?
- After apt cutover we'll do a signing test this week
Yesterday:
- Landed a few PRs Thursday, discovered unexpected issue on Friday where we were syncing just for the # of retries; that was fixed and merged
- Made a PR fix for for a queue bug: https://github.com/freedomofpress/securedrop-client/pull/787
- It wasn't clear when we to start, resume, stop, or pause queues, so made a PR to refactor and include documentation: https://github.com/freedomofpress/securedrop-client/pull/786
Today:
- Review https://github.com/freedomofpress/securedrop-sdk/pull/110
- Most likely reveiew the followup: https://github.com/freedomofpress/securedrop-client/pull/784
- Review https://github.com/freedomofpress/securedrop-client/pull/789
- Update architecture docs around the queue
- Continue to be responsive in ongoing reviews and if there is time work on cupsenable bug
Blockers or Asks: None
Yesterday:
- apt prod conversion to lfs-backed repo
- heads up: apt prod will only the most recent version of a package (apt-test has been the same for ~2 months)
- held off on prod cutover due to weekend, ready to go now
Today:
- promote apt-qa -> apt-prod
- review https://github.com/freedomofpress/securedrop-workstation/pull/443 (small)
- enforce dom0 updates in preflight https://github.com/freedomofpress/securedrop-workstation/issues/427
Blockers or Asks:
- post apt cutover, we are unblocked for workstation kernels to prod (https://github.com/freedomofpress/securedrop-workstation/issues/441); can handle, suggest another signer does
Yesterday: (Friday)
- Add more tests to sdw-notify PR (#445), submitted for review
- Final Icinga testing & docs
Today:
- Client/workstation testing & docs
- Follow-up to #445 as needed
Blockers or Asks: None
Yesterday:
- made securedrop-sdk ready for review fixing the session expired that pops up intermittently: https://github.com/freedomofpress/securedrop-sdk/pull/110 (there will be a corresponding SDK release and client changes after that which are in a wip PR on that side)
- some reviews
Today:
- client functional test 788 review
- doing some large file testing
- will do the refactoring/documentation review in 786
- will see how the review pile is looking at this point else might will pick another ticket
Blockers or Asks:
- None
Yesterday:
- Out
Today:
- https://github.com/freedomofpress/securedrop-client/pull/768
- Reverting some passing of SQLAlchemy objects via exceptions/signal handlers
Blockers or Asks:
- None
Yesterday: (Friday)
- Work on updater "skip updates if recently updated" issue. Proposed approach is to add arg for delta time, provision default value via Salt from config.json
Today:
- Cont'd on ^
- Work on #5110
Blockers or Asks: None
Today:
- Spent the whole day with https://github.com/freedomofpress/securedrop-workstation/issues/440
- Draft pr for the above is at https://github.com/freedomofpress/securedrop-workstation/pull/447
Tomorrow:
- adding tests to the pr #447
Blockers or Asks:
- Question on sd-log vm, after the
make all
run, it should be rebooted (addressed in PR)
Yesterday:
- updated https://github.com/freedomofpress/qubes-template-securedrop-workstation/pull/11 - still WIP need prod artifacts to fully test, https://github.com/freedomofpress/securedrop-workstation/pull/439 to remove the logic from securedrop-workstation repo for decoupling purposes
- comments on https://github.com/freedomofpress/securedrop-workstation/pull/447 ,
- review of https://github.com/freedomofpress/securedrop-debian-packages-lfs/pull/8 and back-end
- review of https://github.com/freedomofpress/securedrop/pull/5115
Today:
- https://github.com/freedomofpress/securedrop-workstation/pull/445
- Final review and merge of https://github.com/freedomofpress/securedrop/pull/5115
Blockers or Asks:
- (conor will review) https://github.com/freedomofpress/securedrop-workstation/pull/443 visual review probably acceptable here, since tests are currently failing on master
-
Today: *
- Created draft PR #788 so folks can see how I propose we do functional testing. Happy to change anything and would appreciate feedback. TODO: specification of key user-paths through the app to exercise as part of functional tests. Given some steer on this, I'll add such tests to this draft PR.
- Created PR #789 to update the login screen to use the latest assets provided by Nina and reflect the latest changes also requested by Nina. Please check out my commentary in that ticket about a couple of things I needed to fix up / change that were not explicitly requested in the original ticket (#710).
- Created PR #790 to only show last refresh information if user isn't logged in, or they're experiencing network related problems (the API queues are paused). Feedback, fixes etc welcome.
- Looked into issue #734, but I suspect this has already been fixed by changes that landed in master last week.
-
Blockers or Asks: *
- No blockers.
- If I don't get any other suggestions I'll make a start on #767 (testing / fixing with large download file sizes -- I'll try to recreate the keyerror since it's not completely obvious without a stack trace what the root cause might have been) or #738 (metadata sync optimization).
- Will re-install Qubes for testing purposes on my sacrificial laptop. :-)
- Further task suggestions welcome..! :-)
Yesterday:
- SD Info Sheet final review, other support comms
- Meetings
- Qubes environment setup
Today:
- Few DST meetings re upcoming engagements, some prep from me on this in coming weeks
- outreach/followup to a few prospective SD orgs
- Support comms
Blockers or Asks: None, looking for UX input on logout changes (New Identity) when Nina is back