Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Subscriber API Endpoint #10741

Merged
merged 12 commits into from
Nov 29, 2018
Merged

Add Subscriber API Endpoint #10741

merged 12 commits into from
Nov 29, 2018

Conversation

gititon
Copy link
Contributor

@gititon gititon commented Nov 28, 2018 •
edited
Loading

This PR adds an API endpoint to get the subscriber count, as required by the Gutenberg Subscription block.

Changes proposed in this Pull Request:

This PR adds an API endpoint to get the subscriber count, as required by the Gutenberg Subscription block.

Testing instructions:

phpunit tests the new endpoint

Proposed changelog entry for your changes:

Addition of Subscriber API endpoint

@gititon gititon added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] In Progress [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Nov 28, 2018
@gititon gititon requested a review from a team November 28, 2018 22:36
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

@gititon gititon requested review from a team November 29, 2018 16:46
@gititon gititon self-assigned this Nov 29, 2018
@gititon gititon added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 29, 2018
@jeherve jeherve added this to the 6.9 milestone Nov 29, 2018
jeherve
jeherve reviewed Nov 29, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question about the use of Jetpack_Subscriptions_Widget here.

_inc/lib/core-api/wpcom-endpoints/subscribers.php Show resolved Hide resolved
@gititon gititon added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 29, 2018
@enejb
Copy link
Member

enejb commented Nov 29, 2018

The code looks great, ❤️ the test!

@enejb enejb self-requested a review November 29, 2018 20:20
enejb
enejb previously approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

_inc/lib/core-api/wpcom-endpoints/subscribers.php Outdated Show resolved Hide resolved
enejb
enejb previously approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the file

enejb
enejb approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving once last time

dereksmart
dereksmart approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gititon gititon merged commit 5035c97 into master Nov 29, 2018
@dereksmart dereksmart deleted the subscriber-api-endpoint branch November 29, 2018 22:17
gititon added a commit that referenced this pull request Dec 7, 2018
@gititon
Add Subscriber API Endpoint (#10741)
3492277
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
changelog: add #10741
441b756
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
changelog: add #10741
b112863
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve left review comments

@lezama lezama lezama left review comments

@dereksmart dereksmart dereksmart approved these changes

@enejb enejb enejb approved these changes

Assignees

@gititon gititon

Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.
7 participants
@gititon @jetpackbot @enejb @lezama @jeherve @dereksmart @matticbot