Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: Register VR block specifically #10934

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Gutenberg: Register VR block specifically #10934

merged 1 commit into from
Dec 11, 2018

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 11, 2018

Since we are going to offer a VR block soon, we need to specifically register it on the server side, so it makes the VR block available in our block availability endpoint.

Changes proposed in this Pull Request:

  • Register the VR block on the server side.

Testing instructions:

  • Spin this PR up, or start a JN site with this branch.
  • Start writing a post.
  • Type window.Jetpack_Editor_Initial_State.available_blocks in your browser console.
  • Verify it contains vr: { available: true }

@tyxla tyxla added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 11, 2018
@tyxla tyxla self-assigned this Dec 11, 2018
@tyxla tyxla requested review from ockham, jeffersonrabb and a team December 11, 2018 13:04
@matticbot
Copy link
Contributor

D22120-code. (newly created revision)

@tyxla tyxla mentioned this pull request Dec 11, 2018
Merged
ockham
ockham approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tyxla tyxla added this to the 6.9 milestone Dec 11, 2018
@jetpackbot
Copy link

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against f215ae2

@tyxla tyxla mentioned this pull request Dec 11, 2018
Merged
oskosk
oskosk approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2018
@tyxla tyxla merged commit 571a681 into master Dec 11, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 11, 2018
@tyxla tyxla deleted the update/register-vr-block-specifically branch December 11, 2018 15:26
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Changelog: add #10934
ab04aa9
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10934
33b1e86
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

@ockham ockham ockham approved these changes

@jeffersonrabb jeffersonrabb Awaiting requested review from jeffersonrabb

Assignees

@tyxla tyxla

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.
6 participants
@tyxla @matticbot @jetpackbot @ockham @oskosk @jeherve