Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect dialog: fix features limits #10962

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Disconnect dialog: fix features limits #10962

merged 1 commit into from
Dec 13, 2018

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Dec 12, 2018

Fixes issue reported in p6TEKc-2rH-p2

Changes proposed in this Pull Request:

  • Fix features limits in disconnect dialog.

Testing instructions:

  • Fire up this PR.
  • Connect Jetpack with both the Premium and Professional plans.
  • Go to your Dashboard and click manage connection.
  • Make sure the features in the disconnect dialog correspond to https://jetpack.com/features/comparison/

Proposed changelog entry for your changes:

  • Disconnect dialog: fix features limits.

@keoshi keoshi added the Admin Page React-powered dashboard under the Jetpack menu label Dec 12, 2018
@keoshi keoshi self-assigned this Dec 12, 2018
@keoshi keoshi requested a review from a team as a code owner December 12, 2018 17:06
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against dc5de69

@oskosk
Copy link
Contributor

oskosk commented Dec 12, 2018

@keoshi is this one ready for review ?

@keoshi keoshi added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Dec 12, 2018
@keoshi
Copy link
Contributor Author

keoshi commented Dec 12, 2018

@oskosk Yes, thanks for noticing. Completely forgot the label.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Feature] VideoPress A feature to help you upload and insert videos on your site. and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 13, 2018
jeherve
jeherve approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. 👍

@keoshi keoshi merged commit d0321bb into master Dec 13, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 13, 2018
@keoshi keoshi deleted the fix/plans-video-limit branch December 13, 2018 10:50
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Changelog: add #10962
5dd5af9
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10962
0aaf760
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@keoshi keoshi

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] VideoPress A feature to help you upload and insert videos on your site.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keoshi @jetpackbot @oskosk @jeherve @matticbot