Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: add WP To Twitter to list of conflicting plugins. #10809

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Sharing: add WP To Twitter to list of conflicting plugins. #10809

merged 1 commit into from
Dec 19, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 4, 2018

Changes proposed in this Pull Request:

Fixes #10795

This change deactivates Jetpack's Twitter Cards when the WP To Twitter plugin is active.

Testing instructions:

  • Activate Jetpack's sharing module.
  • Activate the WP To Twitter plugin.
  • Make sure Jetpack does not output any Twitter Meta Card tags.

Proposed changelog entry for your changes:

  • Sharing: add WP To Twitter to list of conflicting plugins.

@jeherve
Sharing: add WP To Twitter to list of conflicting plugins.
760ce73 
Fixes #10795

This change deactivates Jetpack's Twitter Cards when the WP To Twitter plugin is active.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Low labels Dec 4, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 4, 2018
@jeherve jeherve self-assigned this Dec 4, 2018
@jeherve jeherve requested a review from a team as a code owner December 4, 2018 16:31
@jeherve jeherve mentioned this pull request Dec 4, 2018
Closed
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

brbrr
brbrr approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well :shipit:

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 18, 2018
@jeherve jeherve merged commit 76d175a into master Dec 19, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 19, 2018
@jeherve jeherve deleted the add/wptotwitter branch December 19, 2018 09:22
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Changelog: add #10809
99c5aa6
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10809
ebf2c07
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @jetpackbot @brbrr @matticbot