Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twenty Nineteen: updates to widget styles #10978

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Twenty Nineteen: updates to widget styles #10978

merged 2 commits into from
Dec 20, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 14, 2018

Related: #10335

Changes proposed in this Pull Request:

  • Bring in additional widget CSS adjustments, already committed on WordPress.com (see D22275-code)
  • Add Twenty Nineteen stylesheet to the AutoRTL build, so a twentynineteen-rtl.css file is generated on build and for release.

Testing instructions:

  • Checkout this branch on a site using Twenty Nineteen.
  • Make sure all widgets (especially those with lists) look good.
  • Run gulp frontendcss:separate
  • Make sure you see a new twentynineteen-rtl.css in modules/theme-tools/compat/

Proposed changelog entry for your changes:

  • Twenty Nineteen: additional style adjustments to make sure all Jetpack widgets look good with the theme.

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Theme Tools [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Dotcom Merge [Status] Tested on WP.com labels Dec 14, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 14, 2018
@jeherve jeherve self-assigned this Dec 14, 2018
@jeherve jeherve requested review from crunnells and a team December 14, 2018 15:06
@matticbot
Copy link
Contributor

D22348-code. (newly created revision)

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against dd69e3a

zinigor
zinigor approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the styles are being applied correctly, RTL is generated, so LGTM!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 18, 2018
@crunnells
Copy link
Contributor

👍

@jeherve jeherve merged commit 7f67b8e into master Dec 20, 2018
@jeherve jeherve deleted the update/twentynineteen-css branch December 20, 2018 07:31
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 20, 2018
jeherve added a commit that referenced this pull request Dec 21, 2018
@jeherve
Changelog: add #10978
5002629
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10978
9a18cd9
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crunnells crunnells crunnells approved these changes

@zinigor zinigor zinigor approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Theme Tools [Status] Tested on WP.com Touches WP.com Files [Type] Dotcom Merge [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @crunnells @zinigor